From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Minas Harutyunyan <hminas@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
amstan@chromium.org, linux-rockchip@lists.infradead.org,
linux-usb@vger.kernel.org, Randy Li <ayaka@soulik.info>,
ryandcase@chromium.org, jwerner@chromium.org,
Elaine Zhang <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: [4/4] ARM: dts: rockchip: Add quirk for resetting rk3288's dwc2 host on wakeup
Date: Fri, 12 Apr 2019 16:57:38 -0700 [thread overview]
Message-ID: <20190412235738.GZ112750@google.com> (raw)
On Fri, Apr 12, 2019 at 03:41:49PM -0700, Douglas Anderson wrote:
> The "host" USB port on rk3288 has a hardware errata where we've got to
> assert a PHY reset whenever we see a remote wakeup. Add that quirk
> property to the device tree.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 92e0600595f8..6367c1b50fd7 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -617,6 +617,7 @@
> dr_mode = "host";
> phys = <&usbphy2>;
> phy-names = "usb2-phy";
> + snps,reset-phy-on-wake;
> status = "disabled";
> };
>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Minas Harutyunyan <hminas@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
amstan@chromium.org, linux-rockchip@lists.infradead.org,
linux-usb@vger.kernel.org, Randy Li <ayaka@soulik.info>,
ryandcase@chromium.org, jwerner@chromium.org,
Elaine Zhang <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: rockchip: Add quirk for resetting rk3288's dwc2 host on wakeup
Date: Fri, 12 Apr 2019 16:57:38 -0700 [thread overview]
Message-ID: <20190412235738.GZ112750@google.com> (raw)
Message-ID: <20190412235738.BDh0Nb2BcZwMTaBXWHuvuc_CcOZby2cRqxI0XqWYgrI@z> (raw)
In-Reply-To: <20190412224149.106971-5-dianders@chromium.org>
On Fri, Apr 12, 2019 at 03:41:49PM -0700, Douglas Anderson wrote:
> The "host" USB port on rk3288 has a hardware errata where we've got to
> assert a PHY reset whenever we see a remote wakeup. Add that quirk
> property to the device tree.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 92e0600595f8..6367c1b50fd7 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -617,6 +617,7 @@
> dr_mode = "host";
> phys = <&usbphy2>;
> phy-names = "usb2-phy";
> + snps,reset-phy-on-wake;
> status = "disabled";
> };
>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev reply other threads:[~2019-04-12 23:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 22:41 [PATCH 0/4] usb: dwc2: Another attempt handling rk3288's remote wake quirk Douglas Anderson
2019-04-12 22:41 ` [1/4] dt-bindings: usb: dwc2: Document quirk to reset PHY upon wakeup Doug Anderson
2019-04-12 22:41 ` [PATCH 1/4] " Douglas Anderson
2019-04-12 23:42 ` [1/4] " Matthias Kaehlcke
2019-04-12 23:42 ` [PATCH 1/4] " Matthias Kaehlcke
2019-04-12 22:41 ` [2/4] usb: dwc2: optionally assert phy reset when waking up Doug Anderson
2019-04-12 22:41 ` [PATCH 2/4] " Douglas Anderson
2019-04-12 23:56 ` [2/4] " Matthias Kaehlcke
2019-04-12 23:56 ` [PATCH 2/4] " Matthias Kaehlcke
2019-04-16 21:54 ` [2/4] " Doug Anderson
2019-04-16 21:54 ` [PATCH 2/4] " Doug Anderson
2019-04-12 22:41 ` [3/4] ARM: dts: rockchip: Hook resets up to USB PHYs on rk3288 Doug Anderson
2019-04-12 22:41 ` [PATCH 3/4] " Douglas Anderson
2019-04-13 0:00 ` [3/4] " Matthias Kaehlcke
2019-04-13 0:00 ` [PATCH 3/4] " Matthias Kaehlcke
2019-04-12 22:41 ` [4/4] ARM: dts: rockchip: Add quirk for resetting rk3288's dwc2 host on wakeup Doug Anderson
2019-04-12 22:41 ` [PATCH 4/4] " Douglas Anderson
2019-04-12 23:57 ` Matthias Kaehlcke [this message]
2019-04-12 23:57 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412235738.GZ112750@google.com \
--to=mka@chromium.org \
--cc=amstan@chromium.org \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=felipe.balbi@linux.intel.com \
--cc=heiko@sntech.de \
--cc=hminas@synopsys.com \
--cc=jwerner@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).