linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Ramachandran Srinivasan \(BRT-SG\)" <srinivasan.r@brtchip.com>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v2] usb: serial: defer URB submission for ftdi_sio
Date: Mon, 15 Apr 2019 10:00:58 +0200	[thread overview]
Message-ID: <20190415080058.GA29656@localhost> (raw)

On Tue, Apr 09, 2019 at 10:47:42AM +0000, Ramachandran Srinivasan (BRT-SG) wrote:
> From: Srinivasan R <srinivasan.r@brtchip.com>
> 
> Deferring the URB resubmission, this can help time share the available
> DMA chanels of DWC_OTG host controller in RaspberryPi.This change can
> fix the problem, failed to enumerate the USB device when all the 8
> instance of ftdi_sio serial driver is open by application. many bugs
> had been rasied for RaspberryPi around this problem can be solved

Thanks for resending with a commit message. Your patch is still
white-space damaged (check your mail setup, and make sure you can send a
patch to yourself and apply it with git am), but with the above
description I think I can give some feedback already.

First of all, if there's a problem here, it would need to be fixed in
the host-controller driver of the rpi as we don't want to add
workarounds for host-controller issues to every USB driver.

I suggest you write up an even more detailed bug report describing the
problem you're seeing and send it to the list.

Meanwhile, you can try increasing the latency timer of the connected
ftdi devices to reduce the amount of traffic they generate when they're
otherwise idle (16 ms default, can be increased up to 255 ms I think).
That may possibly allow you to push the limits of the rpi.

Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ramachandran Srinivasan (BRT-SG)" <srinivasan.r@brtchip.com>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: serial: defer URB submission for ftdi_sio
Date: Mon, 15 Apr 2019 10:00:58 +0200	[thread overview]
Message-ID: <20190415080058.GA29656@localhost> (raw)
Message-ID: <20190415080058.re5Cv7jVux95rbsEg-6VTvsRWbXI-ptSsA-lgepu-wY@z> (raw)
In-Reply-To: <1554806826-11543-1-git-send-email-srinivasan.r@brtchip.com>

On Tue, Apr 09, 2019 at 10:47:42AM +0000, Ramachandran Srinivasan (BRT-SG) wrote:
> From: Srinivasan R <srinivasan.r@brtchip.com>
> 
> Deferring the URB resubmission, this can help time share the available
> DMA chanels of DWC_OTG host controller in RaspberryPi.This change can
> fix the problem, failed to enumerate the USB device when all the 8
> instance of ftdi_sio serial driver is open by application. many bugs
> had been rasied for RaspberryPi around this problem can be solved

Thanks for resending with a commit message. Your patch is still
white-space damaged (check your mail setup, and make sure you can send a
patch to yourself and apply it with git am), but with the above
description I think I can give some feedback already.

First of all, if there's a problem here, it would need to be fixed in
the host-controller driver of the rpi as we don't want to add
workarounds for host-controller issues to every USB driver.

I suggest you write up an even more detailed bug report describing the
problem you're seeing and send it to the list.

Meanwhile, you can try increasing the latency timer of the connected
ftdi devices to reduce the amount of traffic they generate when they're
otherwise idle (16 ms default, can be increased up to 255 ms I think).
That may possibly allow you to push the limits of the rpi.

Johan

         reply	other threads:[~2019-04-15  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 11:54 Deferred URB submission for timesharing the DMA channels of DWC_OTG host controller in Raspberry PI Ramachandran Srinivasan (BRT-SG)
2019-04-08 11:54 ` [PATCH] " Ramachandran Srinivasan (BRT-SG)
2019-04-08 13:12 ` Johan Hovold
2019-04-08 13:12   ` [PATCH] " Johan Hovold
2019-04-08 15:52   ` Sergei Shtylyov
2019-04-08 15:52     ` [PATCH] " Sergei Shtylyov
2019-04-10  8:56   ` Ramachandran Srinivasan (BRT-SG)
2019-04-10  8:56     ` [PATCH] " Ramachandran Srinivasan (BRT-SG)
2019-04-09 10:47 ` [v2] usb: serial: defer URB submission for ftdi_sio Ramachandran Srinivasan (BRT-SG)
2019-04-09 10:47   ` [PATCH v2] " Ramachandran Srinivasan (BRT-SG)
2019-04-15  8:00   ` Johan Hovold [this message]
2019-04-15  8:00     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415080058.GA29656@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=srinivasan.r@brtchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).