From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,6/7] usb: typec: displayport: Export probe and remove functions From: Heikki Krogerus Message-Id: <20190416062703.GA1747@kuha.fi.intel.com> Date: Tue, 16 Apr 2019 09:27:03 +0300 To: Ajay Gupta Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" List-ID: T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMTI6NDU6MTJBTSArMDAwMCwgQWpheSBHdXB0YSB3cm90 ZToKPiBIaSBIZWlra2ksCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJv bTogbGludXgtdXNiLW93bmVyQHZnZXIua2VybmVsLm9yZyA8bGludXgtdXNiLW93bmVyQHZnZXIu a2VybmVsLm9yZz4gT24KPiA+IEJlaGFsZiBPZiBIZWlra2kgS3JvZ2VydXMKPiA+IFNlbnQ6IE1v bmRheSwgQXByaWwgMTUsIDIwMTkgNToxMCBBTQo+ID4gVG86IEdyZWcgS3JvYWgtSGFydG1hbiA8 Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPiBDYzogQWpheSBHdXB0YSA8YWpheWdAbnZp ZGlhLmNvbT47IGxpbnV4LXVzYkB2Z2VyLmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFtQQVRDSCB2 MiA2LzddIHVzYjogdHlwZWM6IGRpc3BsYXlwb3J0OiBFeHBvcnQgcHJvYmUgYW5kIHJlbW92ZQo+ ID4gZnVuY3Rpb25zCj4gPiAKPiA+IEZyb206IEFqYXkgR3VwdGEgPGFqYXlnQG52aWRpYS5jb20+ Cj4gPiAKPiA+IFZpcnR1YWxMaW5rIHN0YW5kYXJkIGV4dGVuZHMgdGhlIERpc3BsYXlQb3J0IEFs dCBNb2RlIGJ5IHV0aWxpemluZyBhbHNvIHRoZSBVU0IgMgo+ID4gcGlucyBvbiB0aGUgVVNCIFR5 cGUtQyBjb25uZWN0b3IuCj4gPiBJdCB1c2VzIHRoZSBzYW1lIG1lc3NhZ2VzIGFzIERpc3BsYXlQ b3J0LCBidXQgbm90IHRoZSBEUCBTVklELiBBdCB0aGUgdGltZSBvZgo+ID4gd3JpdGluZywgVVNC IElGIGhhcyBub3QgYXNzaWduZWQgYSBTdGFuZGFyZCBJRCAoU0lEKSBmb3IgVmlydHVhbExpbmss IHNvIHRoZQo+ID4gbWFudWZhY3R1cmVycyBvZiBWaXJ0dWFsTGluayBhZGFwdGVycyB1c2UgdGhl aXIgVmVuZG9yIElEcyBhcyB0aGUgU1ZJRC4KPiA+IAo+ID4gU2luY2UgdGhlIFNWSUQgc3BlY2lm aWMgY29tbXVuaWNhdGlvbiBpcyBleGFjdGx5IHRoZSBzYW1lIGFzIHdpdGggRGlzcGxheVBvcnQK PiA+IGFsdGVybmF0ZSBtb2RlLCB0aGVyZSBpcyBubyBuZWVkIHRvIGltcGxlbWVudCBzZXBhcmF0 ZSBkcml2ZXIgZm9yIFZpcnR1YWxMaW5rLgo+ID4gV2UnbGwgaGFuZGxlIHRoZSBjdXJyZW50IFZp cnR1YWxMaW5rIGFkYXB0ZXJzIHdpdGggcHJvYmUgZHJpdmVycywgYW5kIG9uY2UgdGhlcmUKPiA+ IGlzIFNWSUQgYXNzaWduZWQgZm9yIGl0LCB3ZSBhZGQgaXQgdG8gdGhlIGRpc3BsYXlwb3J0IGFs dCBtb2RlIGRyaXZlci4KPiA+IAo+ID4gVG8gc3VwcG9ydCBwcm9iaW5nIGRyaXZlcnMsIGV4cG9y dGluZyB0aGUgcHJvYmUgYW5kIHJlbW92ZSBmdW5jdGlvbnMsIGFuZCBhbHNvCj4gPiBjaGFuZ2lu ZyB0aGUgRFBfSEVBREVSIGhlbHBlciBtYWNybyB0byB1c2UgdGhlIFNWSUQgb2YgdGhlIGFsdGVy bmF0ZSBtb2RlCj4gPiBkZXZpY2UgaW5zdGVhZCBvZiB0aGUgRGlzcGxheVBvcnQgYWx0IG1vZGUg U1ZJRC4KPiA+IAo+ID4gU3VnZ2VzdGVkLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9n ZXJ1c0BsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBamF5IEd1cHRhIDxhamF5 Z0BudmlkaWEuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSGVpa2tpIEtyb2dlcnVzIDxoZWlra2ku a3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy91c2IvdHlwZWMv YWx0bW9kZXMvZGlzcGxheXBvcnQuYyB8IDEyICsrKysrKystLS0tLQo+ID4gIDEgZmlsZSBjaGFu Z2VkLCA3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gTG9va3MgbGlrZSB5b3UgbWlz c2VkIGFkZGluZyBkaXNwbGF5cG9ydC5oIGZpbGUuIEl0IGlzIGF2YWlsYWJsZSBpbiBvcmlnaW5h bCBwYXRjaCBiZWxvdywKPiAgaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtdXNiJm09MTU1NDky NTg3MjI0Mzc5Jnc9MiAKClRoYXQncyB0aGUgb25lIEkgcGlja2VkLCBhbmQgSSBkaWQgY29tcGls ZSB0aGUgZHJpdmVyIGFzIHdlbGwuLiBJJ20Kbm90IHN1cmUgd2hhdCBJJ3ZlIGRvbmUsIGJ1dCBJ J2xsIHJlc2VuZCB0aGUgc2VyaWVzLgoKU29ycnkgZm9yIHRoZSBoYXNzbGUuCgp0aGFua3MsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13585C10F13 for ; Tue, 16 Apr 2019 06:27:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD93B2075B for ; Tue, 16 Apr 2019 06:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfDPG1H (ORCPT ); Tue, 16 Apr 2019 02:27:07 -0400 Received: from mga05.intel.com ([192.55.52.43]:5304 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbfDPG1G (ORCPT ); Tue, 16 Apr 2019 02:27:06 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 23:27:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="165110935" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Apr 2019 23:27:03 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 16 Apr 2019 09:27:03 +0300 Date: Tue, 16 Apr 2019 09:27:03 +0300 From: Heikki Krogerus To: Ajay Gupta Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" Subject: Re: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove functions Message-ID: <20190416062703.GA1747@kuha.fi.intel.com> References: <20190415120931.61328-1-heikki.krogerus@linux.intel.com> <20190415120931.61328-7-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190416062703.16N_6WX-biu7REJl_FS5_xxag5tCeTe8FWz4Lqzz1rc@z> On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote: > Hi Heikki, > > > -----Original Message----- > > From: linux-usb-owner@vger.kernel.org On > > Behalf Of Heikki Krogerus > > Sent: Monday, April 15, 2019 5:10 AM > > To: Greg Kroah-Hartman > > Cc: Ajay Gupta ; linux-usb@vger.kernel.org > > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove > > functions > > > > From: Ajay Gupta > > > > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2 > > pins on the USB Type-C connector. > > It uses the same messages as DisplayPort, but not the DP SVID. At the time of > > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the > > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID. > > > > Since the SVID specific communication is exactly the same as with DisplayPort > > alternate mode, there is no need to implement separate driver for VirtualLink. > > We'll handle the current VirtualLink adapters with probe drivers, and once there > > is SVID assigned for it, we add it to the displayport alt mode driver. > > > > To support probing drivers, exporting the probe and remove functions, and also > > changing the DP_HEADER helper macro to use the SVID of the alternate mode > > device instead of the DisplayPort alt mode SVID. > > > > Suggested-by: Heikki Krogerus > > Signed-off-by: Ajay Gupta > > Signed-off-by: Heikki Krogerus > > --- > > drivers/usb/typec/altmodes/displayport.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > Looks like you missed adding displayport.h file. It is available in original patch below, > https://marc.info/?l=linux-usb&m=155492587224379&w=2 That's the one I picked, and I did compile the driver as well.. I'm not sure what I've done, but I'll resend the series. Sorry for the hassle. thanks, -- heikki