From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb:host: fix divide-by-zero in function fhci_queue_urb From: Greg Kroah-Hartman Message-Id: <20190416094545.GA896@kroah.com> Date: Tue, 16 Apr 2019 11:45:45 +0200 To: zhuyan Cc: anton@enomsg.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBBcHIgMDksIDIwMTkgYXQgMTA6Mzc6MTJQTSArMDgwMCwgemh1eWFuIHdyb3RlOgo+ IEluIGZ1bmN0aW9uIGZoY2lfcXVldWVfdXJiLCB0aGUgZGl2aXNvciBvZiBleHByZXNzaW9uCj4g KHVyYi0+dHJhbnNmZXJfYnVmZmVyX2xlbmd0aCAlIHVzYl9tYXhwYWNrZXQodXJiLT5kZXYsIHVy Yi0+cGlwZSwKPiB1c2JfcGlwZW91dCh1cmItPnBpcGUpKSkgbWF5IGJlIHplcm8uCgpIb3cgY2Fu IHlvdSBoaXQgdGhhdD8KCj4gV2hlbiBpdCBpcyB6ZXJvLCB1bmV4cGVjdGVkIHJlc3VsdHMgbWF5 IG9jY3VyLCBzbyBpdCBpcyBuZWNlc3NhcnkgdG8KPiBlbnN1cmUgdGhhdCB0aGUgZGl2aXNvciBp cyBub3QgemVyby4KPiAKPiBTaWduZWQtb2ZmLWJ5OiB6aHV5YW4gPHpodXlhbjM0QGh1YXdlaS5j b20+CgpJIG5lZWQgYSAiRnVsbCIgbmFtZSBoZXJlLCBub3QganVzdCBhIHNpbmdsZSBuYW1lLiAg V2hhdGV2ZXIgeW91IHVzZSB0bwpzaWduIGRvY3VtZW50cyBpcyBnb29kLgoKdGhhbmtzLAoKZ3Jl ZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B367AC10F13 for ; Tue, 16 Apr 2019 09:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8112320684 for ; Tue, 16 Apr 2019 09:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555407954; bh=BlHaJfX+k2skE3lCGc1AtyXKIgrIDTDVlB8GM+upJLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mb6jRuXi9tdk1OMSsM8bNDmZISpawIJGw5z/Bo6Wet4T0wNM41jgjnR/tlJBaWfZ6 KRrF8IcvLVHjlxIvzSFPXDtNXxoVLKT6gCQi4H4NJiY5PMBCMKZyBkGYw1bG5+BS2Z 3VnX2QD3awpEq3YK2o5sH7co5I48bKYUOCHSkmgY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfDPJps (ORCPT ); Tue, 16 Apr 2019 05:45:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:35652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbfDPJps (ORCPT ); Tue, 16 Apr 2019 05:45:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A18020684; Tue, 16 Apr 2019 09:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555407947; bh=BlHaJfX+k2skE3lCGc1AtyXKIgrIDTDVlB8GM+upJLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bP90p6aArRpifF4Ml1slnpTGtQ3SSFBoSeR6E6qRbSXkxbbcmtdRf0V05qYoUREp6 3YH7C7sdiKNPlPQCI5zB+51ZlQe9tmAz4jfyVYwbfEnGtoh26w5vv++EOJtUnjP2o/ KGlFQDyZYXAxfhYowuagW+0vHXxB02MePBlkLTSg= Date: Tue, 16 Apr 2019 11:45:45 +0200 From: Greg KH To: zhuyan Cc: anton@enomsg.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb Message-ID: <20190416094545.GA896@kroah.com> References: <1554820632-13782-1-git-send-email-zhuyan34@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1554820632-13782-1-git-send-email-zhuyan34@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190416094545.BiBc9JK6xG_nvmIkSjoG8sXTUO2hyrLvKSCreWIIxuw@z> On Tue, Apr 09, 2019 at 10:37:12PM +0800, zhuyan wrote: > In function fhci_queue_urb, the divisor of expression > (urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe, > usb_pipeout(urb->pipe))) may be zero. How can you hit that? > When it is zero, unexpected results may occur, so it is necessary to > ensure that the divisor is not zero. > > Signed-off-by: zhuyan I need a "Full" name here, not just a single name. Whatever you use to sign documents is good. thanks, greg k-h