From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Ajay Gupta <ajayg@nvidia.com>, linux-usb@vger.kernel.org
Subject: [v2,3/7] usb: typec: ucsi: ccg: add firmware flashing support
Date: Tue, 16 Apr 2019 12:00:44 +0200 [thread overview]
Message-ID: <20190416100044.GD896@kroah.com> (raw)
On Mon, Apr 15, 2019 at 03:09:27PM +0300, Heikki Krogerus wrote:
> +static ssize_t do_flash_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "[Usage]\n"
> + "1) copy ccg_boot.cyacd /lib/firmware/\n"
> + "2) copy ccg_primary.cyacd /lib/firmware/\n"
> + "3) copy ccg_secondary.cyacd /lib/firmware/\n"
> + "4) echo 1 > do_flash\n");
> +}
That is cute, but no, the kernel does NOT provide built-in help texts
for sysfs files. If you know of any existing ones that do this, please
point them out to me and I will go delete them from the tree.
sysfs is "one value per file", and a "multi-line-help-text" is not a
single value.
That is what the Documentation/ABI files are for, which I do not see an
update for in this patch so I can not take it, sorry :(
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Ajay Gupta <ajayg@nvidia.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 3/7] usb: typec: ucsi: ccg: add firmware flashing support
Date: Tue, 16 Apr 2019 12:00:44 +0200 [thread overview]
Message-ID: <20190416100044.GD896@kroah.com> (raw)
Message-ID: <20190416100044.wK0g46xEAxZwf2zpeV2LQxLoP80mzXyFSwrrXSYC6tI@z> (raw)
In-Reply-To: <20190415120931.61328-4-heikki.krogerus@linux.intel.com>
On Mon, Apr 15, 2019 at 03:09:27PM +0300, Heikki Krogerus wrote:
> +static ssize_t do_flash_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "[Usage]\n"
> + "1) copy ccg_boot.cyacd /lib/firmware/\n"
> + "2) copy ccg_primary.cyacd /lib/firmware/\n"
> + "3) copy ccg_secondary.cyacd /lib/firmware/\n"
> + "4) echo 1 > do_flash\n");
> +}
That is cute, but no, the kernel does NOT provide built-in help texts
for sysfs files. If you know of any existing ones that do this, please
point them out to me and I will go delete them from the tree.
sysfs is "one value per file", and a "multi-line-help-text" is not a
single value.
That is what the Documentation/ABI files are for, which I do not see an
update for in this patch so I can not take it, sorry :(
thanks,
greg k-h
next prev reply other threads:[~2019-04-16 10:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 12:09 [PATCH v2 0/7] usb: typec: Remaining changes for v5.2 Heikki Krogerus
2019-04-15 12:09 ` [v2,1/7] i2c: nvidia-gpu: Supply CCGx driver the fw build info Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 1/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,2/7] usb: typec: ucsi: ccg: add get_fw_info function Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 2/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,3/7] usb: typec: ucsi: ccg: add firmware flashing support Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 3/7] " Heikki Krogerus
2019-04-16 10:00 ` Greg Kroah-Hartman [this message]
2019-04-16 10:00 ` Greg Kroah-Hartman
2019-04-15 12:09 ` [v2,4/7] usb: typec: ucsi: Preliminary support for alternate modes Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 4/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,5/7] usb: typec: ucsi: Support for DisplayPort alt mode Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 5/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,6/7] usb: typec: displayport: Export probe and remove functions Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16 0:45 ` [v2,6/7] " Ajay Gupta
2019-04-16 0:45 ` [PATCH v2 6/7] " Ajay Gupta
2019-04-16 6:27 ` [v2,6/7] " Heikki Krogerus
2019-04-16 6:27 ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16 7:46 ` [v2,6/7] " Heikki Krogerus
2019-04-16 7:46 ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16 10:03 ` [v2,6/7] " Greg Kroah-Hartman
2019-04-16 10:03 ` [PATCH v2 6/7] " Greg Kroah-Hartman
2019-04-15 12:09 ` [v2,7/7] usb: typec: Add driver for NVIDIA Alt Modes Heikki Krogerus
2019-04-15 12:09 ` [PATCH v2 7/7] " Heikki Krogerus
2019-04-15 21:12 ` kbuild test robot
2019-04-16 10:02 ` [v2,7/7] " Greg Kroah-Hartman
2019-04-16 10:02 ` [PATCH v2 7/7] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416100044.GD896@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ajayg@nvidia.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).