linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Ajay Gupta <ajayg@nvidia.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: [v2,6/7] usb: typec: displayport: Export probe and remove functions
Date: Tue, 16 Apr 2019 12:03:11 +0200	[thread overview]
Message-ID: <20190416100311.GF896@kroah.com> (raw)

On Tue, Apr 16, 2019 at 10:46:07AM +0300, Heikki Krogerus wrote:
> On Tue, Apr 16, 2019 at 09:27:03AM +0300, Heikki Krogerus wrote:
> > On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote:
> > > Hi Heikki,
> > > 
> > > > -----Original Message-----
> > > > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> On
> > > > Behalf Of Heikki Krogerus
> > > > Sent: Monday, April 15, 2019 5:10 AM
> > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Ajay Gupta <ajayg@nvidia.com>; linux-usb@vger.kernel.org
> > > > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove
> > > > functions
> > > > 
> > > > From: Ajay Gupta <ajayg@nvidia.com>
> > > > 
> > > > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2
> > > > pins on the USB Type-C connector.
> > > > It uses the same messages as DisplayPort, but not the DP SVID. At the time of
> > > > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the
> > > > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID.
> > > > 
> > > > Since the SVID specific communication is exactly the same as with DisplayPort
> > > > alternate mode, there is no need to implement separate driver for VirtualLink.
> > > > We'll handle the current VirtualLink adapters with probe drivers, and once there
> > > > is SVID assigned for it, we add it to the displayport alt mode driver.
> > > > 
> > > > To support probing drivers, exporting the probe and remove functions, and also
> > > > changing the DP_HEADER helper macro to use the SVID of the alternate mode
> > > > device instead of the DisplayPort alt mode SVID.
> > > > 
> > > > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > ---
> > > >  drivers/usb/typec/altmodes/displayport.c | 12 +++++++-----
> > > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > Looks like you missed adding displayport.h file. It is available in original patch below,
> > >  https://marc.info/?l=linux-usb&m=155492587224379&w=2 
> > 
> > That's the one I picked, and I did compile the driver as well.. I'm
> > not sure what I've done, but I'll resend the series.
> 
> It looks like I broke the patch after I did a small modification to
> it. I had changed your "From" address so it matches your singed-of-by
> address. My compile test passed because the header was an untracked
> file :-)
> 
> Sorry again. Let's do one more test round, and resend.

Ok, dropping this whole series from my queue now, thanks.

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Ajay Gupta <ajayg@nvidia.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove functions
Date: Tue, 16 Apr 2019 12:03:11 +0200	[thread overview]
Message-ID: <20190416100311.GF896@kroah.com> (raw)
Message-ID: <20190416100311.0sgK4ztF3aWSUSWtpS4TOvvPCVt9DUPOAUZC8__CUIY@z> (raw)
In-Reply-To: <20190416074607.GC1747@kuha.fi.intel.com>

On Tue, Apr 16, 2019 at 10:46:07AM +0300, Heikki Krogerus wrote:
> On Tue, Apr 16, 2019 at 09:27:03AM +0300, Heikki Krogerus wrote:
> > On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote:
> > > Hi Heikki,
> > > 
> > > > -----Original Message-----
> > > > From: linux-usb-owner@vger.kernel.org <linux-usb-owner@vger.kernel.org> On
> > > > Behalf Of Heikki Krogerus
> > > > Sent: Monday, April 15, 2019 5:10 AM
> > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Ajay Gupta <ajayg@nvidia.com>; linux-usb@vger.kernel.org
> > > > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove
> > > > functions
> > > > 
> > > > From: Ajay Gupta <ajayg@nvidia.com>
> > > > 
> > > > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the USB 2
> > > > pins on the USB Type-C connector.
> > > > It uses the same messages as DisplayPort, but not the DP SVID. At the time of
> > > > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the
> > > > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID.
> > > > 
> > > > Since the SVID specific communication is exactly the same as with DisplayPort
> > > > alternate mode, there is no need to implement separate driver for VirtualLink.
> > > > We'll handle the current VirtualLink adapters with probe drivers, and once there
> > > > is SVID assigned for it, we add it to the displayport alt mode driver.
> > > > 
> > > > To support probing drivers, exporting the probe and remove functions, and also
> > > > changing the DP_HEADER helper macro to use the SVID of the alternate mode
> > > > device instead of the DisplayPort alt mode SVID.
> > > > 
> > > > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > ---
> > > >  drivers/usb/typec/altmodes/displayport.c | 12 +++++++-----
> > > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > Looks like you missed adding displayport.h file. It is available in original patch below,
> > >  https://marc.info/?l=linux-usb&m=155492587224379&w=2 
> > 
> > That's the one I picked, and I did compile the driver as well.. I'm
> > not sure what I've done, but I'll resend the series.
> 
> It looks like I broke the patch after I did a small modification to
> it. I had changed your "From" address so it matches your singed-of-by
> address. My compile test passed because the header was an untracked
> file :-)
> 
> Sorry again. Let's do one more test round, and resend.

Ok, dropping this whole series from my queue now, thanks.

greg k-h

         reply	other threads:[~2019-04-16 10:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 12:09 [PATCH v2 0/7] usb: typec: Remaining changes for v5.2 Heikki Krogerus
2019-04-15 12:09 ` [v2,1/7] i2c: nvidia-gpu: Supply CCGx driver the fw build info Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 1/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,2/7] usb: typec: ucsi: ccg: add get_fw_info function Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 2/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,3/7] usb: typec: ucsi: ccg: add firmware flashing support Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 3/7] " Heikki Krogerus
2019-04-16 10:00   ` [v2,3/7] " Greg Kroah-Hartman
2019-04-16 10:00     ` [PATCH v2 3/7] " Greg Kroah-Hartman
2019-04-15 12:09 ` [v2,4/7] usb: typec: ucsi: Preliminary support for alternate modes Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 4/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,5/7] usb: typec: ucsi: Support for DisplayPort alt mode Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 5/7] " Heikki Krogerus
2019-04-15 12:09 ` [v2,6/7] usb: typec: displayport: Export probe and remove functions Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16  0:45   ` [v2,6/7] " Ajay Gupta
2019-04-16  0:45     ` [PATCH v2 6/7] " Ajay Gupta
2019-04-16  6:27     ` [v2,6/7] " Heikki Krogerus
2019-04-16  6:27       ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16  7:46       ` [v2,6/7] " Heikki Krogerus
2019-04-16  7:46         ` [PATCH v2 6/7] " Heikki Krogerus
2019-04-16 10:03         ` Greg Kroah-Hartman [this message]
2019-04-16 10:03           ` Greg Kroah-Hartman
2019-04-15 12:09 ` [v2,7/7] usb: typec: Add driver for NVIDIA Alt Modes Heikki Krogerus
2019-04-15 12:09   ` [PATCH v2 7/7] " Heikki Krogerus
2019-04-15 21:12   ` kbuild test robot
2019-04-16 10:02   ` [v2,7/7] " Greg Kroah-Hartman
2019-04-16 10:02     ` [PATCH v2 7/7] " Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416100311.GF896@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ajayg@nvidia.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).