linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	Ajay Gupta <ajayg@nvidia.com>
Subject: [v8,3/3] usb: typec: ucsi: ccg: add firmware flashing support
Date: Wed, 17 Apr 2019 08:33:07 +0200	[thread overview]
Message-ID: <20190417063307.GA24174@kroah.com> (raw)

On Tue, Apr 16, 2019 at 10:27:47AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
> 
> CCGx has two copies of the firmware in addition to the bootloader.
> If the device is running FW1, FW2 can be updated with the new version.
> Dual firmware mode allows the CCG device to stay in a PD contract and
> support USB PD and Type-C functionality while a firmware update is in
> progress.
> 
> First we read the currently flashed firmware version of both
> primary and secondary firmware and then compare it with
> version of firmware file to determine if flashing is required.
> 
> Command framework is added to support sending commands to CCGx
> controller. We wait for response after sending the command and then
> read the response from RAB_RESPONSE register.
> 
> Below commands are supported,
> 	- ENTER_FLASHING
> 	- RESET
> 	- PDPORT_ENABLE
> 	- JUMP_TO_BOOT
> 	- FLASH_ROW_RW
> 	- VALIDATE_FW
> 
> Command specific mutex lock is also added to sync between driver
> and user threads.
> 
> PD port number information is added which is required while sending
> PD_PORT_ENABLE command
> 
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes from v7->v8
> 	- Fixed comments from Greg by dropping do_flash_show()

You still have a new sysfs file without a new Documentation/ABI/ update
for it, so I will have to reject this patch again :(

I thought I said that in the last review...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH v8 3/3] usb: typec: ucsi: ccg: add firmware flashing support
Date: Wed, 17 Apr 2019 08:33:07 +0200	[thread overview]
Message-ID: <20190417063307.GA24174@kroah.com> (raw)
Message-ID: <20190417063307.5uM9i7xS9_siM_BwjwdhR19mDDr3-tSAvS49bWBoUpc@z> (raw)
In-Reply-To: <20190416172747.22139-4-ajayg@nvidia.com>

On Tue, Apr 16, 2019 at 10:27:47AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
> 
> CCGx has two copies of the firmware in addition to the bootloader.
> If the device is running FW1, FW2 can be updated with the new version.
> Dual firmware mode allows the CCG device to stay in a PD contract and
> support USB PD and Type-C functionality while a firmware update is in
> progress.
> 
> First we read the currently flashed firmware version of both
> primary and secondary firmware and then compare it with
> version of firmware file to determine if flashing is required.
> 
> Command framework is added to support sending commands to CCGx
> controller. We wait for response after sending the command and then
> read the response from RAB_RESPONSE register.
> 
> Below commands are supported,
> 	- ENTER_FLASHING
> 	- RESET
> 	- PDPORT_ENABLE
> 	- JUMP_TO_BOOT
> 	- FLASH_ROW_RW
> 	- VALIDATE_FW
> 
> Command specific mutex lock is also added to sync between driver
> and user threads.
> 
> PD port number information is added which is required while sending
> PD_PORT_ENABLE command
> 
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes from v7->v8
> 	- Fixed comments from Greg by dropping do_flash_show()

You still have a new sysfs file without a new Documentation/ABI/ update
for it, so I will have to reject this patch again :(

I thought I said that in the last review...

thanks,

greg k-h

         reply	other threads:[~2019-04-17  6:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 17:27 [PATCH v8 0/3] Add support for firmware update on Cypres CCGx Ajay Gupta
2019-04-16 17:27 ` [v8,1/3] usb: typec: ucsi: ccg: add get_fw_info function Ajay Gupta
2019-04-16 17:27   ` [PATCH v8 1/3] " Ajay Gupta
2019-04-16 17:27 ` [v8,2/3] i2c: nvidia-gpu: Supply CCGx driver the fw build info Ajay Gupta
2019-04-16 17:27   ` [PATCH v8 2/3] " Ajay Gupta
2019-04-16 17:27 ` [v8,3/3] usb: typec: ucsi: ccg: add firmware flashing support Ajay Gupta
2019-04-16 17:27   ` [PATCH v8 3/3] " Ajay Gupta
2019-04-17  6:33   ` Greg Kroah-Hartman [this message]
2019-04-17  6:33     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417063307.GA24174@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ajayg@nvidia.com \
    --cc=ajaykuee@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).