From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] usb/hcd: Send a uevent signaling that the host controller had died From: Raul E Rangel Message-Id: <20190417224129.GA255388@google.com> Date: Wed, 17 Apr 2019 16:41:29 -0600 To: Guenter Roeck Cc: Alan Stern , linux-usb@vger.kernel.org, Guenter Roeck , Oliver Neukum , Daniel Kurtz , zwisler@chromium.org, Sebastian Andrzej Siewior , Martin Blumenstingl , Dmitry Torokhov , linux-kernel , "Gustavo A. R. Silva" , Miquel Raynal , Johan Hovold , Greg Kroah-Hartman , Mathias Nyman , Raul Rangel List-ID: T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMDM6MjM6NTJQTSAtMDcwMCwgR3VlbnRlciBSb2VjayB3 cm90ZToKPiBPbiBXZWQsIEFwciAxNywgMjAxOSBhdCAzOjExIFBNIFJhdWwgUmFuZ2VsIDxycmFu Z2VsQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gV2VkLCBBcHIgMTcsIDIwMTkgYXQg MDQ6Mzk6MjNQTSAtMDQwMCwgQWxhbiBTdGVybiB3cm90ZToKPiA+ID4KPiA+ID4gVGhpcyBzb3Vu ZHMgbGlrZSBhIGdvbGRlbiBvcHBvcnR1bml0eSEgIFN1Ym1pdCBhIHNlcGFyYXRlIHBhdGNoIG1h a2luZwo+ID4gPiB0aGUgcGFyYW1ldGVyIHRvIGtvYmplY3RfdWV2ZW50X2VudiBiZSBjb25zdCAo YWN0dWFsbHkgY29uc3QgY2hhciAqCj4gPiA+IGNvbnN0IFtdKSwgdGhlbiBzdWJtaXQgdGhpcyBw YXRjaCBvbiB0b3Agb2YgdGhhdCBvbmUuCj4gPiBTbyB0aGVyZSBhcmUgb3RoZXIgcGFydHMgb2Yg dGhlIGNvZGUgYmFzZSB0aGF0IGR5bmFtaWNhbGx5IGNyZWF0ZSB0aGVpcgo+ID4gYXJyYXkgdmFs dWVzLiBTbyBieSBtYWtpbmcgdGhlIGZ1bmN0aW9uIHRha2UgY29uc3QsIGl0IGJyZWFrcyA6KAo+ IAo+IENvbmZ1c2VkLiBUaGUgY2FsbGluZyBjb2RlIGNhbiBzdGlsbCBiZSBub24tY29uc3QuIEkg ZG9uJ3Qgc2VlIHRoZQo+IHBhcmFtZXRlciBtb2RpZmllZCBpbiBrb2JqZWN0X3VldmVudF9lbnYo KSwgc28gZGVjbGFyaW5nIGl0IGNvbnN0Cj4gc2hvdWxkIGJlIHBvc3NpYmxlLiBDYW4geW91IGdp dmUgYW4gZXhhbXBsZSBvZiBjb2RlIHRoYXQgbm8gbG9uZ2VyCj4gd29ya3MgPwpzdGF0aWMgaW50 IG5vdGlmeV91c2VyX3NwYWNlKHN0cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNlICp0eiwgaW50IHRy aXApCnsKCWNoYXIgKnRoZXJtYWxfcHJvcFs1XTsKCWludCBpOwoKCW11dGV4X2xvY2soJnR6LT5s b2NrKTsKCXRoZXJtYWxfcHJvcFswXSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAiTkFNRT0lcyIs IHR6LT50eXBlKTsKCXRoZXJtYWxfcHJvcFsxXSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAiVEVN UD0lZCIsIHR6LT50ZW1wZXJhdHVyZSk7Cgl0aGVybWFsX3Byb3BbMl0gPSBrYXNwcmludGYoR0ZQ X0tFUk5FTCwgIlRSSVA9JWQiLCB0cmlwKTsKCXRoZXJtYWxfcHJvcFszXSA9IGthc3ByaW50ZihH RlBfS0VSTkVMLCAiRVZFTlQ9JWQiLCB0ei0+bm90aWZ5X2V2ZW50KTsKCXRoZXJtYWxfcHJvcFs0 XSA9IE5VTEw7Cglrb2JqZWN0X3VldmVudF9lbnYoJnR6LT5kZXZpY2Uua29iaiwgS09CSl9DSEFO R0UsIHRoZXJtYWxfcHJvcCk7Cglmb3IgKGkgPSAwOyBpIDwgNDsgKytpKQoJCWtmcmVlKHRoZXJt YWxfcHJvcFtpXSk7CgltdXRleF91bmxvY2soJnR6LT5sb2NrKTsKCXJldHVybiAwOwp9Cgpkcml2 ZXJzL3RoZXJtYWwvdXNlcl9zcGFjZS5jOjQ4OjUyOiBlcnJvcjogcGFzc2luZyAnY2hhciAqWzVd JyB0byBwYXJhbWV0ZXIgb2YgdHlwZSAnY29uc3QgY2hhciAqY29uc3QgKicgZGlzY2FyZHMgcXVh bGlmaWVycyBpbiBuZXN0ZWQgcG9pbnRlciB0eXBlcyBbLVdlcnJvciwtV2luY29tcGF0aWJsZS1w b2ludGVyLXR5cGVzLWRpc2NhcmRzLXF1YWxpZmllcnNdCiAgICAgICAga29iamVjdF91ZXZlbnRf ZW52KCZ0ei0+ZGV2aWNlLmtvYmosIEtPQkpfQ0hBTkdFLCB0aGVybWFsX3Byb3ApOwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+ fn5+fn5+CmluY2x1ZGUvbGludXgva29iamVjdC5oOjIzODoyMjogbm90ZTogcGFzc2luZyBhcmd1 bWVudCB0byBwYXJhbWV0ZXIgJ2VudnAnIGhlcmUKICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgY2hhciAqY29uc3QgZW52cFtdKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXgoKaHR0cDovL2MtZmFxLmNvbS9hbnNpL2NvbnN0bWlzbWF0Y2guaHRtbCBleHBs YWlucyB3aHkgaXQgZmFpbHMuCgpSYXVsCgo+IAo+IFRoYW5rcywKPiBHdWVudGVyCj4gCj4gPiA+ Cj4gPiA+IEFsYW4gU3Rlcm4KPiA+ID4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BBB4C282DC for ; Wed, 17 Apr 2019 22:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5F82217FA for ; Wed, 17 Apr 2019 22:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387695AbfDQWlg (ORCPT ); Wed, 17 Apr 2019 18:41:36 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:51370 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387692AbfDQWlg (ORCPT ); Wed, 17 Apr 2019 18:41:36 -0400 Received: by mail-it1-f195.google.com with SMTP id s3so410373itk.1 for ; Wed, 17 Apr 2019 15:41:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tAY3tqZpNl1puGrkgrVxxOuIRHZ6LBNHbIdJbLHFZr0=; b=Vyi95qlw5HOhGTCo5L69hZ3v/tN7GOEmrBWdYyJ2feX+HANL53DazkVBEk3u6zEdHf s0N7KlcqzE+QxDt0kcrFnfMRSGroBcVjGGvScilcBDJ0X68LDcCvLfZsVvx4D19ZEreo YsEB4zrbkUcJ7Ray/loikxLcOEverNyZZy69whSwkXm5EyHYmB9+XnPXlid0Zjfa85Ep vU9Euvn+tPxA6R2GzgAIE2ZoONdvr5EtMgQXqX3tNCoxcd25ytXK9wOqBwYW6+YnJ1i/ w61xJ0Mt52p4WNaMrQ0UykJ5qUmNOuedKT/WFxPTzZU/BvACKKYgoCQZpM1qTDATEOJ6 eN0A== X-Gm-Message-State: APjAAAU9WKxOwKfLnICqV3vkBXW8abMTGvQiBIzFZ4O6JxCbszBO4bq6 23ax0wbBVeK041Mm7Bi9dSj52w== X-Google-Smtp-Source: APXvYqwi7ZqoAmXMXDAm93P7ERl8NcVH2RuxzvRAA67ZR245zA+jaTDcpK6GTOSCkuHeMW4+t3h43Q== X-Received: by 2002:a02:c510:: with SMTP id s16mr432119jam.51.1555540895170; Wed, 17 Apr 2019 15:41:35 -0700 (PDT) Received: from google.com ([2620:15c:183:0:20b8:dee7:5447:d05]) by smtp.gmail.com with ESMTPSA id p1sm180143itp.19.2019.04.17.15.41.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 15:41:33 -0700 (PDT) Date: Wed, 17 Apr 2019 16:41:29 -0600 From: Raul Rangel To: Guenter Roeck Cc: Alan Stern , linux-usb@vger.kernel.org, Guenter Roeck , Oliver Neukum , Daniel Kurtz , zwisler@chromium.org, Sebastian Andrzej Siewior , Martin Blumenstingl , Dmitry Torokhov , linux-kernel , "Gustavo A. R. Silva" , Miquel Raynal , Johan Hovold , Greg Kroah-Hartman , Mathias Nyman , Raul Rangel Subject: Re: [PATCH v3] usb/hcd: Send a uevent signaling that the host controller had died Message-ID: <20190417224129.GA255388@google.com> References: <20190417202017.GA204974@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190417224129.3K4GBQFoT3-BPYV7Bvs87bPswdYtKy_WPbFoxi0sZwo@z> On Wed, Apr 17, 2019 at 03:23:52PM -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2019 at 3:11 PM Raul Rangel wrote: > > > > On Wed, Apr 17, 2019 at 04:39:23PM -0400, Alan Stern wrote: > > > > > > This sounds like a golden opportunity! Submit a separate patch making > > > the parameter to kobject_uevent_env be const (actually const char * > > > const []), then submit this patch on top of that one. > > So there are other parts of the code base that dynamically create their > > array values. So by making the function take const, it breaks :( > > Confused. The calling code can still be non-const. I don't see the > parameter modified in kobject_uevent_env(), so declaring it const > should be possible. Can you give an example of code that no longer > works ? static int notify_user_space(struct thermal_zone_device *tz, int trip) { char *thermal_prop[5]; int i; mutex_lock(&tz->lock); thermal_prop[0] = kasprintf(GFP_KERNEL, "NAME=%s", tz->type); thermal_prop[1] = kasprintf(GFP_KERNEL, "TEMP=%d", tz->temperature); thermal_prop[2] = kasprintf(GFP_KERNEL, "TRIP=%d", trip); thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", tz->notify_event); thermal_prop[4] = NULL; kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, thermal_prop); for (i = 0; i < 4; ++i) kfree(thermal_prop[i]); mutex_unlock(&tz->lock); return 0; } drivers/thermal/user_space.c:48:52: error: passing 'char *[5]' to parameter of type 'const char *const *' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers] kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, thermal_prop); ^~~~~~~~~~~~ include/linux/kobject.h:238:22: note: passing argument to parameter 'envp' here const char *const envp[]); ^ http://c-faq.com/ansi/constmismatch.html explains why it fails. Raul > > Thanks, > Guenter > > > > > > > Alan Stern > > >