From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] usb/hcd: Send a uevent signaling that the host controller had died From: Greg Kroah-Hartman Message-Id: <20190418143048.GA11555@kroah.com> Date: Thu, 18 Apr 2019 16:30:48 +0200 To: Alan Stern Cc: Guenter Roeck , Raul Rangel , linux-usb@vger.kernel.org, Guenter Roeck , Oliver Neukum , Daniel Kurtz , zwisler@chromium.org, Sebastian Andrzej Siewior , Martin Blumenstingl , Dmitry Torokhov , linux-kernel , "Gustavo A. R. Silva" , Miquel Raynal , Johan Hovold , Mathias Nyman List-ID: T24gVGh1LCBBcHIgMTgsIDIwMTkgYXQgMTA6MjE6MzJBTSAtMDQwMCwgQWxhbiBTdGVybiB3cm90 ZToKPiBPbiBUaHUsIDE4IEFwciAyMDE5LCBHcmVnIEtyb2FoLUhhcnRtYW4gd3JvdGU6Cj4gCj4g PiBPbiBXZWQsIEFwciAxNywgMjAxOSBhdCAwNDoyMDowOVBNIC0wNzAwLCBHdWVudGVyIFJvZWNr IHdyb3RlOgo+ID4gPiBPbiBXZWQsIEFwciAxNywgMjAxOSBhdCAzOjQxIFBNIFJhdWwgUmFuZ2Vs IDxycmFuZ2VsQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBXZWQsIEFw ciAxNywgMjAxOSBhdCAwMzoyMzo1MlBNIC0wNzAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+ID4g PiA+ID4gT24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMzoxMSBQTSBSYXVsIFJhbmdlbCA8cnJhbmdl bEBjaHJvbWl1bS5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBPbiBXZWQsIEFw ciAxNywgMjAxOSBhdCAwNDozOToyM1BNIC0wNDAwLCBBbGFuIFN0ZXJuIHdyb3RlOgo+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gVGhpcyBzb3VuZHMgbGlrZSBhIGdvbGRlbiBvcHBvcnR1bml0 eSEgIFN1Ym1pdCBhIHNlcGFyYXRlIHBhdGNoIG1ha2luZwo+ID4gPiA+ID4gPiA+IHRoZSBwYXJh bWV0ZXIgdG8ga29iamVjdF91ZXZlbnRfZW52IGJlIGNvbnN0IChhY3R1YWxseSBjb25zdCBjaGFy ICoKPiA+ID4gPiA+ID4gPiBjb25zdCBbXSksIHRoZW4gc3VibWl0IHRoaXMgcGF0Y2ggb24gdG9w IG9mIHRoYXQgb25lLgo+ID4gPiA+ID4gPiBTbyB0aGVyZSBhcmUgb3RoZXIgcGFydHMgb2YgdGhl IGNvZGUgYmFzZSB0aGF0IGR5bmFtaWNhbGx5IGNyZWF0ZSB0aGVpcgo+ID4gPiA+ID4gPiBhcnJh eSB2YWx1ZXMuIFNvIGJ5IG1ha2luZyB0aGUgZnVuY3Rpb24gdGFrZSBjb25zdCwgaXQgYnJlYWtz IDooCj4gPiA+ID4gPgo+ID4gPiA+ID4gQ29uZnVzZWQuIFRoZSBjYWxsaW5nIGNvZGUgY2FuIHN0 aWxsIGJlIG5vbi1jb25zdC4gSSBkb24ndCBzZWUgdGhlCj4gPiA+ID4gPiBwYXJhbWV0ZXIgbW9k aWZpZWQgaW4ga29iamVjdF91ZXZlbnRfZW52KCksIHNvIGRlY2xhcmluZyBpdCBjb25zdAo+ID4g PiA+ID4gc2hvdWxkIGJlIHBvc3NpYmxlLiBDYW4geW91IGdpdmUgYW4gZXhhbXBsZSBvZiBjb2Rl IHRoYXQgbm8gbG9uZ2VyCj4gPiA+ID4gPiB3b3JrcyA/Cj4gPiA+ID4gc3RhdGljIGludCBub3Rp ZnlfdXNlcl9zcGFjZShzdHJ1Y3QgdGhlcm1hbF96b25lX2RldmljZSAqdHosIGludCB0cmlwKQo+ ID4gPiA+IHsKPiA+ID4gPiAgICAgICAgIGNoYXIgKnRoZXJtYWxfcHJvcFs1XTsKPiA+ID4gPiAg ICAgICAgIGludCBpOwo+ID4gPiA+Cj4gPiA+ID4gICAgICAgICBtdXRleF9sb2NrKCZ0ei0+bG9j ayk7Cj4gPiA+ID4gICAgICAgICB0aGVybWFsX3Byb3BbMF0gPSBrYXNwcmludGYoR0ZQX0tFUk5F TCwgIk5BTUU9JXMiLCB0ei0+dHlwZSk7Cj4gPiA+ID4gICAgICAgICB0aGVybWFsX3Byb3BbMV0g PSBrYXNwcmludGYoR0ZQX0tFUk5FTCwgIlRFTVA9JWQiLCB0ei0+dGVtcGVyYXR1cmUpOwo+ID4g PiA+ICAgICAgICAgdGhlcm1hbF9wcm9wWzJdID0ga2FzcHJpbnRmKEdGUF9LRVJORUwsICJUUklQ PSVkIiwgdHJpcCk7Cj4gPiA+ID4gICAgICAgICB0aGVybWFsX3Byb3BbM10gPSBrYXNwcmludGYo R0ZQX0tFUk5FTCwgIkVWRU5UPSVkIiwgdHotPm5vdGlmeV9ldmVudCk7Cj4gPiA+ID4gICAgICAg ICB0aGVybWFsX3Byb3BbNF0gPSBOVUxMOwo+ID4gPiA+ICAgICAgICAga29iamVjdF91ZXZlbnRf ZW52KCZ0ei0+ZGV2aWNlLmtvYmosIEtPQkpfQ0hBTkdFLCB0aGVybWFsX3Byb3ApOwo+ID4gPiA+ ICAgICAgICAgZm9yIChpID0gMDsgaSA8IDQ7ICsraSkKPiA+ID4gPiAgICAgICAgICAgICAgICAg a2ZyZWUodGhlcm1hbF9wcm9wW2ldKTsKPiA+ID4gPiAgICAgICAgIG11dGV4X3VubG9jaygmdHot PmxvY2spOwo+ID4gPiA+ICAgICAgICAgcmV0dXJuIDA7Cj4gPiA+ID4gfQo+ID4gPiA+Cj4gPiA+ ID4gZHJpdmVycy90aGVybWFsL3VzZXJfc3BhY2UuYzo0ODo1MjogZXJyb3I6IHBhc3NpbmcgJ2No YXIgKls1XScgdG8gcGFyYW1ldGVyIG9mIHR5cGUgJ2NvbnN0IGNoYXIgKmNvbnN0IConIGRpc2Nh cmRzIHF1YWxpZmllcnMgaW4gbmVzdGVkIHBvaW50ZXIgdHlwZXMgWy1XZXJyb3IsLVdpbmNvbXBh dGlibGUtcG9pbnRlci10eXBlcy1kaXNjYXJkcy1xdWFsaWZpZXJzXQo+ID4gPiA+ICAgICAgICAg a29iamVjdF91ZXZlbnRfZW52KCZ0ei0+ZGV2aWNlLmtvYmosIEtPQkpfQ0hBTkdFLCB0aGVybWFs X3Byb3ApOwo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn4KPiA+ID4gPiBpbmNsdWRlL2xpbnV4L2tvYmpl Y3QuaDoyMzg6MjI6IG5vdGU6IHBhc3NpbmcgYXJndW1lbnQgdG8gcGFyYW1ldGVyICdlbnZwJyBo ZXJlCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqY29uc3QgZW52 cFtdKTsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBe Cj4gPiA+ID4KPiA+ID4gPiBodHRwOi8vYy1mYXEuY29tL2Fuc2kvY29uc3RtaXNtYXRjaC5odG1s IGV4cGxhaW5zIHdoeSBpdCBmYWlscy4KPiA+ID4gPgo+ID4gPiBJbnRlcmVzdGluZy4gT25lIG5l dmVyIHN0b3BzIGxlYXJuaW5nLiBTbyB0aGUgYmVzdCB5b3UgY291bGQgZG8gd291bGQKPiA+ID4g YmUgY2hhciAqIGNvbnN0IGVudnBbXSwgYnV0IEkgZ3Vlc3MgdGhhdCBkb2Vzbid0IGhlbHAgbXVj aC4KPiA+IAo+ID4gWWVhaCwgSSB3ZW50IGRvd24gdGhpcyBwYXRoIGEgeWVhciBvciBzbyBhZ28g YW5kIGhhZCB0byBnaXZlIGl0IHVwIGFzCj4gPiB3ZWxsIDooCj4gCj4gV2VsbCwgdGhlIHNpZ25h dHVyZSBjb3VsZCBzdGlsbCBiZSBjaGFuZ2VkIGFzIEd1ZW50ZXIgc3VnZ2VzdHMuCj4gCj4gQW5k IHRoZSBhcnJheSBiZWluZyBhZGRlZCBpbiB0aGUgbmV3IGNvZGUgY291bGQgc3RpbGwgYmUgc3Rh dGljLiAgCj4gQWZ0ZXIgYWxsLCB0aGVyZSBpc24ndCByZWFsbHkgYW55IGRhbmdlciB0aGF0IHRo ZSBjb250ZW50cyBvZiB0aG9zZQo+IHN0cmluZ3Mgd2lsbCBiZSBtb2RpZmllZCwgcmlnaHQ/ICBJ dCdzIGp1c3QgdGhhdCB0aGUgY29uc3QgbW9kaWZpZXJzCj4gd2VyZW4ndCBwdXQgaW4gdW50aWwg aXQgd2FzIHRvbyBsYXRlIGFuZCB0aGVyZSB3ZXJlIHRvbyBtYW55IGV4aXN0aW5nCj4gY2FsbGVy cy4gIFBlcmhhcHMgYSBjb21tZW50IGFib3V0IHRoaXMgY291bGQgYmUgaW5jbHVkZWQgaW4gdGhl IAo+IGtlcm5lbGRvYyBmb3Iga29iamVjdF91ZXZlbnRfZW52LgoKSSBhbSBhbGwgZm9yIGNoYW5n aW5nIHRoaXMsIGJ1dCBJIHJlbWVtYmVyIEkgdHJpZWQgdG8sIGFuZCBzb21laG93CmZhaWxlZCwg YnV0IEkgZG9uJ3QgcmVtZW1iZXIgdGhlIGZ1bGwgZGV0YWlscyBzb3JyeSwgaXQgd2FzIGEgd2hp bGUgYWdvLgpJZiBzb21lb25lIGZpZ3VyZXMgb3V0IGhvdyB0byBtYWtlIHRoaXMgYWxsIGNvbnN0 LCBJIHdpbGwgZ2xhZGx5IHRha2UKdGhhdCBwYXRjaC4KCnRoYW5rcywKCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C3CC10F0E for ; Thu, 18 Apr 2019 14:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FF99217FA for ; Thu, 18 Apr 2019 14:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555597860; bh=zNtfE5MZLzW55yElNMuX9dHAFRjpwpLv7UYLaSQyUSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yfzT3YRWkm6Fmjcu40F1MulISdZ9Z04Nk8wjIqnbsmrKokW/bdKmwxJCFaCbTRFY+ p1i209UEk+EHuoZvmfEceNf8wkKN5640ZmgUwjtPoDrh/RFcuftsg5Ppiy0cQo2vlK w5D+VPnIz6RSUjvY1Bk7mjxPs/UmiS9gQDcYyod0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388898AbfDROax (ORCPT ); Thu, 18 Apr 2019 10:30:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:32868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388375AbfDROax (ORCPT ); Thu, 18 Apr 2019 10:30:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1F7721479; Thu, 18 Apr 2019 14:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555597852; bh=zNtfE5MZLzW55yElNMuX9dHAFRjpwpLv7UYLaSQyUSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4Se5ABmcEzAUFxV+4pGnw6Ti31BJ1+FHvbyqmD4bfvHJG79TEhQbDEdfgcvB1Cii yx4+gALJoDULI6iodgf+snnFHd6C7BpJ7BIfDPbH319Fvr4sec5uTszhqdNXND53Ti rgRhEUxRW7AXK0eVVpfRxsaft/j0sZrM3Ra1B/68= Date: Thu, 18 Apr 2019 16:30:48 +0200 From: Greg Kroah-Hartman To: Alan Stern Cc: Guenter Roeck , Raul Rangel , linux-usb@vger.kernel.org, Guenter Roeck , Oliver Neukum , Daniel Kurtz , zwisler@chromium.org, Sebastian Andrzej Siewior , Martin Blumenstingl , Dmitry Torokhov , linux-kernel , "Gustavo A. R. Silva" , Miquel Raynal , Johan Hovold , Mathias Nyman Subject: Re: [PATCH v3] usb/hcd: Send a uevent signaling that the host controller had died Message-ID: <20190418143048.GA11555@kroah.com> References: <20190418065141.GB12503@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190418143048.oY2uAyaX8Qw-n2FI4AiHuLK0tIV-p2edBD2X9VqX1sM@z> On Thu, Apr 18, 2019 at 10:21:32AM -0400, Alan Stern wrote: > On Thu, 18 Apr 2019, Greg Kroah-Hartman wrote: > > > On Wed, Apr 17, 2019 at 04:20:09PM -0700, Guenter Roeck wrote: > > > On Wed, Apr 17, 2019 at 3:41 PM Raul Rangel wrote: > > > > > > > > On Wed, Apr 17, 2019 at 03:23:52PM -0700, Guenter Roeck wrote: > > > > > On Wed, Apr 17, 2019 at 3:11 PM Raul Rangel wrote: > > > > > > > > > > > > On Wed, Apr 17, 2019 at 04:39:23PM -0400, Alan Stern wrote: > > > > > > > > > > > > > > This sounds like a golden opportunity! Submit a separate patch making > > > > > > > the parameter to kobject_uevent_env be const (actually const char * > > > > > > > const []), then submit this patch on top of that one. > > > > > > So there are other parts of the code base that dynamically create their > > > > > > array values. So by making the function take const, it breaks :( > > > > > > > > > > Confused. The calling code can still be non-const. I don't see the > > > > > parameter modified in kobject_uevent_env(), so declaring it const > > > > > should be possible. Can you give an example of code that no longer > > > > > works ? > > > > static int notify_user_space(struct thermal_zone_device *tz, int trip) > > > > { > > > > char *thermal_prop[5]; > > > > int i; > > > > > > > > mutex_lock(&tz->lock); > > > > thermal_prop[0] = kasprintf(GFP_KERNEL, "NAME=%s", tz->type); > > > > thermal_prop[1] = kasprintf(GFP_KERNEL, "TEMP=%d", tz->temperature); > > > > thermal_prop[2] = kasprintf(GFP_KERNEL, "TRIP=%d", trip); > > > > thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", tz->notify_event); > > > > thermal_prop[4] = NULL; > > > > kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, thermal_prop); > > > > for (i = 0; i < 4; ++i) > > > > kfree(thermal_prop[i]); > > > > mutex_unlock(&tz->lock); > > > > return 0; > > > > } > > > > > > > > drivers/thermal/user_space.c:48:52: error: passing 'char *[5]' to parameter of type 'const char *const *' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > > > > kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, thermal_prop); > > > > ^~~~~~~~~~~~ > > > > include/linux/kobject.h:238:22: note: passing argument to parameter 'envp' here > > > > const char *const envp[]); > > > > ^ > > > > > > > > http://c-faq.com/ansi/constmismatch.html explains why it fails. > > > > > > > Interesting. One never stops learning. So the best you could do would > > > be char * const envp[], but I guess that doesn't help much. > > > > Yeah, I went down this path a year or so ago and had to give it up as > > well :( > > Well, the signature could still be changed as Guenter suggests. > > And the array being added in the new code could still be static. > After all, there isn't really any danger that the contents of those > strings will be modified, right? It's just that the const modifiers > weren't put in until it was too late and there were too many existing > callers. Perhaps a comment about this could be included in the > kerneldoc for kobject_uevent_env. I am all for changing this, but I remember I tried to, and somehow failed, but I don't remember the full details sorry, it was a while ago. If someone figures out how to make this all const, I will gladly take that patch. thanks, greg k-h