linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: crag0715@gmail.com
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hayeswang@realtek.com,
	mario_limonciello@dell.com, crag0715@gmail.com,
	"Crag.Wang" <crag.wang@dell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Simon Glass <sjg@chromium.org>, Sean Paul <seanpaul@chromium.org>,
	Grant Grundler <grundler@chromium.org>,
	David Chen <david.chen7@dell.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	zhong jiang <zhongjiang@huawei.com>,
	Charles Hyde <charles.hyde@dell.corp-partner.google.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [1/1] r8152: sync sa_family with the media type of network device
Date: Fri, 19 Apr 2019 16:45:46 +0800	[thread overview]
Message-ID: <20190419084547.26220-1-crag0715@gmail.com> (raw)

From: "Crag.Wang" <crag.wang@dell.com>

Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.

Change-Id: Ib48a303730bee81667a2859be32e48cc8a66f277
Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {

WARNING: multiple messages have this Message-ID (diff)
From: crag0715@gmail.com
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hayeswang@realtek.com,
	mario_limonciello@dell.com, crag0715@gmail.com,
	"Crag.Wang" <crag.wang@dell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Simon Glass <sjg@chromium.org>, Sean Paul <seanpaul@chromium.org>,
	Grant Grundler <grundler@chromium.org>,
	David Chen <david.chen7@dell.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	zhong jiang <zhongjiang@huawei.com>,
	Charles Hyde <charles.hyde@dell.corp-partner.google.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 1/1] r8152: sync sa_family with the media type of network device
Date: Fri, 19 Apr 2019 16:45:46 +0800	[thread overview]
Message-ID: <20190419084547.26220-1-crag0715@gmail.com> (raw)
Message-ID: <20190419084546.d7QgmfIxGlFOGl-ooGzeF2wXitQ8vMC7sgRmRqk8Psg@z> (raw)

From: "Crag.Wang" <crag.wang@dell.com>

Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.

Change-Id: Ib48a303730bee81667a2859be32e48cc8a66f277
Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {
-- 
2.20.1


             reply	other threads:[~2019-04-19  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  8:45 crag0715 [this message]
2019-04-19  8:45 ` [PATCH 1/1] r8152: sync sa_family with the media type of network device crag0715
2019-04-19 19:37 ` [1/1] " Greg Kroah-Hartman
2019-04-19 19:37   ` [PATCH 1/1] " Greg KH
2019-04-22  1:55   ` [1/1] " crag0715
2019-04-22  1:55     ` [PATCH 1/1] " Crag Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419084547.26220-1-crag0715@gmail.com \
    --to=crag0715@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=charles.hyde@dell.corp-partner.google.com \
    --cc=crag.wang@dell.com \
    --cc=davem@davemloft.net \
    --cc=david.chen7@dell.com \
    --cc=f.fainelli@gmail.com \
    --cc=grundler@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=seanpaul@chromium.org \
    --cc=sjg@chromium.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).