From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Subject: [9/9] USB: serial: spcp8x5: simplify init_termios
Date: Sun, 21 Apr 2019 14:21:54 +0200 [thread overview]
Message-ID: <20190421122154.26465-10-johan@kernel.org> (raw)
Simplify init_termios which is only used to override the initial
baudrate.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/spcp8x5.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index b42714855364..3bac55bd9bd9 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -281,10 +281,7 @@ static void spcp8x5_dtr_rts(struct usb_serial_port *port, int on)
static void spcp8x5_init_termios(struct tty_struct *tty)
{
- tty->termios = tty_std_termios;
- tty->termios.c_cflag = B115200 | CS8 | CREAD | HUPCL | CLOCAL;
- tty->termios.c_ispeed = 115200;
- tty->termios.c_ospeed = 115200;
+ tty_encode_baud_rate(tty, 115200, 115200);
}
static void spcp8x5_set_termios(struct tty_struct *tty,
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 9/9] USB: serial: spcp8x5: simplify init_termios
Date: Sun, 21 Apr 2019 14:21:54 +0200 [thread overview]
Message-ID: <20190421122154.26465-10-johan@kernel.org> (raw)
Message-ID: <20190421122154.fIAIMJhmZNU-QeBYsrMzjNO2BADmTUihpLk5Lv0mIDA@z> (raw)
In-Reply-To: <20190421122154.26465-1-johan@kernel.org>
Simplify init_termios which is only used to override the initial
baudrate.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/spcp8x5.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index b42714855364..3bac55bd9bd9 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -281,10 +281,7 @@ static void spcp8x5_dtr_rts(struct usb_serial_port *port, int on)
static void spcp8x5_init_termios(struct tty_struct *tty)
{
- tty->termios = tty_std_termios;
- tty->termios.c_cflag = B115200 | CS8 | CREAD | HUPCL | CLOCAL;
- tty->termios.c_ispeed = 115200;
- tty->termios.c_ospeed = 115200;
+ tty_encode_baud_rate(tty, 115200, 115200);
}
static void spcp8x5_set_termios(struct tty_struct *tty,
--
2.21.0
next prev reply other threads:[~2019-04-21 12:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 12:21 [PATCH 0/9] USB: serial: fix initial-termios handling Johan Hovold
2019-04-21 12:21 ` [1/9] " Johan Hovold
2019-04-21 12:21 ` [PATCH 1/9] " Johan Hovold
2019-04-21 12:21 ` [2/9] USB: serial: ark3116: drop redundant init_termios Johan Hovold
2019-04-21 12:21 ` [PATCH 2/9] " Johan Hovold
2019-04-21 12:21 ` [3/9] USB: serial: cypress_m8: drop unused driver data flag Johan Hovold
2019-04-21 12:21 ` [PATCH 3/9] " Johan Hovold
2019-04-21 12:21 ` [4/9] USB: serial: cypress_m8: drop unused termios Johan Hovold
2019-04-21 12:21 ` [PATCH 4/9] " Johan Hovold
2019-04-21 12:21 ` [5/9] USB: serial: cypress_m8: clean up initial-termios handling Johan Hovold
2019-04-21 12:21 ` [PATCH 5/9] " Johan Hovold
2019-04-21 12:21 ` [6/9] USB: serial: iuu_phoenix: drop bogus initial cflag Johan Hovold
2019-04-21 12:21 ` [PATCH 6/9] " Johan Hovold
2019-04-21 12:21 ` [7/9] USB: serial: iuu_phoenix: simplify init_termios Johan Hovold
2019-04-21 12:21 ` [PATCH 7/9] " Johan Hovold
2019-04-21 12:21 ` [8/9] USB: serial: oti6858: " Johan Hovold
2019-04-21 12:21 ` [PATCH 8/9] " Johan Hovold
2019-04-21 12:21 ` Johan Hovold [this message]
2019-04-21 12:21 ` [PATCH 9/9] USB: serial: spcp8x5: " Johan Hovold
2019-04-26 6:40 ` [PATCH 0/9] USB: serial: fix initial-termios handling Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190421122154.26465-10-johan@kernel.org \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).