From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/1] r8152: sync sa_family with the media type of network device From: Jakub Kicinski Message-Id: <20190422133947.0b6aaf82@cakuba.netronome.com> Date: Mon, 22 Apr 2019 13:39:47 -0700 To: crag0715@gmail.com Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hayeswang@realtek.com, mario_limonciello@dell.com, "Crag.Wang" , "David S. Miller" , Simon Glass , Grant Grundler , Sean Paul , David Chen , Kai-Heng Feng , "Gustavo A. R. Silva" , Charles Hyde , Sebastian Andrzej Siewior , zhong jiang List-ID: T24gTW9uLCAyMiBBcHIgMjAxOSAxMzowMzo0MyArMDgwMCwgY3JhZzA3MTVAZ21haWwuY29tIHdy b3RlOgo+IEZyb206ICJDcmFnLldhbmciIDxjcmFnLndhbmdAZGVsbC5jb20+Cj4gCj4gV2l0aG91 dCB0aGlzIHBhdGNoIHRoZSBzb2NrZXQgYWRkcmVzcyBmYW1pbHkgc3BvcmFkaWNhbGx5IGdldHMg d3JvbmcKPiB2YWx1ZSBlbmRzIHVwIHRoZSBkZXZfc2V0X21hY19hZGRyZXNzKCkgZmFpbHMgdG8g c2V0IHRoZSBkZXNpcmVkIE1BQwo+IGFkZHJlc3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ3JhZy5X YW5nIDxjcmFnLndhbmdAZGVsbC5jb20+CgpDb2RlIGxvb2tzIHJlYXNvbmFibGUuICBUaGlzIG11 c3QgaGF2ZSBiZWVuIGNhdXNlZCBieToKCkZpeGVzOiAyNTc2NjI3MWU0MmYgKCJyODE1MjogUmVm cmVzaCBNQUMgYWRkcmVzcyBkdXJpbmcgVVNCREVWRlNfUkVTRVQiKQoKd2hpY2ggaXMgc3RpbGwg aW4gbmV0LW5leHQuICBJbiB0aGUgZnV0dXJlIHBsZWFzZSBtYWtlIHN1cmUgeW91IHJlYWQ6Cgpo dHRwczovL3d3dy5rZXJuZWwub3JnL2RvYy9odG1sL2xhdGVzdC9uZXR3b3JraW5nL25ldGRldi1G QVEuaHRtbAoKSW4gcGFydGljdWxhcjoKCmh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwv bGF0ZXN0L25ldHdvcmtpbmcvbmV0ZGV2LUZBUS5odG1sI3EtaG93LWRvLWktaW5kaWNhdGUtd2hp Y2gtdHJlZS1uZXQtdnMtbmV0LW5leHQtbXktcGF0Y2gtc2hvdWxkLWJlLWluCgpUbyBhc3N1cmUg c21vb3RoIGZsb3cgb2YgeW91ciBwYXRjaGVzIGludG8gdGhlIHRyZWUgOikKClJldmlld2VkLWJ5 OiBKYWt1YiBLaWNpbnNraSA8amFrdWIua2ljaW5za2lAbmV0cm9ub21lLmNvbT4KCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L3VzYi9yODE1Mi5jIGIvZHJpdmVycy9uZXQvdXNiL3I4MTUyLmMK PiBpbmRleCA0YzYzYjQwZDVlMDAuLjQxZmIzOWNlNjljOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L25ldC91c2IvcjgxNTIuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3VzYi9yODE1Mi5jCj4gQEAgLTEy MjUsNiArMTIyNSw4IEBAIHN0YXRpYyBpbnQgZGV0ZXJtaW5lX2V0aGVybmV0X2FkZHIoc3RydWN0 IHI4MTUyICp0cCwgc3RydWN0IHNvY2thZGRyICpzYSkKPiAgCXN0cnVjdCBuZXRfZGV2aWNlICpk ZXYgPSB0cC0+bmV0ZGV2Owo+ICAJaW50IHJldDsKPiAgCj4gKwlzYS0+c2FfZmFtaWx5ID0gZGV2 LT50eXBlOwo+ICsKPiAgCWlmICh0cC0+dmVyc2lvbiA9PSBSVExfVkVSXzAxKSB7Cj4gIAkJcmV0 ID0gcGxhX29jcF9yZWFkKHRwLCBQTEFfSURSLCA4LCBzYS0+c2FfZGF0YSk7Cj4gIAl9IGVsc2Ug ewo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E28C10F11 for ; Mon, 22 Apr 2019 20:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACF7B20859 for ; Mon, 22 Apr 2019 20:40:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1VXDcldX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729742AbfDVUjy (ORCPT ); Mon, 22 Apr 2019 16:39:54 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:46468 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728823AbfDVUjx (ORCPT ); Mon, 22 Apr 2019 16:39:53 -0400 Received: by mail-qk1-f193.google.com with SMTP id w73so5082905qkb.13 for ; Mon, 22 Apr 2019 13:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=12fGXN1MFQ+YN+G4XSb4RzcfVfa/2mWdTJAL++9CrHM=; b=1VXDcldXfMsrHV8Pp0/Sk0toBAD+1gmbJC4HOzA+XvXapT92yh03vjSTDkaYZg9k5C WYSyk+IWPxwyecO4ddcZQr+TK4f4pG90GMSQVKo/5QNaUUk+rY9UnUZAHJ5Y/fHOACOf eDS0UmsjpIBdWwklgUIxbKQRRu4G8GD5eFwCSxBOJlOSPEOSZoO3Rkr9PdsdqPqQjb6N d3Y5BzmH0RNwZTEBcz//RUReSBXVfmzx9UyiNGXpWgugYI3g+JAs0UTVDh44jVVIbHnn NEWyHgCxELfQJdv7fqpKlux/uoRcnZbkHc4K+TUqZFwdNfAZldGJKz75M58t5E/F6I8b F7Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=12fGXN1MFQ+YN+G4XSb4RzcfVfa/2mWdTJAL++9CrHM=; b=OHs55zqf8zpPx0t94cZ4z7aGcfiPzKOj6UfEJC/nPOYY98HBhb5oxtP1JxUsC1uR4y NcRNXZ7nnBWC7T2iEF8XHEEdjCQFtUfctk2T7r7M02SR0uwmH0269z8LXuw1A9ThWoHC 0H8clnwPGHInxtnjiCUzi0NjrCN77Twyznuou8tpm8zK1Efq6aiLcUDYjtYN8alOtDtG mEwbwo5vVJMkLJQUuApSGQnGJWJbGogjnltiuw1s+5rJpIWUp2Yr0KBPMRJOrRBByZqb Pur3wgQkabzcm5mAEJWKajJPRG9eoO/mXtWgykb3A+tu2XcVWVeMKn+XI/9KUrozbkQ7 iM4A== X-Gm-Message-State: APjAAAVT4zuBtOwfi2vmUpXp+DC2YeNl0JM8SAMt0zwGJNWM6Kgsi8S/ QgiLkGjNNG20dvTgjHIhseWLLQ== X-Google-Smtp-Source: APXvYqzLnYo9jgh8YaoFBhDul8IRdTI5NaV7gRqh0pYzHDo9lvz5RB9w1HbMao/ZPjUJfucltdOxWw== X-Received: by 2002:a37:69c3:: with SMTP id e186mr16173321qkc.308.1555965592828; Mon, 22 Apr 2019 13:39:52 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id 13sm4529282qtm.52.2019.04.22.13.39.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 13:39:52 -0700 (PDT) Date: Mon, 22 Apr 2019 13:39:47 -0700 From: Jakub Kicinski To: crag0715@gmail.com Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hayeswang@realtek.com, mario_limonciello@dell.com, "Crag.Wang" , "David S. Miller" , Simon Glass , Grant Grundler , Sean Paul , David Chen , Kai-Heng Feng , "Gustavo A. R. Silva" , Charles Hyde , Sebastian Andrzej Siewior , zhong jiang Subject: Re: [PATCH v2 1/1] r8152: sync sa_family with the media type of network device Message-ID: <20190422133947.0b6aaf82@cakuba.netronome.com> In-Reply-To: <20190422050344.24513-1-crag0715@gmail.com> References: <20190422050344.24513-1-crag0715@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190422203947.e8XQN1SwO3XYlEE53VOwHTLbn2NYQq1UXHfYlrFimic@z> On Mon, 22 Apr 2019 13:03:43 +0800, crag0715@gmail.com wrote: > From: "Crag.Wang" > > Without this patch the socket address family sporadically gets wrong > value ends up the dev_set_mac_address() fails to set the desired MAC > address. > > Signed-off-by: Crag.Wang Code looks reasonable. This must have been caused by: Fixes: 25766271e42f ("r8152: Refresh MAC address during USBDEVFS_RESET") which is still in net-next. In the future please make sure you read: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html In particular: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in To assure smooth flow of your patches into the tree :) Reviewed-by: Jakub Kicinski > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 4c63b40d5e00..41fb39ce69c9 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa) > struct net_device *dev = tp->netdev; > int ret; > > + sa->sa_family = dev->type; > + > if (tp->version == RTL_VER_01) { > ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data); > } else {