* usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()
@ 2019-04-24 9:54 Dan Carpenter
2019-04-24 9:54 ` [PATCH] " Dan Carpenter
2019-04-25 23:09 ` Shuah Khan
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-04-24 9:54 UTC (permalink / raw)
To: Valentina Manea
Cc: Shuah Khan, Greg Kroah-Hartman, linux-usb, kernel-janitors
There is an extra space character before the return statement.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
index 97b09a42a10c..f3230bed18af 100644
--- a/drivers/usb/usbip/stub_rx.c
+++ b/drivers/usb/usbip/stub_rx.c
@@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
req = (struct usb_ctrlrequest *) urb->setup_packet;
- return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
- (req->bRequestType == USB_RECIP_ENDPOINT) &&
- (req->wValue == USB_ENDPOINT_HALT);
+ return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
+ (req->bRequestType == USB_RECIP_ENDPOINT) &&
+ (req->wValue == USB_ENDPOINT_HALT);
}
static int is_set_interface_cmd(struct urb *urb)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()
2019-04-24 9:54 usbip: stub_rx: tidy the indenting in is_clear_halt_cmd() Dan Carpenter
@ 2019-04-24 9:54 ` Dan Carpenter
2019-04-25 23:09 ` Shuah Khan
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-04-24 9:54 UTC (permalink / raw)
To: Valentina Manea
Cc: Shuah Khan, Greg Kroah-Hartman, linux-usb, kernel-janitors
There is an extra space character before the return statement.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
index 97b09a42a10c..f3230bed18af 100644
--- a/drivers/usb/usbip/stub_rx.c
+++ b/drivers/usb/usbip/stub_rx.c
@@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
req = (struct usb_ctrlrequest *) urb->setup_packet;
- return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
- (req->bRequestType == USB_RECIP_ENDPOINT) &&
- (req->wValue == USB_ENDPOINT_HALT);
+ return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
+ (req->bRequestType == USB_RECIP_ENDPOINT) &&
+ (req->wValue == USB_ENDPOINT_HALT);
}
static int is_set_interface_cmd(struct urb *urb)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()
@ 2019-04-25 23:09 ` Shuah Khan
2019-04-25 23:09 ` [PATCH] " shuah
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2019-04-25 23:09 UTC (permalink / raw)
To: Dan Carpenter, Valentina Manea
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, shuah
On 4/24/19 3:54 AM, Dan Carpenter wrote:
> There is an extra space character before the return statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 97b09a42a10c..f3230bed18af 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
>
> req = (struct usb_ctrlrequest *) urb->setup_packet;
>
> - return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
> - (req->bRequestType == USB_RECIP_ENDPOINT) &&
> - (req->wValue == USB_ENDPOINT_HALT);
> + return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
> + (req->bRequestType == USB_RECIP_ENDPOINT) &&
> + (req->wValue == USB_ENDPOINT_HALT);
> }
>
> static int is_set_interface_cmd(struct urb *urb)
>
Thanks for the patch.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()
2019-04-25 23:09 ` Shuah Khan
@ 2019-04-25 23:09 ` shuah
0 siblings, 0 replies; 4+ messages in thread
From: shuah @ 2019-04-25 23:09 UTC (permalink / raw)
To: Dan Carpenter, Valentina Manea
Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, shuah
On 4/24/19 3:54 AM, Dan Carpenter wrote:
> There is an extra space character before the return statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 97b09a42a10c..f3230bed18af 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
>
> req = (struct usb_ctrlrequest *) urb->setup_packet;
>
> - return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
> - (req->bRequestType == USB_RECIP_ENDPOINT) &&
> - (req->wValue == USB_ENDPOINT_HALT);
> + return (req->bRequest == USB_REQ_CLEAR_FEATURE) &&
> + (req->bRequestType == USB_RECIP_ENDPOINT) &&
> + (req->wValue == USB_ENDPOINT_HALT);
> }
>
> static int is_set_interface_cmd(struct urb *urb)
>
Thanks for the patch.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-25 23:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-24 9:54 usbip: stub_rx: tidy the indenting in is_clear_halt_cmd() Dan Carpenter
2019-04-24 9:54 ` [PATCH] " Dan Carpenter
2019-04-25 23:09 ` Shuah Khan
2019-04-25 23:09 ` [PATCH] " shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).