From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V2] usb: gadget: f_fs: don't free buffer prematurely From: Greg Kroah-Hartman Message-Id: <20190424165052.GF21916@kroah.com> Date: Wed, 24 Apr 2019 18:50:52 +0200 To: John Stultz Cc: "Yang, Fei" , Felipe Balbi , andrzej.p@collabora.com, Vincent Pelletier , Linux USB List , lkml , Josh Gao , Alistair Strachan , Shen Jing , Alan Stern List-ID: T24gVHVlLCBBcHIgMDIsIDIwMTkgYXQgMTA6MjY6NTFBTSArMDcwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMTE6MjEgQU0gSm9obiBTdHVsdHogPGpvaG4u c3R1bHR6QGxpbmFyby5vcmc+IHdyb3RlOgo+ID4gT24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgOTo0 MCBBTSBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+IE9u IFR1ZSwgTWFyIDE5LCAyMDE5IGF0IDEwOjMyIFBNIDxmZWkueWFuZ0BpbnRlbC5jb20+IHdyb3Rl Ogo+ID4gPiBFbHNld2hlcmUgaXQgc2VlbXMgdGhlIGZmcyBkcml2ZXIgdGFrZXMgZWZmb3J0IHRv IGRyb3AgYW55IGxvY2tzCj4gPiA+IGJlZm9yZSBjYWxsaW5nIHVzYl9lcF9kZXF1ZXVlKCksIHNv IHRoaXMgc2VlbXMgbGlrZSB0aGF0IHNob3VsZCBiZQo+ID4gPiBhZGRyZXNzZWQsIGJ1dCBpdCBh bHNvIHNlZW1zIGxpa2UgcmVjZW50IGNoYW5nZSB0byB0aGUgZHdjMyBkcml2ZXIgaGFzCj4gPiA+ IGJlZW4gbWFkZSB0byBhdm9pZCBzbGVlcGluZyBpbiB0aGF0IHBhdGggKHNlZSBmZWM5MDk1YmRl ZjQgKCJ1c2I6Cj4gPiA+IGR3YzM6IGdhZGdldDogcmVtb3ZlIHdhaXRfZW5kX3RyYW5zZmVyIikp LCB3aGljaCBtYXkgYmUgd2h5IEknbSBub3QKPiA+ID4gc2VlaW5nIHRoZSBwcm9ibGVtIHdpdGgg bWFpbmxpbmUgKGFuZCB5b3VyIHBhdGNoIGhlcmUsIG9mIGNvYXJzZSkuCj4gPiA+IEJ1dCB0aGF0 IGFsc28gZG9lc24ndCBjbGFyaWZ5IGlmIGl0cyBzdGlsbCBhIHBvdGVudGlhbCBpc3N1ZSB3Lwo+ ID4gPiBub24tZHdjMyBwbGF0Zm9ybXMuCj4gPgo+ID4gRmVsaXBlOiBHaXZlbiBBbGFuJ3MgcG9p bnQsIGRvZXMgaXQgbWFrZSBzZW5zZSB0byBtYXJrIHRoZSBjb21taXRzCj4gPiB0aGF0IHJlbW92 ZSB0aGUgcG9zc2libGUgc2xlZXAgZnJvbSB3YWl0X2V2ZW50X2xvY2tfaXJxKCkgaW4KPiA+IGR3 YzNfZ2FkZ2V0X2VwX2RlcXVldWUoKSAgZm9yIC1zdGFibGU/Cj4gPgo+ID4gQWdhaW5zdCA0LjE5 LjMwLCB0aGUgZm9sbG93aW5nIHNldCBtYW5hZ2VzIHRvIGNoZXJyeS1waWNrIGNsZWFubHk6Cj4g PiBnaXQgY2hlcnJ5LXBpY2sgMWEyMmVjNjQzNTgwNjI2ZjQzOWM4NTgzZWRhZmRjYzczNzk4ZjJm Ygo+ID4gZ2l0IGNoZXJyeS1waWNrIDA5ZmUxZjhkN2UyZjQ2MTI3NWIxY2RkODMyZjJjZmE1ZTli ZTM0NmQKPiA+IGdpdCBjaGVycnktcGljayBjM2FjZDU5MDE0MTQ4NDcwZGM1ODUxOTg3MGZiYzc3 OTc4NWI0YmY3Cj4gPiBnaXQgY2hlcnJ5LXBpY2sgNzc0NmE4ZGZiM2Y5YzkxYjNhMGI2M2ExZDVj MjY2NDQxMGU2NDk4ZAo+ID4gZ2l0IGNoZXJyeS1waWNrIGQ1NDQzYmJmNWZjOGY4Mzg5Y2NlMTQ2 YjFmYzI5ODdjZGQyMjlkMTIKPiA+IGdpdCBjaGVycnktcGljayBkNGYxYWZlNWU4OTZjMThhZTAx MDk5YTg1ZGFiNWUxYTE5OGJkMmE4Cj4gPiBnaXQgY2hlcnJ5LXBpY2sgZmVjOTA5NWJkZWY0ZTdj OTg4YWRiNjAzZDBkNGY5MmVlNzM1ZDRhMQo+ID4gIyBUbyBnZXQgdGhpbmdzIGJ1aWxkaW5nLCBy ZXZlcnQgbW9kaWZpZWQgLXN0YWJsZSBmaXgKPiA+IGdpdCByZXZlcnQgMjVhZDE3ZAo+ID4gI3Bp Y2sgYWN0dWFsIHVwc3RyZWFtIGZpeCByZXBsYWNpbmcgdGhlIHByZXZpb3VzCj4gPiBnaXQgY2hl cnJ5LXBpY2sgYmQ2NzQyMjQ5YjljYTkxODU2NWU0ZTNhYmFhMDY2NjVlNTg3ZjRiNQo+ID4KPiA+ IChUaG91Z2ggSSdtIGFsd2F5cyBhIGJpdCBoZXNpdGFudCB3aXRoIC1zdGFibGUgYmFja3BvcnRz IG9uIHN1YnN5c3RlbXMKPiA+IEkgZG9uJ3Qga25vdyB3ZWxsLiBTbyBJJ20gbm90IHN1cmUgaWYg dGhpcyBzZXQgaXMgZnVsbHkgY29ycmVjdC4pCj4gPgo+ID4gVGhpcyBzZXQgc2VlbXMgdG8gYXZv aWQgdGhlIGNyYXNoIG9uIHJlYm9vdCBJIHdhcyBzZWVpbmcuCj4gPgo+ID4gQW5kIG9mIGNvdXJz ZSwgSSdtIHN1cmUgZ2V0dGluZyB0aGF0IHNldCBiYWNrcG9ydGVkIHRvIDQuMTQgYW5kIDQuOQo+ ID4gKGFuZCBtYXliZSBldmVuIDQuNCwgSSBuZWVkIHRvIGNoZWNrKSB3aWxsIGJlIGxlc3MgY2xl YW4uCj4gCj4gQWxzbywgIEkganVzdCB3YW50ZWQgdG8gZm9sbG93IHVwIG9uIHRoaXMgYXMgd2Vs bC4gRG9lcyB0aGUgYWJvdmUgc2V0Cj4gb2YgY2hlcnJ5LXBpY2tzIGxvb2sgb2sgdG8gb3RoZXJz IGZvciA0LjE5LXN0YWJsZT8gIERvZXMgYW55b25lIGhhdmUKPiBzdWdnZXN0aW9ucyBvbiBob3cg dGhleSdkIGxpa2UgdG8gc2VlIGJhY2twb3J0cyB0byA0LjE0LCA0LjkgYW5kIDQuND8KCklmIHRo ZXkgYXJlIG9rLCBjYW4gc29tZW9uZSBzZW5kIG1lIHRoZSBjb21taXRzIGFzIGEgc2VyaWVzIG9m IHBhdGNoZXMsCmFzIGRvaW5nIHRoZSBhYm92ZSByZWFsbHkgZG9lc24ndCBoZWxwIG11Y2ggOikK CnRoYW5rcywKCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58563C10F11 for ; Wed, 24 Apr 2019 16:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26C3E206A3 for ; Wed, 24 Apr 2019 16:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556124669; bh=KHWGGy0jMAuVixt+Qml8P+H7UayHUqAzgqVvZJvRnpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CWToXgqabzEPn17m7UDwu9Jh09ZT9eLjQ8xuJVWt03cozMrtZ4YbDmOgnrtExoiAz zT8WuwFDcq6Xal4rzOW6bFbnwsr+dbevixurhEZ9kElVzx2Lt7Xwc+/HnvFcaeHOXH huDHVddeL95ehe6T6VghDX2MayfvTIcBmZAWdfqg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732863AbfDXQu7 (ORCPT ); Wed, 24 Apr 2019 12:50:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:56958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732242AbfDXQu4 (ORCPT ); Wed, 24 Apr 2019 12:50:56 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3C7C206A3; Wed, 24 Apr 2019 16:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556124655; bh=KHWGGy0jMAuVixt+Qml8P+H7UayHUqAzgqVvZJvRnpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fE0RcAy7jYUiopBT0sYH4VUqxy4DUVUCqo/yHL/CfjYODRbRmkE0SGnlv7Drse2pW Gr0OztmCg02ob2MQ2iV67Yp+MAa+ddSLbbxAWB4XRWqoz1DlkSLWS6H5Ml9xC+QnEN ung2og8p46XfAl7sGMc6qVXAkfV+6DLz8QvI+jbI= Date: Wed, 24 Apr 2019 18:50:52 +0200 From: Greg KH To: John Stultz Cc: "Yang, Fei" , Felipe Balbi , andrzej.p@collabora.com, Vincent Pelletier , Linux USB List , lkml , Josh Gao , Alistair Strachan , Shen Jing , Alan Stern Subject: Re: [PATCH V2] usb: gadget: f_fs: don't free buffer prematurely Message-ID: <20190424165052.GF21916@kroah.com> References: <1553059940-127038-1-git-send-email-fei.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190424165052.I0F5YPBKTqapK2YHGLCWt6bbo1NA1ueyIZmxhm9PeMM@z> On Tue, Apr 02, 2019 at 10:26:51AM +0700, John Stultz wrote: > On Wed, Mar 20, 2019 at 11:21 AM John Stultz wrote: > > On Wed, Mar 20, 2019 at 9:40 AM John Stultz wrote: > > > On Tue, Mar 19, 2019 at 10:32 PM wrote: > > > Elsewhere it seems the ffs driver takes effort to drop any locks > > > before calling usb_ep_dequeue(), so this seems like that should be > > > addressed, but it also seems like recent change to the dwc3 driver has > > > been made to avoid sleeping in that path (see fec9095bdef4 ("usb: > > > dwc3: gadget: remove wait_end_transfer")), which may be why I'm not > > > seeing the problem with mainline (and your patch here, of coarse). > > > But that also doesn't clarify if its still a potential issue w/ > > > non-dwc3 platforms. > > > > Felipe: Given Alan's point, does it make sense to mark the commits > > that remove the possible sleep from wait_event_lock_irq() in > > dwc3_gadget_ep_dequeue() for -stable? > > > > Against 4.19.30, the following set manages to cherry-pick cleanly: > > git cherry-pick 1a22ec643580626f439c8583edafdcc73798f2fb > > git cherry-pick 09fe1f8d7e2f461275b1cdd832f2cfa5e9be346d > > git cherry-pick c3acd59014148470dc58519870fbc779785b4bf7 > > git cherry-pick 7746a8dfb3f9c91b3a0b63a1d5c2664410e6498d > > git cherry-pick d5443bbf5fc8f8389cce146b1fc2987cdd229d12 > > git cherry-pick d4f1afe5e896c18ae01099a85dab5e1a198bd2a8 > > git cherry-pick fec9095bdef4e7c988adb603d0d4f92ee735d4a1 > > # To get things building, revert modified -stable fix > > git revert 25ad17d > > #pick actual upstream fix replacing the previous > > git cherry-pick bd6742249b9ca918565e4e3abaa06665e587f4b5 > > > > (Though I'm always a bit hesitant with -stable backports on subsystems > > I don't know well. So I'm not sure if this set is fully correct.) > > > > This set seems to avoid the crash on reboot I was seeing. > > > > And of course, I'm sure getting that set backported to 4.14 and 4.9 > > (and maybe even 4.4, I need to check) will be less clean. > > Also, I just wanted to follow up on this as well. Does the above set > of cherry-picks look ok to others for 4.19-stable? Does anyone have > suggestions on how they'd like to see backports to 4.14, 4.9 and 4.4? If they are ok, can someone send me the commits as a series of patches, as doing the above really doesn't help much :) thanks, greg k-h