From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,12/26] compat_ioctl: move more drivers to compat_ptr_ioctl From: Mauro Carvalho Chehab Message-Id: <20190425125301.5165cf15@coco.lan> Date: Thu, 25 Apr 2019 12:53:01 -0300 To: Al Viro Cc: Arnd Bergmann , linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Daniel Vetter , Greg Kroah-Hartman , David Sterba , Darren Hart , Jonathan Cameron , Bjorn Andersson , devel@driverdev.osuosl.org, qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Sean Young List-ID: RW0gVGh1LCAyNSBBcHIgMjAxOSAxNjozNTozNCArMDEwMApBbCBWaXJvIDx2aXJvQHplbml2Lmxp bnV4Lm9yZy51az4gZXNjcmV2ZXU6Cgo+IE9uIFRodSwgQXByIDI1LCAyMDE5IGF0IDEyOjIxOjUz UE0gLTAzMDAsIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZToKPiAKPiA+IElmIEkgdW5kZXJz dGFuZCB5b3VyIHBhdGNoIGRlc2NyaXB0aW9uIHdlbGwsIHVzaW5nIGNvbXBhdF9wdHJfaW9jdGwK PiA+IG9ubHkgd29ya3MgaWYgdGhlIGRyaXZlciBpcyBub3QgZm9yIHMzOTAsIHJpZ2h0PyAgCj4g Cj4gTm87IHMzOTAgaXMgd2hlcmUgIm9oLCBqdXN0IHNldCAtPmNvbXBhdF9pb2N0bCBzYW1lIGFz IC0+dW5sb2NrZWRfaW9jdGwKPiBhbmQgYmUgZG9uZSB3aXRoIHRoYXQ7IGNvbXBhdF9wdHIoKSBp cyBhIG5vLW9wIGFueXdheSIgYnJlYWtzLiAgSU9XLAo+IHMzOTAgaXMgdGhlIHJlYXNvbiBmb3Ig aGF2aW5nIGNvbXBhdF9wdHJfaW9jdGwoKSBpbiB0aGUgZmlyc3QgcGxhY2U7Cj4gdGhhdCB0aGlu ZyB3b3JrcyBvbiBhbGwgYmlhcmNoIGFyY2hpdGVjdHVyZXMsIGFzIGxvbmcgYXMgYWxsIHN0dWZm Cj4gaGFuZGxlZCBieSAtPmlvY3RsKCkgdGFrZXMgcG9pbnRlciB0byBhcmNoLWluZGVwZW5kZW50 IG9iamVjdCBhcwo+IGFyZ3VtZW50LiAgSU9XLAo+IAlhcmd1bWVudCBpZ25vcmVkID0+IE9LCj4g CWFueSBhcml0aG1ldGljYWwgdHlwZSA9PiBubyBnbywgY29tcGF0X3B0cigpIHdvdWxkIGJ1Z2dl ciBpdAo+IAlwb2ludGVyIHRvIGludCA9PiBPSwoKVGhhdCdzIHRoZSBjYXNlIGZvciBhbGwgTElS QyBpb2N0bHM6IHRoZXkgYWxsIHVzZSBhIHBvaW50ZXIgdG8gdTMyCmFyZ3VtZW50LgoKPiAJcG9p bnRlciB0byBzdHJpbmcgPT4gT0sKPiAJcG9pbnRlciB0byB1NjQgPT4gT0sKPiAJcG9pbnRlciB0 byBzdHJ1Y3Qge3U2NCBhZGRyOyBjaGFyIHNbMTFdO30gPT4gT0sKPiAJcG9pbnRlciB0byBsb25n ID0+IG5lZWRzIGV4cGxpY2l0IGhhbmRsZXIKPiAJcG9pbnRlciB0byBzdHJ1Y3Qge3ZvaWQgKmFk ZHI7IGNoYXIgc1sxMV07fSA9PiBuZWVkcyBleHBsaWNpdCBoYW5kbGVyCj4gCXBvaW50ZXIgdG8g c3RydWN0IHtpbnQgeDsgdTY0IHk7fSA9PiBuZWVkcyBleHBsaWNpdCBoYW5kbGVyIG9uIGFtZDY0 Cj4gRm9yICJqdXN0IHVzZSAtPnVubG9ja2VkX2lvY3RsIGZvciAtPmlvY3RsIiB3ZSBoYXZlCj4g CWFyZ3VtZW50IGlnbm9yZWQgPT4gT0sKPiAJYW55IGFyaXRobWV0aWNhbCB0eXBlID0+IE9LCj4g CWFueSBwb2ludGVyID0+IGluc3RhbnQgYnJlYWthZ2Ugb24gczM5MCwgaW4gYWRkdGlvbiB0byBj YXNlcyB0aGF0IGJyZWFrCj4gd2l0aCBjb21wYXRfcHRyX2lvY3RsKCkuCj4gCj4gUHJvYmFibHkg c29tZSBmb3JtIG9mIHRoYXQgb3VnaHQgdG8gZ28gaW50byBjb21taXQgbWVzc2FnZSBmb3IgY29t cGF0X3B0cl9pb2N0bCgpCj4gaW50cm9kdWN0aW9uLi4uCgpBZ3JlZWQuCgpUaGFua3MsCk1hdXJv Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC2EC4321A for ; Thu, 25 Apr 2019 15:53:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBA212067D for ; Thu, 25 Apr 2019 15:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556207610; bh=ho5TyauY3lJuFVAthLKFJ6Y7hIL31mARg19a8JCHiUk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=cQ6UJLVjf8bwqt+DuI+Sd7VUg5/D+WIIGaOAnOAURDFJslYTL491A+sOsVoqsZbVa n/XJpVU895MBe94002AgbOrNv63rZ/yG4cdREytGLttZ6g58QeDGqr/xh10zOkHc8W PvzSQMutLvMws72+CQFklYCyL+lcBAQxhsUJytu4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728972AbfDYPxW (ORCPT ); Thu, 25 Apr 2019 11:53:22 -0400 Received: from casper.infradead.org ([85.118.1.10]:44084 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfDYPxV (ORCPT ); Thu, 25 Apr 2019 11:53:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=E3NXYmNospchyn56GjhuUUM3hrUac73tHVKaHCldfOk=; b=Bonx4HPMYcr3a2nktGqFVhvpkC Lm7Jv3Ti63Kv4EMBUFae5lI4ptDC5RAI5ElUhwvqH9DfP8HL3oLak9sqkNi1SrdMbInWhlezS4ZQv TaB3dxTt/lLAd7hovrVYa5w4+CCJd72lsXCzDbUllvhVuoJLaU1Hl5+LKJVzv+MI7D167ykTh2GZK d6OPs3hXZSnLAXf1R6CrpdOPA9x9rme1ywi76UowaMUx1f609U55StEwsjKOyqNJVxN4cMGncdYB6 KnVvdda0AmWSEMwWetcrVOOCMdnwjzCP88m9Y10yNoScW0lTGYk+7ZUQxJpbglecBDUogb5ukJzjR 1L7XLtaQ==; Received: from [179.95.39.209] (helo=coco.lan) by casper.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJggS-0007pK-Bs; Thu, 25 Apr 2019 15:53:12 +0000 Date: Thu, 25 Apr 2019 12:53:01 -0300 From: Mauro Carvalho Chehab To: Al Viro Cc: Arnd Bergmann , linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Daniel Vetter , Greg Kroah-Hartman , David Sterba , Darren Hart , Jonathan Cameron , Bjorn Andersson , devel@driverdev.osuosl.org, qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Sean Young Subject: Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl Message-ID: <20190425125301.5165cf15@coco.lan> In-Reply-To: <20190425153534.GS2217@ZenIV.linux.org.uk> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202701.127745-1-arnd@arndb.de> <20190425122153.450fc094@coco.lan> <20190425153534.GS2217@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190425155301.UBia0XVAX8va7SjrQzWzFgI781tlsn406yB0Alru1HU@z> Em Thu, 25 Apr 2019 16:35:34 +0100 Al Viro escreveu: > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->compat_ioctl same as ->unlocked_ioctl > and be done with that; compat_ptr() is a no-op anyway" breaks. IOW, > s390 is the reason for having compat_ptr_ioctl() in the first place; > that thing works on all biarch architectures, as long as all stuff > handled by ->ioctl() takes pointer to arch-independent object as > argument. IOW, > argument ignored => OK > any arithmetical type => no go, compat_ptr() would bugger it > pointer to int => OK That's the case for all LIRC ioctls: they all use a pointer to u32 argument. > pointer to string => OK > pointer to u64 => OK > pointer to struct {u64 addr; char s[11];} => OK > pointer to long => needs explicit handler > pointer to struct {void *addr; char s[11];} => needs explicit handler > pointer to struct {int x; u64 y;} => needs explicit handler on amd64 > For "just use ->unlocked_ioctl for ->ioctl" we have > argument ignored => OK > any arithmetical type => OK > any pointer => instant breakage on s390, in addtion to cases that break > with compat_ptr_ioctl(). > > Probably some form of that ought to go into commit message for compat_ptr_ioctl() > introduction... Agreed. Thanks, Mauro