From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,13/13] dts: hi3660: Add support for usb on Hikey960 From: Rob Herring Message-Id: <20190425220016.GC32028@bogus> Date: Thu, 25 Apr 2019 17:00:16 -0500 To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Chunfeng Yun , Wei Xu , Mark Rutland , linux-arm-kernel@lists.infradead.org, Binghui Wang List-ID: T24gU2F0LCBBcHIgMjAsIDIwMTkgYXQgMDI6NDA6MTlQTSArMDgwMCwgWXUgQ2hlbiB3cm90ZToK PiBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCBmb3IgdXNiIG9uIEhpa2V5OTYwLgo+IAo+IENjOiBD aHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4gQ2M6IFdlaSBYdSA8eHV3 ZWk1QGhpc2lsaWNvbi5jb20+Cj4gQ2M6IFJvYiBIZXJyaW5nIDxyb2JoK2R0QGtlcm5lbC5vcmc+ Cj4gQ2M6IE1hcmsgUnV0bGFuZCA8bWFyay5ydXRsYW5kQGFybS5jb20+Cj4gQ2M6IGxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IENjOiBKb2huIFN0dWx0eiA8am9obi5zdHVs dHpAbGluYXJvLm9yZz4KPiBDYzogQmluZ2h1aSBXYW5nIDx3YW5nYmluZ2h1aUBoaXNpbGljb24u Y29tPgo+IFNpZ25lZC1vZmYtYnk6IFl1IENoZW4gPGNoZW55dTU2QGh1YXdlaS5jb20+Cj4gLS0t Cj4gdjI6Cj4gKiBSZW1vdmUgZGV2aWNlX3R5cGUgcHJvcGVydHkuCj4gKiBBZGQgcHJvcGVydHkg InVzYi1yb2xlLXN3aXRjaCIuCj4gdjM6Cj4gKiBNYWtlIG5vZGUgInVzYl9waHkiIGEgc3Vibm9k ZSBvZiB1c2IzX290Z19iYyByZWdpc3Rlci4KPiAqIFJlbW92ZSBwcm9wZXJ0eSAidHlwZWMtdmJ1 cy1lbmFibGUtdmFsIiBvZiBoaXNpX2hpa2V5X3VzYi4KPiB2NDoKPiAqIFJlbW92ZSBwcm9wZXJ0 eSAiaGlzaWxpY29uLHVzYjMtb3RnLWJjLXN5c2NvbiIgb2YgdXNiLXBoeS4KPiAtLS0KPiAtLS0K PiAgYXJjaC9hcm02NC9ib290L2R0cy9oaXNpbGljb24vaGkzNjYwLWhpa2V5OTYwLmR0cyB8IDUz ICsrKysrKysrKysrKysrKysKPiAgYXJjaC9hcm02NC9ib290L2R0cy9oaXNpbGljb24vaGkzNjYw LmR0c2kgICAgICAgICB8IDczICsrKysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hh bmdlZCwgMTI2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290 L2R0cy9oaXNpbGljb24vaGkzNjYwLWhpa2V5OTYwLmR0cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMv aGlzaWxpY29uL2hpMzY2MC1oaWtleTk2MC5kdHMKPiBpbmRleCBlMDM1Y2YxOTViMTkuLmQ0ZTEx YzU2YjI1MCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2hpc2lsaWNvbi9oaTM2 NjAtaGlrZXk5NjAuZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9oaXNpbGljb24vaGkz NjYwLWhpa2V5OTYwLmR0cwo+IEBAIC0xMyw2ICsxMyw3IEBACj4gICNpbmNsdWRlIDxkdC1iaW5k aW5ncy9ncGlvL2dwaW8uaD4KPiAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2lucHV0L2lucHV0Lmg+ Cj4gICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9pcnEuaD4KPiAr I2luY2x1ZGUgPGR0LWJpbmRpbmdzL3VzYi9wZC5oPgo+ICAKPiAgLyB7Cj4gIAltb2RlbCA9ICJI aUtleTk2MCI7Cj4gQEAgLTE5Niw2ICsxOTcsMjYgQEAKPiAgCQkJbWV0aG9kID0gInNtYyI7Cj4g IAkJfTsKPiAgCX07Cj4gKwo+ICsJaGlzaV9oaWtleV91c2I6IGhpc2lfaGlrZXlfdXNiIHsKPiAr CQljb21wYXRpYmxlID0gImhpc2lsaWNvbixoaWtleTk2MF91c2IiOwo+ICsJCXR5cGVjLXZidXMt Z3Bpb3MgPSA8JmdwaW8yNSAyIEdQSU9fQUNUSVZFX0hJR0g+Owo+ICsJCW90Zy1zd2l0Y2gtZ3Bp b3MgPSA8JmdwaW8yNSA2IEdQSU9fQUNUSVZFX0hJR0g+Owo+ICsJCWh1Yi12ZGQzMy1lbi1ncGlv cyA9IDwmZ3BpbzUgNiBHUElPX0FDVElWRV9ISUdIPjsKPiArCQlwaW5jdHJsLW5hbWVzID0gImRl ZmF1bHQiOwo+ICsJCXBpbmN0cmwtMCA9IDwmdXNiaHViNTczNF9wbXhfZnVuYz47Cj4gKwo+ICsJ CXBvcnQgewo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJI3NpemUtY2VsbHMgPSA8 MD47Cj4gKwo+ICsJCQloaWtleV91c2JfZXA6IGVuZHBvaW50QDAgewo+ICsJCQkJcmVnID0gPDA+ Owo+ICsJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZkd2MzX3JvbGVfc3dpdGNoX25vdGlmeT47Cj4g KwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gKwo+ICB9Owo+ICAKPiAgLyoKPiBAQCAtNTI2LDYgKzU0 NywzOCBAQAo+ICAmaTJjMSB7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIAo+ICsJcnQxNzExaDog cnQxNzExaEA0ZSB7Cj4gKwkJY29tcGF0aWJsZSA9ICJyaWNodGVrLHJ0MTcxMWgiOwoKVGhlIGJp bmRpbmcgZG9jIGZvciB0aGlzIHNob3VsZCBzdGF0ZSBpdCBzaG91bGQgaGF2ZSBhICdjb25uZWN0 b3InIG5vZGUuCgo+ICsJCXJlZyA9IDwweDRlPjsKPiArCQlzdGF0dXMgPSAib2siOwoKQ2FuIGRy b3AgdGhpcywgaXQgaXMgdGhlIGRlZmF1bHQuCgo+ICsJCWludGVycnVwdC1wYXJlbnQgPSA8Jmdw aW8yNz47Cj4gKwkJaW50ZXJydXB0cyA9IDwzIElSUV9UWVBFX0xFVkVMX0xPVz47Cj4gKwkJcGlu Y3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCQlwaW5jdHJsLTAgPSA8JnVzYl9jZmdfZnVuYz47 Cj4gKwo+ICsJCXVzYl9jb246IGNvbm5lY3RvciB7Cj4gKwkJCWNvbXBhdGlibGUgPSAidXNiLWMt Y29ubmVjdG9yIjsKPiArCQkJbGFiZWwgPSAiVVNCLUMiOwo+ICsJCQlkYXRhLXJvbGUgPSAiZHVh bCI7Cj4gKwkJCXBvd2VyLXJvbGUgPSAiZHVhbCI7Cj4gKwkJCXRyeS1wb3dlci1yb2xlID0gInNp bmsiOwo+ICsJCQlzb3VyY2UtcGRvcyA9IDxQRE9fRklYRUQoNTAwMCwgNTAwLCBQRE9fRklYRURf VVNCX0NPTU0pPjsKPiArCQkJc2luay1wZG9zID0gPFBET19GSVhFRCg1MDAwLCA1MDAsIFBET19G SVhFRF9VU0JfQ09NTSkKPiArCQkJCVBET19WQVIoNTAwMCwgNTAwMCwgMTAwMCk+Owo+ICsJCQlv cC1zaW5rLW1pY3Jvd2F0dCA9IDwxMDAwMDAwMD47Cj4gKwkJfTsKPiArCj4gKwkJcG9ydCB7CgpU aGUgY29ubmVjdG9yIG5vZGUgc2hvdWxkIGhhdmUgYSAncG9ydHMnIGNoaWxkIHdpdGggJ3BvcnRA MCcgYmVpbmcgdGhlIApIUyBjb25uZWN0aW9uLgoKPiArCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47 Cj4gKwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsKPiArCQkJcnQxNzExaF9lcDogZW5kcG9pbnRA MCB7Cj4gKwkJCQlyZWcgPSA8MD47Cj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmR3YzNfcm9s ZV9zd2l0Y2g+Owo+ICsJCQl9Owo+ICsJCX07Cj4gKwl9Owo+ICsKPiAgCWFkdjc1MzM6IGFkdjc1 MzNAMzkgewo+ICAJCXN0YXR1cyA9ICJvayI7Cj4gIAkJY29tcGF0aWJsZSA9ICJhZGksYWR2NzUz MyI7Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvaGlzaWxpY29uL2hpMzY2MC5k dHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9oaXNpbGljb24vaGkzNjYwLmR0c2kKPiBpbmRleCAy ZjE5ZTBlNWI3Y2YuLjE3MzQ2NzUwNWFkYSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3Qv ZHRzL2hpc2lsaWNvbi9oaTM2NjAuZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvaGlz aWxpY29uL2hpMzY2MC5kdHNpCj4gQEAgLTM1NSw2ICszNTUsMTIgQEAKPiAgCQkJI2Nsb2NrLWNl bGxzID0gPDE+Owo+ICAJCX07Cj4gIAo+ICsJCXBtY3RybDogcG1jdHJsQGZmZjMxMDAwIHsKPiAr CQkJY29tcGF0aWJsZSA9ICJoaXNpbGljb24saGkzNjYwLXBtY3RybCIsICJzeXNjb24iOwo+ICsJ CQlyZWcgPSA8MHgwIDB4ZmZmMzEwMDAgMHgwIDB4MTAwMD47Cj4gKwkJCSNjbG9jay1jZWxscyA9 IDwxPjsKPiArCQl9Owo+ICsKPiAgCQlwbXVjdHJsOiBjcmdfY3RybEBmZmYzNDAwMCB7Cj4gIAkJ CWNvbXBhdGlibGUgPSAiaGlzaWxpY29uLGhpMzY2MC1wbXVjdHJsIiwgInN5c2NvbiI7Cj4gIAkJ CXJlZyA9IDwweDAgMHhmZmYzNDAwMCAweDAgMHgxMDAwPjsKPiBAQCAtMTEzNCw1ICsxMTQwLDcy IEBACj4gIAkJCQl9Owo+ICAJCQl9Owo+ICAJCX07Cj4gKwo+ICsJCXVzYjNfb3RnX2JjOiB1c2Iz X290Z19iY0BmZjIwMDAwMCB7Cj4gKwkJCWNvbXBhdGlibGUgPSAic3lzY29uIiwgInNpbXBsZS1t ZmQiOwo+ICsJCQlyZWcgPSA8MHgwIDB4ZmYyMDAwMDAgMHgwIDB4MTAwMD47Cj4gKwo+ICsJCQl1 c2JfcGh5OiB1c2ItcGh5IHsKPiArCQkJCWNvbXBhdGlibGUgPSAiaGlzaWxpY29uLGhpMzY2MC11 c2ItcGh5IjsKPiArCQkJCSNwaHktY2VsbHMgPSA8MD47Cj4gKwkJCQloaXNpbGljb24scGVyaWNy Zy1zeXNjb24gPSA8JmNyZ19jdHJsPjsKPiArCQkJCWhpc2lsaWNvbixwY3RybC1zeXNjb24gPSA8 JnBjdHJsPjsKPiArCQkJCWhpc2lsaWNvbixleWUtZGlhZ3JhbS1wYXJhbSA9IDwweDIyNDY2ZTQ+ Owo+ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICsJCXVzYjM6IGhpc2lfZHdjMyB7Cj4gKwkJCWNvbXBh dGlibGUgPSAiaGlzaWxpY29uLGhpMzY2MC1kd2MzIjsKPiArCQkJI2FkZHJlc3MtY2VsbHMgPSA8 Mj47Cj4gKwkJCSNzaXplLWNlbGxzID0gPDI+Owo+ICsJCQlyYW5nZXM7CgpJZiB0aGVyZSBhcmUg bm90IGFueSB3cmFwcGVyIHJlZ2lzdGVycywgdGhlbiBnZXQgcmlkIG9mIHRoZSBoaXNpX2R3YzMg Cm5vZGUuIEZvciBqdXN0IGNsb2NrcyBhbmQgcmVzZXRzIHdlIGp1c3QgcHV0IGV2ZXJ5dGhpbmcg aW4gb25lIG5vZGUuCgo+ICsKPiArCQkJY2xvY2tzID0gPCZjcmdfY3RybCBISTM2NjBfQ0xLX0FC Ql9VU0I+LAo+ICsJCQkJIDwmY3JnX2N0cmwgSEkzNjYwX0FDTEtfR0FURV9VU0IzT1RHPjsKPiAr CQkJY2xvY2stbmFtZXMgPSAiY2xrX3VzYjNwaHlfcmVmIiwgImFjbGtfdXNiM290ZyI7Cj4gKwo+ ICsJCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNyZ19jdHJsIEhJMzY2MF9BQ0xLX0dBVEVfVVNCM09U Rz47Cj4gKwkJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIyOTAwMDAwMD47Cj4gKwkJCXJlc2V0 cyA9IDwmY3JnX3JzdCAweDkwIDg+LAo+ICsJCQkJIDwmY3JnX3JzdCAweDkwIDc+LAo+ICsJCQkJ IDwmY3JnX3JzdCAweDkwIDY+LAo+ICsJCQkJIDwmY3JnX3JzdCAweDkwIDU+Owo+ICsKPiArCQkJ ZHdjMzogZHdjM0BmZjEwMDAwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0gInNucHMsZHdjMyI7Cj4g KwkJCQlyZWcgPSA8MHgwIDB4ZmYxMDAwMDAgMHgwIDB4MTAwMDAwPjsKPiArCQkJCWludGVycnVw dHMgPSA8MCAxNTkgND4sIDwwIDE2MSA0PjsKPiArCQkJCXBoeXMgPSA8JnVzYl9waHk+Owo+ICsJ CQkJcGh5LW5hbWVzID0gInVzYjMtcGh5IjsKPiArCQkJCWRyX21vZGUgPSAib3RnIjsKPiArCQkJ CW1heGltdW0tc3BlZWQgPSAic3VwZXItc3BlZWQiOwo+ICsJCQkJcGh5X3R5cGUgPSAidXRtaSI7 Cj4gKwkJCQlzbnBzLGRpcy1kZWwtcGh5LXBvd2VyLWNoZy1xdWlyazsKCj4gKwkJCQlzbnBzLGxm cHNfZmlsdGVyX3F1aXJrOwo+ICsJCQkJc25wcyxkaXNfdTJfc3VzcGh5X3F1aXJrOwo+ICsJCQkJ c25wcyxkaXNfdTNfc3VzcGh5X3F1aXJrOwo+ICsJCQkJc25wcyx0eF9kZV9lbXBoYXNpc19xdWly azsKPiArCQkJCXNucHMsdHhfZGVfZW1waGFzaXMgPSA8MT47Cj4gKwkJCQlzbnBzLGRpc19lbmJs c2xwbV9xdWlyazsKClByZXR0eSBzdXJlIHRoZXNlIGFyZW4ndCBkb2N1bWVudGVkIGJlY2F1c2Ug d2UgZG9uJ3QgdXNlICdfJyBpbiBwcm9wZXJ0eSAKbmFtZXMuCgo+ICsJCQkJc25wcyxnY3RsLXJl c2V0LXF1aXJrOwo+ICsJCQkJdXNiLXJvbGUtc3dpdGNoOwo+ICsJCQkJcm9sZS1zd2l0Y2gtZGVm YXVsdC1ob3N0Owo+ICsKPiArCQkJCXBvcnQgewo+ICsJCQkJCSNhZGRyZXNzLWNlbGxzID0gPDE+ Owo+ICsJCQkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsKPiArCQkJCQlkd2MzX3JvbGVfc3dpdGNo OiBlbmRwb2ludEAwIHsKPiArCQkJCQkJcmVnID0gPDA+Owo+ICsJCQkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JnJ0MTcxMWhfZXA+Owo+ICsJCQkJCX07Cj4gKwo+ICsJCQkJCWR3YzNfcm9sZV9zd2l0 Y2hfbm90aWZ5OiBlbmRwb2ludEAxIHsKPiArCQkJCQkJcmVnID0gPDE+Owo+ICsJCQkJCQlyZW1v dGUtZW5kcG9pbnQgPSA8Jmhpa2V5X3VzYl9lcD47Cj4gKwkJCQkJfTsKPiArCQkJCX07Cj4gKwkJ CX07Cj4gKwkJfTsKPiAgCX07Cj4gIH07Cj4gLS0gCj4gMi4xNS4wLXJjMgo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC50FC43218 for ; Thu, 25 Apr 2019 22:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B92FC206C1 for ; Thu, 25 Apr 2019 22:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556229625; bh=mLSfOLHdA+9HCzwiSNTIsNhISiPs5vOjRPKB6VEpF2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NdJounk4xa15FGgRjIjaTSUr47cdO/1Tll/N3A78jVwESbeBUOcf+c+PnZWy654Np fNyXLcYKdj/LLufWggC4AEiUupOsPAiBHqbYRzIgbq3l5lcAXOl6iyh982FgfkmMV3 8+HxnSxMPMbt2trodJPD9wQ0ixYeo79w2C5mInTQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730913AbfDYWAT (ORCPT ); Thu, 25 Apr 2019 18:00:19 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:34540 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729583AbfDYWAT (ORCPT ); Thu, 25 Apr 2019 18:00:19 -0400 Received: by mail-ot1-f68.google.com with SMTP id u17so952773otj.1; Thu, 25 Apr 2019 15:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=whXKt4Pab5nmF5Mk6pUKSZ8aWVNzgM6bKw4nLSkqCv0=; b=HdADnwkNIhj4VQL8S4m6xlF3AfrBdX8o4cWELIrtepPJMmRkq9tnWEGKRvQk99xEbk lrX9T6O5rCnPcp0nn9R8VO8FxetsRu2i5ZApHphsUE1d3n3ATOLXhI/gxbE80HULUlW7 rqYY2ec8RCIhsgFIR+Ea5qQ7jw3r0JW5lfOB3ECARTKXgbM4/1h+eZlRjISG8dMQzutz xibox0XQkotDUQO7Qn97gvE56nBAUOdr9znuMilTKdouzJ3O9GIoURRQUHihKkaoUzUU TtSHrGxggRI2bPMJeyZGsriLTl40dop/zw2tRjWdGFgmYka8dYmVzNUe9Ygd/ufOSues tJyg== X-Gm-Message-State: APjAAAUsROWnVJS7tri01YG24/Sxaq/dc+Vqbw/TUj3Vx89uLm9mNKR/ h7oBd+cF/2GlLAq7NbRLEw== X-Google-Smtp-Source: APXvYqyLRCB8Rg5MB86d3r5nWASw/Rrc8qjUWvL6B7NO5ZcIK/Q1TzNnddkNXY1mXN4RzsTF61kPlw== X-Received: by 2002:a9d:7f0b:: with SMTP id j11mr15588589otq.132.1556229618103; Thu, 25 Apr 2019 15:00:18 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u198sm10173424oie.26.2019.04.25.15.00.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 15:00:17 -0700 (PDT) Date: Thu, 25 Apr 2019 17:00:16 -0500 From: Rob Herring To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Chunfeng Yun , Wei Xu , Mark Rutland , linux-arm-kernel@lists.infradead.org, Binghui Wang Subject: Re: [PATCH v6 13/13] dts: hi3660: Add support for usb on Hikey960 Message-ID: <20190425220016.GC32028@bogus> References: <20190420064019.57522-1-chenyu56@huawei.com> <20190420064019.57522-14-chenyu56@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190420064019.57522-14-chenyu56@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190425220016.eQu7K51elA7ou5parHKJtV4R9-jKgYlG_YEFDRus57M@z> On Sat, Apr 20, 2019 at 02:40:19PM +0800, Yu Chen wrote: > This patch adds support for usb on Hikey960. > > Cc: Chunfeng Yun > Cc: Wei Xu > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: John Stultz > Cc: Binghui Wang > Signed-off-by: Yu Chen > --- > v2: > * Remove device_type property. > * Add property "usb-role-switch". > v3: > * Make node "usb_phy" a subnode of usb3_otg_bc register. > * Remove property "typec-vbus-enable-val" of hisi_hikey_usb. > v4: > * Remove property "hisilicon,usb3-otg-bc-syscon" of usb-phy. > --- > --- > arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 53 ++++++++++++++++ > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 73 +++++++++++++++++++++++ > 2 files changed, 126 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > index e035cf195b19..d4e11c56b250 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > / { > model = "HiKey960"; > @@ -196,6 +197,26 @@ > method = "smc"; > }; > }; > + > + hisi_hikey_usb: hisi_hikey_usb { > + compatible = "hisilicon,hikey960_usb"; > + typec-vbus-gpios = <&gpio25 2 GPIO_ACTIVE_HIGH>; > + otg-switch-gpios = <&gpio25 6 GPIO_ACTIVE_HIGH>; > + hub-vdd33-en-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usbhub5734_pmx_func>; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hikey_usb_ep: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dwc3_role_switch_notify>; > + }; > + }; > + }; > + > }; > > /* > @@ -526,6 +547,38 @@ > &i2c1 { > status = "okay"; > > + rt1711h: rt1711h@4e { > + compatible = "richtek,rt1711h"; The binding doc for this should state it should have a 'connector' node. > + reg = <0x4e>; > + status = "ok"; Can drop this, it is the default. > + interrupt-parent = <&gpio27>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_cfg_func>; > + > + usb_con: connector { > + compatible = "usb-c-connector"; > + label = "USB-C"; > + data-role = "dual"; > + power-role = "dual"; > + try-power-role = "sink"; > + source-pdos = ; > + sink-pdos = + PDO_VAR(5000, 5000, 1000)>; > + op-sink-microwatt = <10000000>; > + }; > + > + port { The connector node should have a 'ports' child with 'port@0' being the HS connection. > + #address-cells = <1>; > + #size-cells = <0>; > + > + rt1711h_ep: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dwc3_role_switch>; > + }; > + }; > + }; > + > adv7533: adv7533@39 { > status = "ok"; > compatible = "adi,adv7533"; > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > index 2f19e0e5b7cf..173467505ada 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > @@ -355,6 +355,12 @@ > #clock-cells = <1>; > }; > > + pmctrl: pmctrl@fff31000 { > + compatible = "hisilicon,hi3660-pmctrl", "syscon"; > + reg = <0x0 0xfff31000 0x0 0x1000>; > + #clock-cells = <1>; > + }; > + > pmuctrl: crg_ctrl@fff34000 { > compatible = "hisilicon,hi3660-pmuctrl", "syscon"; > reg = <0x0 0xfff34000 0x0 0x1000>; > @@ -1134,5 +1140,72 @@ > }; > }; > }; > + > + usb3_otg_bc: usb3_otg_bc@ff200000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0x0 0xff200000 0x0 0x1000>; > + > + usb_phy: usb-phy { > + compatible = "hisilicon,hi3660-usb-phy"; > + #phy-cells = <0>; > + hisilicon,pericrg-syscon = <&crg_ctrl>; > + hisilicon,pctrl-syscon = <&pctrl>; > + hisilicon,eye-diagram-param = <0x22466e4>; > + }; > + }; > + > + usb3: hisi_dwc3 { > + compatible = "hisilicon,hi3660-dwc3"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; If there are not any wrapper registers, then get rid of the hisi_dwc3 node. For just clocks and resets we just put everything in one node. > + > + clocks = <&crg_ctrl HI3660_CLK_ABB_USB>, > + <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; > + clock-names = "clk_usb3phy_ref", "aclk_usb3otg"; > + > + assigned-clocks = <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; > + assigned-clock-rates = <229000000>; > + resets = <&crg_rst 0x90 8>, > + <&crg_rst 0x90 7>, > + <&crg_rst 0x90 6>, > + <&crg_rst 0x90 5>; > + > + dwc3: dwc3@ff100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff100000 0x0 0x100000>; > + interrupts = <0 159 4>, <0 161 4>; > + phys = <&usb_phy>; > + phy-names = "usb3-phy"; > + dr_mode = "otg"; > + maximum-speed = "super-speed"; > + phy_type = "utmi"; > + snps,dis-del-phy-power-chg-quirk; > + snps,lfps_filter_quirk; > + snps,dis_u2_susphy_quirk; > + snps,dis_u3_susphy_quirk; > + snps,tx_de_emphasis_quirk; > + snps,tx_de_emphasis = <1>; > + snps,dis_enblslpm_quirk; Pretty sure these aren't documented because we don't use '_' in property names. > + snps,gctl-reset-quirk; > + usb-role-switch; > + role-switch-default-host; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + dwc3_role_switch: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&rt1711h_ep>; > + }; > + > + dwc3_role_switch_notify: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hikey_usb_ep>; > + }; > + }; > + }; > + }; > }; > }; > -- > 2.15.0-rc2 >