From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] usb: usb251xb: Lock i2c-bus segment the hub resides From: Serge Semin Message-Id: <20190425223256.20270-1-fancer.lancer@gmail.com> Date: Fri, 26 Apr 2019 01:32:56 +0300 To: Richard Leitner , Greg Kroah-Hartman Cc: Serge Semin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: U01CdXMgc2xhdmUgY29uZmlndXJhdGlvbiBpcyBhY3RpdmF0ZWQgYnkgQ0ZHX1NFTFsxOjBdPTB4 MSBwaW5zCnN0YXRlLiBUaGlzIGlzIHRoZSBtb2RlIHRoZSBodWIgaXMgc3VwcG9zZWQgdG8gYmUg dG8gbGV0IHRoaXMgZHJpdmVyCndvcmsgY29ycmVjdGx5LiBCdXQgYSByYWNlIGNvbmRpdGlvbiBt aWdodCBoYXBwZW4gcmlnaHQgYWZ0ZXIgcmVzZXQKaXMgY2xlYXJlZCBkdWUgdG8gQ0ZHX1NFTFsw XSBwaW4gYmVpbmcgbXVsdGlwbGV4ZWQgd2l0aCBTTUJ1cyBTQ0wKZnVuY3Rpb24uIEluIGNhc2Ug aWYgdGhlIHJlc2V0IHBpbiBpcyBoYW5kbGVkIGJ5IGEgaTJjIEdQSU8gZXhwYW5kZXIsCndoaWNo IGlzIGFsc28gcGxhY2VkIGF0IHRoZSBzYW1lIGkyYy1idXMgc2VnbWVudCBhcyB0aGUgdXNiMjUx eApTTUItaW50ZXJmYWNlIGNvbm5lY3RlZCB0bywgdGhlbiB0aGUgaHViIHJlc2V0IGNsZWFyYW5j ZSBtaWdodApjYXVzZSB0aGUgQ0ZHX1NFTFswXSBiZWluZyBsYXRjaGVkIGluIHVucHJlZGljdGFi bGUgc3RhdGUuIFNvCnNvbWV0aW1lcyB0aGUgaHViIGNvbmZpZ3VyYXRpb24gbW9kZSBtaWdodCBi ZSAweDEgKGFzIGV4cGVjdGVkKSwKYnV0IHNvbWV0aW1lcyBiZWluZyAweDAsIHdoaWNoIGRvZXNu J3QgaW1wbHkgdG8gaGF2ZSB0aGUgaHViIFNNQnVzLXNsYXZlCmludGVyZmFjZSBhY3RpdmF0ZWQg YW5kIGNvbnNlcXVlbnRseSBjYXVzZXMgdGhpcyBkcml2ZXIgZmFpbHVyZS4KCkluIG9yZGVyIHRv IGZpeCB0aGUgcHJvYmxlbSB3ZSBtdXN0IG1ha2Ugc3VyZSB0aGUgR1BJTy1yZXNldCBjaGlwIGRv ZXNuJ3QKcmVzaWRlIHRoZSBzYW1lIGkyYy1idXMgc2VnbWVudCBhcyB0aGUgU01CdXMtaW50ZXJm YWNlIG9mIHRoZSBodWIuIElmCml0IGRvZXNuJ3QsIHdlIGNhbiBzYWZlbHkgYmxvY2sgdGhlIHNl Z21lbnQgZm9yIHRoZSB0aW1lIHRoZSByZXNldCBpcwpjbGVhcmVkIHRvIHByZXZlbnQgYW55b25l IGdlbmVyYXRpbmcgYSB0cmFmZmljIGF0IHRoZSBpMmMtYnVzIFNDTCBsYW5lCmNvbm5lY3RlZCB0 byB0aGUgQ0ZHX1NFTFswXSBwaW4uIEJ1dCBpZiBpdCBkb2VzLCBub3RoaW5nIHdlIGNhbiBkbywg c28KanVzdCByZXR1cm4gYW4gZXJyb3IuIElmIHdlIGxvY2tlZCB0aGUgaTJjLWJ1cyBzZWdtZW50 IGFuZCB0cmllZCB0bwpjb21tdW5pY2F0ZSB3aXRoIHRoZSBHUElPLWV4cGFuZGVyLCBpdCB3b3Vs ZCBjYXVzZSBhIGRlYWRsb2NrLiBJZiB3ZSBkaWRuJ3QKbG9jayB0aGUgaTJjLWJ1cyBzZWdtZW50 LCBpdCB3b3VsZCByYW5kb21seSBjYXVzZSB0aGUgQ0ZHX1NFTFswXSBiaXQgZmxpcC4KClNpZ25l ZC1vZmYtYnk6IFNlcmdlIFNlbWluIDxmYW5jZXIubGFuY2VyQGdtYWlsLmNvbT4KU2lnbmVkLW9m Zi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0t CkNoYW5nZWxvZyB2MgotIEV4ZWN1dGUgdGhlIGNoZWNrIGNvZGUgb25seSBpZiBHUElPTElCIGlz IGVuYWJsZWQgKHJlcG9ydGVkIGJ5CiAgYSBidWlsZCByb2JvdCkuCgotLS0KIGRyaXZlcnMvdXNi L21pc2MvdXNiMjUxeGIuYyB8IDYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKIDEgZmlsZSBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVy cy91c2IvbWlzYy91c2IyNTF4Yi5jIGIvZHJpdmVycy91c2IvbWlzYy91c2IyNTF4Yi5jCmluZGV4 IDA0Njg0ODQ5ZDY4My4uY2RjODBlOGMyZDhhIDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9taXNj L3VzYjI1MXhiLmMKKysrIGIvZHJpdmVycy91c2IvbWlzYy91c2IyNTF4Yi5jCkBAIC0xMiw2ICsx Miw3IEBACiAKICNpbmNsdWRlIDxsaW51eC9kZWxheS5oPgogI2luY2x1ZGUgPGxpbnV4L2dwaW8v Y29uc3VtZXIuaD4KKyNpbmNsdWRlIDxsaW51eC9ncGlvL2RyaXZlci5oPgogI2luY2x1ZGUgPGxp bnV4L2kyYy5oPgogI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgogI2luY2x1ZGUgPGxpbnV4L25s cy5oPgpAQCAtMjIyLDExICsyMjMsNTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB1c2IyNTF4Yl9k YXRhIHVzYjI1MTdpX2RhdGEgPSB7CiAJLnByb2R1Y3Rfc3RyID0gIlVTQjI1MTdpIiwKIH07CiAK KyNpZmRlZiBDT05GSUdfR1BJT0xJQgorc3RhdGljIGludCB1c2IyNTF4Yl9jaGVja19kZXZfY2hp bGRyZW4oc3RydWN0IGRldmljZSAqZGV2LCB2b2lkICpjaGlsZCkKK3sKKwlpZiAoZGV2LT50eXBl ID09ICZpMmNfYWRhcHRlcl90eXBlKSB7CisJCXJldHVybiBkZXZpY2VfZm9yX2VhY2hfY2hpbGQo ZGV2LCBjaGlsZCwKKwkJCQkJICAgICB1c2IyNTF4Yl9jaGVja19kZXZfY2hpbGRyZW4pOworCX0K KworCXJldHVybiAoZGV2ID09IGNoaWxkKTsKK30KKworc3RhdGljIGludCB1c2IyNTF4X2NoZWNr X2dwaW9fY2hpcChzdHJ1Y3QgdXNiMjUxeGIgKmh1YikKK3sKKwlzdHJ1Y3QgZ3Bpb19jaGlwICpn YyA9IGdwaW9kX3RvX2NoaXAoaHViLT5ncGlvX3Jlc2V0KTsKKwlzdHJ1Y3QgaTJjX2FkYXB0ZXIg KmFkYXAgPSBodWItPmkyYy0+YWRhcHRlcjsKKwlpbnQgcmV0OworCisJaWYgKCFodWItPmdwaW9f cmVzZXQpCisJCXJldHVybiAwOworCisJaWYgKCFnYykKKwkJcmV0dXJuIC1FSU5WQUw7CisKKwly ZXQgPSB1c2IyNTF4Yl9jaGVja19kZXZfY2hpbGRyZW4oJmFkYXAtPmRldiwgZ2MtPnBhcmVudCk7 CisJaWYgKHJldCkgeworCQlkZXZfZXJyKGh1Yi0+ZGV2LCAiUmVzZXQgR1BJTyBjaGlwIGlzIGF0 IHRoZSBzYW1lIGkyYy1idXNcbiIpOworCQlyZXR1cm4gLUVJTlZBTDsKKwl9CisKKwlyZXR1cm4g MDsKK30KKyNlbHNlCitzdGF0aWMgaW50IHVzYjI1MXhfY2hlY2tfZ3Bpb19jaGlwKHN0cnVjdCB1 c2IyNTF4YiAqaHViKQoreworCXJldHVybiAwOworfQorI2VuZGlmCisKIHN0YXRpYyB2b2lkIHVz YjI1MXhiX3Jlc2V0KHN0cnVjdCB1c2IyNTF4YiAqaHViLCBpbnQgc3RhdGUpCiB7CiAJaWYgKCFo dWItPmdwaW9fcmVzZXQpCiAJCXJldHVybjsKIAorCWkyY19sb2NrX2J1cyhodWItPmkyYy0+YWRh cHRlciwgSTJDX0xPQ0tfU0VHTUVOVCk7CisKIAlncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXAoaHVi LT5ncGlvX3Jlc2V0LCBzdGF0ZSk7CiAKIAkvKiB3YWl0IGZvciBodWIgcmVjb3Zlcnkvc3RhYmls aXphdGlvbiAqLwpAQCAtMjM0LDYgKzI3NSw4IEBAIHN0YXRpYyB2b2lkIHVzYjI1MXhiX3Jlc2V0 KHN0cnVjdCB1c2IyNTF4YiAqaHViLCBpbnQgc3RhdGUpCiAJCXVzbGVlcF9yYW5nZSg1MDAsIDc1 MCk7CS8qID49NTAwdXMgYXQgcG93ZXIgb24gKi8KIAllbHNlCiAJCXVzbGVlcF9yYW5nZSgxLCAx MCk7CS8qID49MXVzIGF0IHBvd2VyIGRvd24gKi8KKworCWkyY191bmxvY2tfYnVzKGh1Yi0+aTJj LT5hZGFwdGVyLCBJMkNfTE9DS19TRUdNRU5UKTsKIH0KIAogc3RhdGljIGludCB1c2IyNTF4Yl9j b25uZWN0KHN0cnVjdCB1c2IyNTF4YiAqaHViKQpAQCAtNjIxLDYgKzY2NCwyNSBAQCBzdGF0aWMg aW50IHVzYjI1MXhiX3Byb2JlKHN0cnVjdCB1c2IyNTF4YiAqaHViKQogCQl9CiAJfQogCisJLyoK KwkgKiB1c2IyNTF4IFNNQnVzLXNsYXZlIFNDTCBsYW5lIGlzIG11eGVkIHdpdGggQ0ZHX1NFTDAg cGluLiBTbyBpZiBhbnlvbmUKKwkgKiB0cmllcyB0byB3b3JrIHdpdGggdGhlIGJ1cyBhdCB0aGUg bW9tZW50IHRoZSBodWIgcmVzZXQgaXMgcmVsZWFzZWQsCisJICogaXQgbWF5IGNhdXNlIGFuIGlu dmFsaWQgY29uZmlnIGJlaW5nIGxhdGNoZWQgYnkgdXNiMjUxeC4gUGFydGljdWxhcmx5CisJICog b25lIG9mIHRoZSBjb25maWcgbW9kZXMgbWFrZXMgdGhlIGh1YiBsb2FkaW5nIGEgZGVmYXVsdCBy ZWdpc3RlcnMKKwkgKiB2YWx1ZSB3aXRob3V0IFNNQnVzLXNsYXZlIGludGVyZmFjZSBhY3RpdmF0 aW9uLiBJZiB0aGUgaHViCisJICogYWNjaWRlbnRhbGx5IGdldHMgdGhpcyBtb2RlLCB0aGlzIHdp bGwgY2F1c2UgdGhlIGRyaXZlciBTTUJ1cy0KKwkgKiBmdW5jdGlvbnMgZmFpbHVyZS4gTm9ybWFs bHkgd2UgY291bGQganVzdCBsb2NrIHRoZSBTTUJ1cy1zZWdtZW50IHRoZQorCSAqIGh1YiBpMmMt aW50ZXJmYWNlIHJlc2lkZXMgZm9yIHRoZSBkZXZpY2Utc3BlY2lmaWMgcmVzZXQgdGltaW5nLiBC dXQKKwkgKiB0aGUgR1BJTyBjb250cm9sbGVyLCB3aGljaCBpcyB1c2VkIHRvIGhhbmRsZSB0aGUg aHViIHJlc2V0LCBtaWdodCBiZQorCSAqIHBsYWNlZCBhdCB0aGUgc2FtZSBpMmMtYnVzIHNlZ21l bnQuIEluIHRoaXMgY2FzZSBhbiBlcnJvciBzaG91bGQgYmUKKwkgKiByZXR1cm5lZCBzaW5jZSB3 ZSBjYW4ndCBzYWZlbHkgdXNlIHRoZSBHUElPIGNvbnRyb2xsZXIgdG8gY2xlYXIgdGhlCisJICog cmVzZXQgc3RhdGUgKGl0IG1heSBhZmZlY3QgdGhlIGh1YiBjb25maWd1cmF0aW9uKSBhbmQgd2Ug Y2FuJ3QgbG9jaworCSAqIHRoZSBpMmMtYnVzIHNlZ21lbnQgKGl0IHdpbGwgY2F1c2UgYSBkZWFk bG9jaykuCisJICovCisJZXJyID0gdXNiMjUxeF9jaGVja19ncGlvX2NoaXAoaHViKTsKKwlpZiAo ZXJyKQorCQlyZXR1cm4gZXJyOworCiAJZXJyID0gdXNiMjUxeGJfY29ubmVjdChodWIpOwogCWlm IChlcnIpIHsKIAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gY29ubmVjdCBodWIgKCVkKVxuIiwg ZXJyKTsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A07C43218 for ; Thu, 25 Apr 2019 22:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 560FF20717 for ; Thu, 25 Apr 2019 22:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ip5euGH5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726326AbfDYWdj (ORCPT ); Thu, 25 Apr 2019 18:33:39 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44538 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726040AbfDYWdi (ORCPT ); Thu, 25 Apr 2019 18:33:38 -0400 Received: by mail-lf1-f65.google.com with SMTP id h18so834511lfj.11; Thu, 25 Apr 2019 15:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pnwO3ii3JkeNPr1hcPvBi2/3rAZyjNVc0qQJMLcBg4g=; b=Ip5euGH5ClT6AoUA5raCFKXkbcxLmgokJBIzGPetkjCvSyh5LUm+5Z4/znxyoCTBkB pFPNA8XT+sXH8Ilsngg8XjNO5NCeCsd1aPC3SkGgf5d8utzFj3I2Y2sduj374kdyj5GK gz5WaB4lK55ytGG18Dcg9olkULhHEqrrUuNtnY7vzPmNfaTD7s2YLCoJU19mxbpxh0Bg Ekzx7RtMMYQJ7/1IdwaC7X+xPdAC/z7w+V1LfT/AycK+/AIksQdFmBXLVB5CvExv0vtF IiQVvhd07S3UHi3wB2M5o2BUd4Yj3hiVS34IXQ9br346v8Q+LJpeMnvIpae2rL2EEOzT 4xCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pnwO3ii3JkeNPr1hcPvBi2/3rAZyjNVc0qQJMLcBg4g=; b=ia3APpy1zO2A1hGtSF+7eChJPPUhJBY1aYWy8uanepkraUwvMTinzwvLPL8dBBjejB ge/OetlIoYEZd2uVXepMhlh7eqfEFaDqopHfNaNIRruKfnW21f2591z3oODPTjcYt5Rc W0Vyq5id7A1aD4l6S+WkmJPrmDIbrM+x7sQR4Ckzi2lSiZrbJZp6yO3j0PKf4Hqx7MdH 0xv9neowEyDLtAyMkVFJ9m07Jmx6wXOZ3uQ+xBJt6szKjHq5IACGj5HM4S1mYVpQdLEb 78TId9C6XtMJDaloFFRutlJeZNHLD6uqld/hw0Hn6Ke5xP7v+rECffYOmBg/ukOh3f7r vo2A== X-Gm-Message-State: APjAAAXdE0OegSuIhsCvjMc83D4CA2mrtJbr8uzx49UBD+6hPt+xB5V2 hNi8aLV8UvWOmM9vZKvvEik= X-Google-Smtp-Source: APXvYqxXdekO9jgCOogXP8lb3phLNHUabTl1NErTJUk8047mQrXyHuF3/yms97bic05946xEgMMx8g== X-Received: by 2002:ac2:533c:: with SMTP id f28mr19303555lfh.73.1556231615812; Thu, 25 Apr 2019 15:33:35 -0700 (PDT) Received: from localhost.localdomain ([5.164.240.123]) by smtp.gmail.com with ESMTPSA id m21sm5257382lfj.47.2019.04.25.15.33.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 15:33:34 -0700 (PDT) From: Serge Semin To: Richard Leitner , Greg Kroah-Hartman Cc: Serge Semin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] usb: usb251xb: Lock i2c-bus segment the hub resides Date: Fri, 26 Apr 2019 01:32:56 +0300 Message-Id: <20190425223256.20270-1-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: 20190424144914.10580-1-fancer.lancer@gmail.com References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190425223256.f5lBr9nPm-YTz0hTHcO3ktQZlia1lVIfHjDR6Y9oZhg@z> SMBus slave configuration is activated by CFG_SEL[1:0]=0x1 pins state. This is the mode the hub is supposed to be to let this driver work correctly. But a race condition might happen right after reset is cleared due to CFG_SEL[0] pin being multiplexed with SMBus SCL function. In case if the reset pin is handled by a i2c GPIO expander, which is also placed at the same i2c-bus segment as the usb251x SMB-interface connected to, then the hub reset clearance might cause the CFG_SEL[0] being latched in unpredictable state. So sometimes the hub configuration mode might be 0x1 (as expected), but sometimes being 0x0, which doesn't imply to have the hub SMBus-slave interface activated and consequently causes this driver failure. In order to fix the problem we must make sure the GPIO-reset chip doesn't reside the same i2c-bus segment as the SMBus-interface of the hub. If it doesn't, we can safely block the segment for the time the reset is cleared to prevent anyone generating a traffic at the i2c-bus SCL lane connected to the CFG_SEL[0] pin. But if it does, nothing we can do, so just return an error. If we locked the i2c-bus segment and tried to communicate with the GPIO-expander, it would cause a deadlock. If we didn't lock the i2c-bus segment, it would randomly cause the CFG_SEL[0] bit flip. Signed-off-by: Serge Semin Signed-off-by: Greg Kroah-Hartman --- Changelog v2 - Execute the check code only if GPIOLIB is enabled (reported by a build robot). --- drivers/usb/misc/usb251xb.c | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index 04684849d683..cdc80e8c2d8a 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -222,11 +223,51 @@ static const struct usb251xb_data usb2517i_data = { .product_str = "USB2517i", }; +#ifdef CONFIG_GPIOLIB +static int usb251xb_check_dev_children(struct device *dev, void *child) +{ + if (dev->type == &i2c_adapter_type) { + return device_for_each_child(dev, child, + usb251xb_check_dev_children); + } + + return (dev == child); +} + +static int usb251x_check_gpio_chip(struct usb251xb *hub) +{ + struct gpio_chip *gc = gpiod_to_chip(hub->gpio_reset); + struct i2c_adapter *adap = hub->i2c->adapter; + int ret; + + if (!hub->gpio_reset) + return 0; + + if (!gc) + return -EINVAL; + + ret = usb251xb_check_dev_children(&adap->dev, gc->parent); + if (ret) { + dev_err(hub->dev, "Reset GPIO chip is at the same i2c-bus\n"); + return -EINVAL; + } + + return 0; +} +#else +static int usb251x_check_gpio_chip(struct usb251xb *hub) +{ + return 0; +} +#endif + static void usb251xb_reset(struct usb251xb *hub, int state) { if (!hub->gpio_reset) return; + i2c_lock_bus(hub->i2c->adapter, I2C_LOCK_SEGMENT); + gpiod_set_value_cansleep(hub->gpio_reset, state); /* wait for hub recovery/stabilization */ @@ -234,6 +275,8 @@ static void usb251xb_reset(struct usb251xb *hub, int state) usleep_range(500, 750); /* >=500us at power on */ else usleep_range(1, 10); /* >=1us at power down */ + + i2c_unlock_bus(hub->i2c->adapter, I2C_LOCK_SEGMENT); } static int usb251xb_connect(struct usb251xb *hub) @@ -621,6 +664,25 @@ static int usb251xb_probe(struct usb251xb *hub) } } + /* + * usb251x SMBus-slave SCL lane is muxed with CFG_SEL0 pin. So if anyone + * tries to work with the bus at the moment the hub reset is released, + * it may cause an invalid config being latched by usb251x. Particularly + * one of the config modes makes the hub loading a default registers + * value without SMBus-slave interface activation. If the hub + * accidentally gets this mode, this will cause the driver SMBus- + * functions failure. Normally we could just lock the SMBus-segment the + * hub i2c-interface resides for the device-specific reset timing. But + * the GPIO controller, which is used to handle the hub reset, might be + * placed at the same i2c-bus segment. In this case an error should be + * returned since we can't safely use the GPIO controller to clear the + * reset state (it may affect the hub configuration) and we can't lock + * the i2c-bus segment (it will cause a deadlock). + */ + err = usb251x_check_gpio_chip(hub); + if (err) + return err; + err = usb251xb_connect(hub); if (err) { dev_err(dev, "Failed to connect hub (%d)\n", err); -- 2.21.0