From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/6] usb: hub:Extend usb_hub_clear_tt_buffer parameter From: Greg Kroah-Hartman Message-Id: <20190427065823.GC28250@kroah.com> Date: Sat, 27 Apr 2019 08:58:23 +0200 To: Jim Lin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gRnJpLCBBcHIgMjYsIDIwMTkgYXQgMTA6NTA6MDZQTSArMDgwMCwgSmltIExpbiB3cm90ZToK PiBFeHRlbmQgdXNiX2h1Yl9jbGVhcl90dF9idWZmZXIgcGFyYW1ldGVyIHRvIHNwZWNpZnkgZGV2 aWNlIG51bWJlcgo+IHRoYXQgd2lsbCBoYXZlIHRoZSBUVCBzdGF0ZSBvZiBpdHMgaHViIGNsZWFy ZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmltIExpbiA8amlsaW5AbnZpZGlhLmNvbT4KPiAtLS0K PiAgZHJpdmVycy91c2IvY29yZS9odWIuYyAgfCA1ICsrKy0tCj4gIGluY2x1ZGUvbGludXgvdXNi L2hjZC5oIHwgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY29yZS9odWIuYyBiL2RyaXZl cnMvdXNiL2NvcmUvaHViLmMKPiBpbmRleCAxNWEyOTM0ZGMyOWQuLjRkZWMwNTRjOTc3NiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9jb3JlL2h1Yi5jCj4gKysrIGIvZHJpdmVycy91c2IvY29y ZS9odWIuYwo+IEBAIC04NDAsNiArODQwLDcgQEAgaW50IHVzYl9odWJfc2V0X3BvcnRfcG93ZXIo c3RydWN0IHVzYl9kZXZpY2UgKmhkZXYsIHN0cnVjdCB1c2JfaHViICpodWIsCj4gIC8qKgo+ICAg KiB1c2JfaHViX2NsZWFyX3R0X2J1ZmZlciAtIGNsZWFyIGNvbnRyb2wvYnVsayBUVCBzdGF0ZSBp biBoaWdoIHNwZWVkIGh1Ygo+ICAgKiBAdXJiOiBhbiBVUkIgYXNzb2NpYXRlZCB3aXRoIHRoZSBm YWlsZWQgb3IgaW5jb21wbGV0ZSBzcGxpdCB0cmFuc2FjdGlvbgo+ICsgKiBAZGV2bnVtIDogZGV2 aWNlIG51bWJlciB0aGF0IHdpbGwgaGF2ZSB0aGUgVFQgc3RhdGUgb2YgaXRzIGh1YiBjbGVhcmVk Cj4gICAqCj4gICAqIEhpZ2ggc3BlZWQgSENEcyB1c2UgdGhpcyB0byB0ZWxsIHRoZSBodWIgZHJp dmVyIHRoYXQgc29tZSBzcGxpdCBjb250cm9sIG9yCj4gICAqIGJ1bGsgdHJhbnNhY3Rpb24gZmFp bGVkIGluIGEgd2F5IHRoYXQgcmVxdWlyZXMgY2xlYXJpbmcgaW50ZXJuYWwgc3RhdGUgb2YKPiBA QCAtODUxLDcgKzg1Miw3IEBAIGludCB1c2JfaHViX3NldF9wb3J0X3Bvd2VyKHN0cnVjdCB1c2Jf ZGV2aWNlICpoZGV2LCBzdHJ1Y3QgdXNiX2h1YiAqaHViLAo+ICAgKgo+ICAgKiBSZXR1cm46IDAg aWYgc3VjY2Vzc2Z1bC4gQSBuZWdhdGl2ZSBlcnJvciBjb2RlIG90aGVyd2lzZS4KPiAgICovCj4g LWludCB1c2JfaHViX2NsZWFyX3R0X2J1ZmZlcihzdHJ1Y3QgdXJiICp1cmIpCj4gK2ludCB1c2Jf aHViX2NsZWFyX3R0X2J1ZmZlcihzdHJ1Y3QgdXJiICp1cmIsIGludCBkZXZudW0pCj4gIHsKPiAg CXN0cnVjdCB1c2JfZGV2aWNlCSp1ZGV2ID0gdXJiLT5kZXY7Cj4gIAlpbnQJCQlwaXBlID0gdXJi LT5waXBlOwo+IEBAIC04NzMsNyArODc0LDcgQEAgaW50IHVzYl9odWJfY2xlYXJfdHRfYnVmZmVy KHN0cnVjdCB1cmIgKnVyYikKPiAgCS8qIGluZm8gdGhhdCBDTEVBUl9UVF9CVUZGRVIgbmVlZHMg Ki8KPiAgCWNsZWFyLT50dCA9IHR0LT5tdWx0aSA/IHVkZXYtPnR0cG9ydCA6IDE7Cj4gIAljbGVh ci0+ZGV2aW5mbyA9IHVzYl9waXBlZW5kcG9pbnQgKHBpcGUpOwo+IC0JY2xlYXItPmRldmluZm8g fD0gdWRldi0+ZGV2bnVtIDw8IDQ7Cj4gKwljbGVhci0+ZGV2aW5mbyB8PSBkZXZudW0gPDwgNDsK PiAgCWNsZWFyLT5kZXZpbmZvIHw9IHVzYl9waXBlY29udHJvbChwaXBlKQo+ICAJCQk/IChVU0Jf RU5EUE9JTlRfWEZFUl9DT05UUk9MIDw8IDExKQo+ICAJCQk6IChVU0JfRU5EUE9JTlRfWEZFUl9C VUxLIDw8IDExKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC91c2IvaGNkLmggYi9pbmNs dWRlL2xpbnV4L3VzYi9oY2QuaAo+IGluZGV4IDY5NTkzMWIwMzY4NC4uMDE3MjBmMWY3ZDYyIDEw MDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvdXNiL2hjZC5oCj4gKysrIGIvaW5jbHVkZS9saW51 eC91c2IvaGNkLmgKPiBAQCAtNTU5LDcgKzU1OSw3IEBAIHN0cnVjdCB1c2JfdHRfY2xlYXIgewo+ ICAJc3RydWN0IHVzYl9ob3N0X2VuZHBvaW50CSplcDsKPiAgfTsKPiAgCj4gLWV4dGVybiBpbnQg dXNiX2h1Yl9jbGVhcl90dF9idWZmZXIoc3RydWN0IHVyYiAqdXJiKTsKPiArZXh0ZXJuIGludCB1 c2JfaHViX2NsZWFyX3R0X2J1ZmZlcihzdHJ1Y3QgdXJiICp1cmIsIGludCBkZXZudW0pOwo+ICBl eHRlcm4gdm9pZCB1c2JfZXAwX3JlaW5pdChzdHJ1Y3QgdXNiX2RldmljZSAqKTsKPiAgCj4gIC8q IChzaGlmdGVkKSBkaXJlY3Rpb24vdHlwZS9yZWNpcGllbnQgZnJvbSB0aGUgVVNCIDIuMCBzcGVj LCB0YWJsZSA5LjIgKi8KPiAtLSAKPiAyLjEuNAoKWW91IGp1c3QgYnJva2UgdGhlIGJ1aWxkIHdp dGggdGhpcyBwYXRjaC4gIE5vIGluZGl2aWR1YWwgcGF0Y2ggY2FuIGV2ZXIKZG8gdGhhdCwgdGhl eSBhbGwgaGF2ZSB0byBiZSBzdGFuZC1hbG9uZS4KCkFsc28sIHdoZW4geW91IHNlbmQgYSBwYXRj aCBzZXJpZXMsIHBsZWFzZSBtYWtlIGl0IHN1Y2ggdGhhdCB0aGV5IGFyZQoibGlua2VkIiB0b2dl dGhlci4gIGdpdCBzZW5kLWVtYWlsIGRvZXMgdGhpcyBhdXRvbWF0aWNhbGx5LCBJIGRvbid0IGtu b3cKaG93IHlvdSBzZW50IHRoZXNlLCBidXQgaXQgZGlkIG5vdCB3b3JrIHRoYXQgd2F5IDooCgpB bHNvLCBhbHdheXMgdXNlIHNjcmlwdHMvZ2V0X21haW50YWluZXIucGwgdG8gZGV0ZXJtaW5lIHdo byB0byBzZW5kIHRoZQpwYXRjaGVzIHRvLiAgWW91IG1pc3NlZCBhbGwgb2YgdGhlIG1haW50YWlu ZXJzIGFuZCBkZXZlbG9wZXJzIHdobyBuZWVkCnRvIHJldmlldyB5b3VyIHBhdGNoZXMgOigKCnNv cnJ5LAoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E45C43218 for ; Sat, 27 Apr 2019 06:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 120CF2077B for ; Sat, 27 Apr 2019 06:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556348312; bh=yfBMiPcLMy+O1uEvfH/c7VJUQlhkmumHM2EmB6C/bXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pIUDu9XaYZyVQ8qaZbxHUOa4DVg2TAk24YnkPnkDjavsyDSRS0IE33JGUUGcC9H2N vnZ2FDZtkY/mYsdcag87+PttdMAFes3VcHo/m60PNdKkoiF0KZ/wJRzZTlSRgu0FvN 9ikZLbt3HD8qgcYinDb/iNFVqNZLRMr1DUXJvwYA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726049AbfD0G61 (ORCPT ); Sat, 27 Apr 2019 02:58:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:48148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfD0G61 (ORCPT ); Sat, 27 Apr 2019 02:58:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EF122077B; Sat, 27 Apr 2019 06:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556348306; bh=yfBMiPcLMy+O1uEvfH/c7VJUQlhkmumHM2EmB6C/bXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDLDF9e7hF/cpX2j78ECujCKlaXxrfIox15ycN2/Unb67ptThnoRWFzzGnwO2fnEh O3I8pEUYRMOK81Y0X+gxIIK52TDIg3y5HX9KPZL7EsVOup2quHCk6+0bWxH8qD1CxL qRV5zH5E4D4E+YASVyKgotfEgm0jOle1qC8QhOdU= Date: Sat, 27 Apr 2019 08:58:23 +0200 From: Greg KH To: Jim Lin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] usb: hub:Extend usb_hub_clear_tt_buffer parameter Message-ID: <20190427065823.GC28250@kroah.com> References: <1556290206-9393-1-git-send-email-jilin@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1556290206-9393-1-git-send-email-jilin@nvidia.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190427065823.3eJ_uMp-dkJvAdYDQS5AhLRHPanuNDzUVU8xG-cXIz4@z> On Fri, Apr 26, 2019 at 10:50:06PM +0800, Jim Lin wrote: > Extend usb_hub_clear_tt_buffer parameter to specify device number > that will have the TT state of its hub cleared. > > Signed-off-by: Jim Lin > --- > drivers/usb/core/hub.c | 5 +++-- > include/linux/usb/hcd.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 15a2934dc29d..4dec054c9776 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -840,6 +840,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, > /** > * usb_hub_clear_tt_buffer - clear control/bulk TT state in high speed hub > * @urb: an URB associated with the failed or incomplete split transaction > + * @devnum : device number that will have the TT state of its hub cleared > * > * High speed HCDs use this to tell the hub driver that some split control or > * bulk transaction failed in a way that requires clearing internal state of > @@ -851,7 +852,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, > * > * Return: 0 if successful. A negative error code otherwise. > */ > -int usb_hub_clear_tt_buffer(struct urb *urb) > +int usb_hub_clear_tt_buffer(struct urb *urb, int devnum) > { > struct usb_device *udev = urb->dev; > int pipe = urb->pipe; > @@ -873,7 +874,7 @@ int usb_hub_clear_tt_buffer(struct urb *urb) > /* info that CLEAR_TT_BUFFER needs */ > clear->tt = tt->multi ? udev->ttport : 1; > clear->devinfo = usb_pipeendpoint (pipe); > - clear->devinfo |= udev->devnum << 4; > + clear->devinfo |= devnum << 4; > clear->devinfo |= usb_pipecontrol(pipe) > ? (USB_ENDPOINT_XFER_CONTROL << 11) > : (USB_ENDPOINT_XFER_BULK << 11); > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index 695931b03684..01720f1f7d62 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -559,7 +559,7 @@ struct usb_tt_clear { > struct usb_host_endpoint *ep; > }; > > -extern int usb_hub_clear_tt_buffer(struct urb *urb); > +extern int usb_hub_clear_tt_buffer(struct urb *urb, int devnum); > extern void usb_ep0_reinit(struct usb_device *); > > /* (shifted) direction/type/recipient from the USB 2.0 spec, table 9.2 */ > -- > 2.1.4 You just broke the build with this patch. No individual patch can ever do that, they all have to be stand-alone. Also, when you send a patch series, please make it such that they are "linked" together. git send-email does this automatically, I don't know how you sent these, but it did not work that way :( Also, always use scripts/get_maintainer.pl to determine who to send the patches to. You missed all of the maintainers and developers who need to review your patches :( sorry, greg k-h