linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: USB: serial: drop unused iflag macro
Date: Sat, 27 Apr 2019 09:02:17 +0200	[thread overview]
Message-ID: <20190427070217.GF28250@kroah.com> (raw)

On Fri, Apr 26, 2019 at 08:01:32AM +0200, Johan Hovold wrote:
> Drop the RELEVANT_IFLAG() macro which essentially hasn't been used for
> over a decade except in some remnant debug printks that were recently
> removed.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  include/linux/usb/serial.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
> index 9d378826248b..1b631ea476ee 100644
> --- a/include/linux/usb/serial.h
> +++ b/include/linux/usb/serial.h
> @@ -23,9 +23,6 @@
>  /* The maximum number of ports one device can grab at once */
>  #define MAX_NUM_PORTS		16
>  
> -/* parity check flag */
> -#define RELEVANT_IFLAG(iflag)	(iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
> -
>  /* USB serial flags */
>  #define USB_SERIAL_WRITE_BUSY	0
>  #define USB_SERIAL_THROTTLED	1

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: drop unused iflag macro
Date: Sat, 27 Apr 2019 09:02:17 +0200	[thread overview]
Message-ID: <20190427070217.GF28250@kroah.com> (raw)
Message-ID: <20190427070217.CITkEnNmUJsJ2aFAG1BrCvQfsmEZGanxICAZjDR5Z00@z> (raw)
In-Reply-To: <20190426060132.13584-1-johan@kernel.org>

On Fri, Apr 26, 2019 at 08:01:32AM +0200, Johan Hovold wrote:
> Drop the RELEVANT_IFLAG() macro which essentially hasn't been used for
> over a decade except in some remnant debug printks that were recently
> removed.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  include/linux/usb/serial.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
> index 9d378826248b..1b631ea476ee 100644
> --- a/include/linux/usb/serial.h
> +++ b/include/linux/usb/serial.h
> @@ -23,9 +23,6 @@
>  /* The maximum number of ports one device can grab at once */
>  #define MAX_NUM_PORTS		16
>  
> -/* parity check flag */
> -#define RELEVANT_IFLAG(iflag)	(iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
> -
>  /* USB serial flags */
>  #define USB_SERIAL_WRITE_BUSY	0
>  #define USB_SERIAL_THROTTLED	1

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

         reply	other threads:[~2019-04-27  7:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26  6:01 USB: serial: drop unused iflag macro Johan Hovold
2019-04-26  6:01 ` [PATCH] " Johan Hovold
2019-04-27  7:02 ` Greg KH [this message]
2019-04-27  7:02   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190427070217.GF28250@kroah.com \
    --to=greg@kroah.com \
    --cc=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).