From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [5/7] usb: musb: jz4740: Let the platform probe the PHY From: Bin Liu Message-Id: <20190430145942.1128-6-b-liu@ti.com> Date: Tue, 30 Apr 2019 09:59:39 -0500 To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Bin Liu List-ID: RnJvbTogUGF1bCBDZXJjdWVpbCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+CgpCeSByZWdpc3Rlcmlu ZyBhIGdlbmVyaWMgVVNCIFBIWSBmcm9tIHdpdGhpbiB0aGUgZHJpdmVyLCB3ZSBtYXkgc2hhZG93 CnRoZSBVU0IgUEhZIHJlZ2lzdGVyZWQgYnkgdGhlIHBsYXRmb3JtLCB3aGljaCBtaWdodCBiZSBk aWZmZXJlbnQuCgpTaWduZWQtb2ZmLWJ5OiBQYXVsIENlcmN1ZWlsIDxwYXVsQGNyYXBvdWlsbG91 Lm5ldD4KU2lnbmVkLW9mZi1ieTogQmluIExpdSA8Yi1saXVAdGkuY29tPgotLS0KIGRyaXZlcnMv dXNiL211c2Ivano0NzQwLmMgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9tdXNiL2p6NDc0MC5jIGIvZHJpdmVycy91c2IvbXVz Yi9qejQ3NDAuYwppbmRleCBhNjA2MjdiZjdiZTMuLmFkMzVlMDlmOTBiZCAxMDA2NDQKLS0tIGEv ZHJpdmVycy91c2IvbXVzYi9qejQ3NDAuYworKysgYi9kcml2ZXJzL3VzYi9tdXNiL2p6NDc0MC5j CkBAIC03NCw3ICs3NCw2IEBAIHN0YXRpYyBzdHJ1Y3QgbXVzYl9oZHJjX3BsYXRmb3JtX2RhdGEg ano0NzQwX211c2JfcGxhdGZvcm1fZGF0YSA9IHsKIAogc3RhdGljIGludCBqejQ3NDBfbXVzYl9p bml0KHN0cnVjdCBtdXNiICptdXNiKQogewotCXVzYl9waHlfZ2VuZXJpY19yZWdpc3RlcigpOwog CW11c2ItPnhjZWl2ID0gdXNiX2dldF9waHkoVVNCX1BIWV9UWVBFX1VTQjIpOwogCWlmIChJU19F UlIobXVzYi0+eGNlaXYpKSB7CiAJCXByX2VycigiSFMgVURDOiBubyB0cmFuc2NlaXZlciBjb25m aWd1cmVkXG4iKTsKQEAgLTE4Myw3ICsxODIsNiBAQCBzdGF0aWMgaW50IGp6NDc0MF9yZW1vdmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlzdHJ1Y3Qgano0NzQwX2dsdWUJKmdsdWUg PSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKIAogCXBsYXRmb3JtX2RldmljZV91bnJlZ2lz dGVyKGdsdWUtPm11c2IpOwotCXVzYl9waHlfZ2VuZXJpY191bnJlZ2lzdGVyKHBkZXYpOwogCWNs a19kaXNhYmxlX3VucHJlcGFyZShnbHVlLT5jbGspOwogCiAJcmV0dXJuIDA7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8295C43219 for ; Tue, 30 Apr 2019 14:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B1D620652 for ; Tue, 30 Apr 2019 14:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yXaMQw2M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbfD3O7p (ORCPT ); Tue, 30 Apr 2019 10:59:45 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36736 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfD3O7o (ORCPT ); Tue, 30 Apr 2019 10:59:44 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3UExhZd103370; Tue, 30 Apr 2019 09:59:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556636383; bh=TKwqF1mn5UZq6Ne7irRh1Ifzitv+7iEKMhnWYsCLUI4=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=yXaMQw2MswpLddt6NmjmNitBTfRVuggg3X3FintZGBzhH7q2mi2GhTfiXpD8djb8j dTuQFb9iKJQD90TIuobnL8CsRCImaPrg94KwDN5rLhWhaHtBde/xrDXPXthqAtgFsM 8DwZzjJYh0RcffrQKSeUAxUmikY3ZXC5YqoHcsg8= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3UExhqv045784 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Apr 2019 09:59:43 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 30 Apr 2019 09:59:42 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 30 Apr 2019 09:59:42 -0500 Received: from uda0271908.am.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3UExgrF071248; Tue, 30 Apr 2019 09:59:42 -0500 From: Bin Liu To: Greg Kroah-Hartman CC: , Bin Liu Subject: [PATCH 5/7] usb: musb: jz4740: Let the platform probe the PHY Date: Tue, 30 Apr 2019 09:59:39 -0500 Message-ID: <20190430145942.1128-6-b-liu@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190430145942.1128-1-b-liu@ti.com> References: <20190430145942.1128-1-b-liu@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190430145939.fyHKJ5Kbb-V24hGclpEImRu3vVNWTFiVVDRTI94X2dI@z> From: Paul Cercueil By registering a generic USB PHY from within the driver, we may shadow the USB PHY registered by the platform, which might be different. Signed-off-by: Paul Cercueil Signed-off-by: Bin Liu --- drivers/usb/musb/jz4740.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c index a60627bf7be3..ad35e09f90bd 100644 --- a/drivers/usb/musb/jz4740.c +++ b/drivers/usb/musb/jz4740.c @@ -74,7 +74,6 @@ static struct musb_hdrc_platform_data jz4740_musb_platform_data = { static int jz4740_musb_init(struct musb *musb) { - usb_phy_generic_register(); musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR(musb->xceiv)) { pr_err("HS UDC: no transceiver configured\n"); @@ -183,7 +182,6 @@ static int jz4740_remove(struct platform_device *pdev) struct jz4740_glue *glue = platform_get_drvdata(pdev); platform_device_unregister(glue->musb); - usb_phy_generic_unregister(pdev); clk_disable_unprepare(glue->clk); return 0; -- 2.17.1