From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: musb: Disable pullup in gadget setup From: Bin Liu Message-Id: <20190430150506.GF20993@uda0271908> Date: Tue, 30 Apr 2019 10:05:06 -0500 To: Paul Cercueil , od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: SGkgUGF1bCwKCk9uIFRodSwgQXByIDA0LCAyMDE5IGF0IDExOjEwOjQ2QU0gLTA1MDAsIEJpbiBM aXUgd3JvdGU6Cj4gT24gVGh1LCBBcHIgMDQsIDIwMTkgYXQgMTE6Mzc6NDNBTSArMDIwMCwgUGF1 bCBDZXJjdWVpbCB3cm90ZToKPiA+IFRoZSBwdWxsdXAgbWF5IGJlIGFscmVhZHkgZW5hYmxlZCBi ZWZvcmUgdGhlIGRyaXZlciBpcyBpbml0aWFsaXplZC4KPiA+IEl0IGhhcyB0byBiZSBkaXNhYmxl ZCBhdCBpbml0IHRpbWUsIGFzIHdlIGNhbm5vdCBndWFyYW50ZWUgdGhhdCBhIGdhZGdldAo+ID4g ZHJpdmVyIHdpbGwgYmUgYm91bmQgdG8gdGhlIFVEQy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog UGF1bCBDZXJjdWVpbCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L3VzYi9tdXNiL211c2JfZ2FkZ2V0LmMgfCAxICsKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL211c2IvbXVzYl9nYWRn ZXQuYyBiL2RyaXZlcnMvdXNiL211c2IvbXVzYl9nYWRnZXQuYwo+ID4gaW5kZXggZmZlNDYyYTY1 N2IxLi4wOTRkYzU5YzgzNGMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9tdXNiL211c2Jf Z2FkZ2V0LmMKPiA+ICsrKyBiL2RyaXZlcnMvdXNiL211c2IvbXVzYl9nYWRnZXQuYwo+ID4gQEAg LTE3OTQsNiArMTc5NCw3IEBAIGludCBtdXNiX2dhZGdldF9zZXR1cChzdHJ1Y3QgbXVzYiAqbXVz YikKPiA+ICAKPiA+ICAJbXVzYi0+aXNfYWN0aXZlID0gMDsKPiA+ICAJbXVzYl9wbGF0Zm9ybV90 cnlfaWRsZShtdXNiLCAwKTsKPiA+ICsJbXVzYl9wdWxsdXAobXVzYiwgMCk7Cj4gPiAgCj4gPiAg CXN0YXR1cyA9IHVzYl9hZGRfZ2FkZ2V0X3VkYyhtdXNiLT5jb250cm9sbGVyLCAmbXVzYi0+Zyk7 Cj4gPiAgCWlmIChzdGF0dXMpCj4gCj4gQXBwbGllZC4KClNvcnJ5LCBJIGhhdmUgZHJvcHBlZCB0 aGlzIHBhdGNoIGZyb20gbXkgdHJlZS4gSSByZWFsaXplZCB0aGUgZ2FkZ2V0CmNvcmUgYWxyZWFk eSBkZWZpbmVzIGNhbGxiYWNrcyB0byBjb250cm9sIHRoZSBwdWxsdXAuIEkgdGhpbmsgdGhlCnBy b3BlciBmaXggc2hvdWxkIGJlIGNhbGxpbmcgdXNiX3VkY192YnVzX2hhbmRsZXIoKSBpbiBtdXNi IGdhZGdldCBvcgpnbHVlIGxheWVycy4KCi1CaW4uCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697B1C43219 for ; Tue, 30 Apr 2019 15:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DBCE20652 for ; Tue, 30 Apr 2019 15:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fVri6ote" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726053AbfD3PFO (ORCPT ); Tue, 30 Apr 2019 11:05:14 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:34244 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfD3PFO (ORCPT ); Tue, 30 Apr 2019 11:05:14 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3UF569i081840; Tue, 30 Apr 2019 10:05:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556636706; bh=vJWhXu0Jh+0tJ1eUhYoAiRXv//TbW/dkbRln1sv+k38=; h=Date:From:To:Subject:References:In-Reply-To; b=fVri6otet+nmdKkNhrUye+Xminen0sb6NvsbH3YMsiuazjD32ZVfL4ozmZDgULhqA 5BoL6Sj0HumfCfkVvQpwTqmb9EnX/4MHT5zbx9wMaMO1t8SsRZCUQTVdQzK5/XEkDT v9kkCO2oJKFtRPiOMNy0Rt+Q75HiitC1rNRInNhY= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3UF56Jx052350 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Apr 2019 10:05:06 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 30 Apr 2019 10:05:06 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 30 Apr 2019 10:05:06 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3UF56j1078783; Tue, 30 Apr 2019 10:05:06 -0500 Date: Tue, 30 Apr 2019 10:05:06 -0500 From: Bin Liu To: Paul Cercueil , , , Subject: Re: [PATCH] usb: musb: Disable pullup in gadget setup Message-ID: <20190430150506.GF20993@uda0271908> Mail-Followup-To: Bin Liu , Paul Cercueil , od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190404093743.6470-1-paul@crapouillou.net> <20190404161046.GA30182@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190404161046.GA30182@uda0271908> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190430150506.B6xnZdNde07dzW5exx_I2_lX73Xw2FD3qBsAnkOpo5M@z> Hi Paul, On Thu, Apr 04, 2019 at 11:10:46AM -0500, Bin Liu wrote: > On Thu, Apr 04, 2019 at 11:37:43AM +0200, Paul Cercueil wrote: > > The pullup may be already enabled before the driver is initialized. > > It has to be disabled at init time, as we cannot guarantee that a gadget > > driver will be bound to the UDC. > > > > Signed-off-by: Paul Cercueil > > --- > > drivers/usb/musb/musb_gadget.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c > > index ffe462a657b1..094dc59c834c 100644 > > --- a/drivers/usb/musb/musb_gadget.c > > +++ b/drivers/usb/musb/musb_gadget.c > > @@ -1794,6 +1794,7 @@ int musb_gadget_setup(struct musb *musb) > > > > musb->is_active = 0; > > musb_platform_try_idle(musb, 0); > > + musb_pullup(musb, 0); > > > > status = usb_add_gadget_udc(musb->controller, &musb->g); > > if (status) > > Applied. Sorry, I have dropped this patch from my tree. I realized the gadget core already defines callbacks to control the pullup. I think the proper fix should be calling usb_udc_vbus_handler() in musb gadget or glue layers. -Bin.