From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] USB: serial: io_edgeport: mark expected switch fall-throughs From: "Gustavo A. R. Silva" Message-Id: <20190501213329.GA26972@embeddedor> Date: Wed, 1 May 2019 16:33:29 -0500 To: Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook List-ID: SW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBz d2l0Y2gKY2FzZXMgd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCgpUaGlz IHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZ3M6Cgpkcml2ZXJzL3VzYi9zZXJpYWwv aW9fZWRnZXBvcnQuYzogSW4gZnVuY3Rpb24g4oCYcHJvY2Vzc19yY3ZkX2RhdGHigJk6CmRyaXZl cnMvdXNiL3NlcmlhbC9pb19lZGdlcG9ydC5jOjE3NTA6Nzogd2FybmluZzogdGhpcyBzdGF0ZW1l bnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCiAgICBpZiAoYnVm ZmVyTGVuZ3RoID09IDApIHsKICAgICAgIF4KZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0 LmM6MTc1NTozOiBub3RlOiBoZXJlCiAgIGNhc2UgRVhQRUNUX0hEUjI6CiAgIF5+fn4KZHJpdmVy cy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6MTgxMDo4OiB3YXJuaW5nOiB0aGlzIHN0YXRlbWVu dCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJvdWdoPV0KICAgICBpZiAoYnVm ZmVyTGVuZ3RoID09IDApIHsKICAgICAgICBeCmRyaXZlcnMvdXNiL3NlcmlhbC9pb19lZGdlcG9y dC5jOjE4MTY6Mzogbm90ZTogaGVyZQogICBjYXNlIEVYUEVDVF9EQVRBOiAvKiBFeHBlY3QgZGF0 YSAqLwogICBefn5+CgpXYXJuaW5nIGxldmVsIDMgd2FzIHVzZWQ6IC1XaW1wbGljaXQtZmFsbHRo cm91Z2g9MwoKTm90aWNlIHRoYXQsIGluIHRoaXMgcGFydGljdWxhciBjYXNlLCB0aGUgY29kZSBj b21tZW50cyBhcmUgbW9kaWZpZWQKaW4gYWNjb3JkYW5jZSB3aXRoIHdoYXQgR0NDIGlzIGV4cGVj dGluZyB0byBmaW5kLgoKVGhpcyBwYXRjaCBpcyBwYXJ0IG9mIHRoZSBvbmdvaW5nIGVmZm9ydHMg dG8gZW5hYmxlCi1XaW1wbGljaXQtZmFsbHRocm91Z2guCgpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZv IEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgotLS0KQ2hhbmdlcyBpbiB2MjoK IC0gV2FybmluZyBsZXZlbCAzIGlzIG5vdyB1c2VkOiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoPTMK ICAgaW5zdGVhZCBvZiB3YXJuaW5nIGxldmVsIDIuCiAtIEFsbCB3YXJuaW5ncyBpbiB0aGUgc3dp dGNoIHN0YXRlbWVudCBhcmUgYWRkcmVzc2VkIG5vdy4KCk5vdGljZSB0aGF0IHRoZXNlIGFyZSB0 aGUgbGFzdCByZW1haW5pbmcgZmFsbC10aHJvdWdoIHdhcm5pbmdzCmluIHRoZSBVU0Igc3Vic3lz dGVtLiA6KQoKVGhhbmtzCi0tCkd1c3Rhdm8KCiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBv cnQuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMgYi9kcml2 ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYwppbmRleCA0Y2EzMWMwZTQxNzQuLjdhZDEwMzI4 ZjRlMiAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMKKysrIGIv ZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMKQEAgLTE3NTEsNyArMTc1MSw3IEBAIHN0 YXRpYyB2b2lkIHByb2Nlc3NfcmN2ZF9kYXRhKHN0cnVjdCBlZGdlcG9ydF9zZXJpYWwgKmVkZ2Vf c2VyaWFsLAogCQkJCWVkZ2Vfc2VyaWFsLT5yeFN0YXRlID0gRVhQRUNUX0hEUjI7CiAJCQkJYnJl YWs7CiAJCQl9Ci0JCQkvKiBvdGhlcndpc2UsIGRyb3Agb24gdGhyb3VnaCAqLworCQkJLyogRmFs bCB0aHJvdWdoIC0gb3RoZXJ3aXNlLCBkcm9wIG9uIHRocm91Z2ggKi8KIAkJY2FzZSBFWFBFQ1Rf SERSMjoKIAkJCWVkZ2Vfc2VyaWFsLT5yeEhlYWRlcjIgPSAqYnVmZmVyOwogCQkJKytidWZmZXI7 CkBAIC0xODEzLDYgKzE4MTMsNyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX3JjdmRfZGF0YShzdHJ1 Y3QgZWRnZXBvcnRfc2VyaWFsICplZGdlX3NlcmlhbCwKIAkJCQl9CiAJCQkJLyogRWxzZSwgZHJv cCB0aHJvdWdoICovCiAJCQl9CisJCQkvKiBGYWxsIHRocm91Z2ggKi8KIAkJY2FzZSBFWFBFQ1Rf REFUQTogLyogRXhwZWN0IGRhdGEgKi8KIAkJCWlmIChidWZmZXJMZW5ndGggPCBlZGdlX3Nlcmlh bC0+cnhCeXRlc1JlbWFpbmluZykgewogCQkJCXJ4TGVuID0gYnVmZmVyTGVuZ3RoOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713C2C43219 for ; Wed, 1 May 2019 21:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 440192089E for ; Wed, 1 May 2019 21:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbfEAV6E (ORCPT ); Wed, 1 May 2019 17:58:04 -0400 Received: from gateway30.websitewelcome.com ([192.185.196.18]:12883 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfEAV6E (ORCPT ); Wed, 1 May 2019 17:58:04 -0400 X-Greylist: delayed 1472 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 May 2019 17:58:03 EDT Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C91CC1561 for ; Wed, 1 May 2019 16:33:30 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Lwr4h8WjV2PzOLwr4hcLKx; Wed, 01 May 2019 16:33:30 -0500 X-Authority-Reason: nr=8 Received: from [189.250.119.203] (port=56366 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1hLwr3-004Of0-QI; Wed, 01 May 2019 16:33:29 -0500 Date: Wed, 1 May 2019 16:33:29 -0500 From: "Gustavo A. R. Silva" To: Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook Subject: [PATCH v2] USB: serial: io_edgeport: mark expected switch fall-throughs Message-ID: <20190501213329.GA26972@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.203 X-Source-L: No X-Exim-ID: 1hLwr3-004Of0-QI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.119.203]:56366 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190501213329.cEgM3-oh0HW9zgpNcmaB0O4FRseEw1DtzR-_Wni-4QY@z> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/usb/serial/io_edgeport.c: In function ‘process_rcvd_data’: drivers/usb/serial/io_edgeport.c:1750:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (bufferLength == 0) { ^ drivers/usb/serial/io_edgeport.c:1755:3: note: here case EXPECT_HDR2: ^~~~ drivers/usb/serial/io_edgeport.c:1810:8: warning: this statement may fall through [-Wimplicit-fallthrough=] if (bufferLength == 0) { ^ drivers/usb/serial/io_edgeport.c:1816:3: note: here case EXPECT_DATA: /* Expect data */ ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comments are modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Warning level 3 is now used: -Wimplicit-fallthrough=3 instead of warning level 2. - All warnings in the switch statement are addressed now. Notice that these are the last remaining fall-through warnings in the USB subsystem. :) Thanks -- Gustavo drivers/usb/serial/io_edgeport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c index 4ca31c0e4174..7ad10328f4e2 100644 --- a/drivers/usb/serial/io_edgeport.c +++ b/drivers/usb/serial/io_edgeport.c @@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, edge_serial->rxState = EXPECT_HDR2; break; } - /* otherwise, drop on through */ + /* Fall through - otherwise, drop on through */ case EXPECT_HDR2: edge_serial->rxHeader2 = *buffer; ++buffer; @@ -1813,6 +1813,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, } /* Else, drop through */ } + /* Fall through */ case EXPECT_DATA: /* Expect data */ if (bufferLength < edge_serial->rxBytesRemaining) { rxLen = bufferLength; -- 2.21.0