From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] USB: serial: io_edgeport: mark expected switch fall-throughs From: Johan Hovold Message-Id: <20190502102608.GS26546@localhost> Date: Thu, 2 May 2019 12:26:08 +0200 To: "Gustavo A. R. Silva" Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook List-ID: T24gV2VkLCBNYXkgMDEsIDIwMTkgYXQgMDQ6MzM6MjlQTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBJbiBwcmVwYXJhdGlvbiB0byBlbmFibGluZyAtV2ltcGxpY2l0LWZhbGx0 aHJvdWdoLCBtYXJrIHN3aXRjaAo+IGNhc2VzIHdoZXJlIHdlIGFyZSBleHBlY3RpbmcgdG8gZmFs bCB0aHJvdWdoLgo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoK PiAKPiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYzogSW4gZnVuY3Rpb24g4oCYcHJv Y2Vzc19yY3ZkX2RhdGHigJk6Cj4gZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6MTc1 MDo3OiB3YXJuaW5nOiB0aGlzIHN0YXRlbWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0 LWZhbGx0aHJvdWdoPV0KPiAgICAgaWYgKGJ1ZmZlckxlbmd0aCA9PSAwKSB7Cj4gICAgICAgIF4K PiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYzoxNzU1OjM6IG5vdGU6IGhlcmUKPiAg ICBjYXNlIEVYUEVDVF9IRFIyOgo+ICAgIF5+fn4KPiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRn ZXBvcnQuYzoxODEwOjg6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1heSBmYWxsIHRocm91Z2gg Wy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ICAgICAgaWYgKGJ1ZmZlckxlbmd0aCA9PSAwKSB7 Cj4gICAgICAgICBeCj4gZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6MTgxNjozOiBu b3RlOiBoZXJlCj4gICAgY2FzZSBFWFBFQ1RfREFUQTogLyogRXhwZWN0IGRhdGEgKi8KPiAgICBe fn5+Cj4gCj4gV2FybmluZyBsZXZlbCAzIHdhcyB1c2VkOiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdo PTMKPiAKPiBOb3RpY2UgdGhhdCwgaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UsIHRoZSBjb2RlIGNv bW1lbnRzIGFyZSBtb2RpZmllZAo+IGluIGFjY29yZGFuY2Ugd2l0aCB3aGF0IEdDQyBpcyBleHBl Y3RpbmcgdG8gZmluZC4KPiAKPiBUaGlzIHBhdGNoIGlzIHBhcnQgb2YgdGhlIG9uZ29pbmcgZWZm b3J0cyB0byBlbmFibGUKPiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+Cj4gLS0tCj4g Q2hhbmdlcyBpbiB2MjoKPiAgLSBXYXJuaW5nIGxldmVsIDMgaXMgbm93IHVzZWQ6IC1XaW1wbGlj aXQtZmFsbHRocm91Z2g9Mwo+ICAgIGluc3RlYWQgb2Ygd2FybmluZyBsZXZlbCAyLgo+ICAtIEFs bCB3YXJuaW5ncyBpbiB0aGUgc3dpdGNoIHN0YXRlbWVudCBhcmUgYWRkcmVzc2VkIG5vdy4KPiAK PiBOb3RpY2UgdGhhdCB0aGVzZSBhcmUgdGhlIGxhc3QgcmVtYWluaW5nIGZhbGwtdGhyb3VnaCB3 YXJuaW5ncwo+IGluIHRoZSBVU0Igc3Vic3lzdGVtLiA6KQoKPiAgZHJpdmVycy91c2Ivc2VyaWFs L2lvX2VkZ2Vwb3J0LmMgfCAzICsrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC9pb19l ZGdlcG9ydC5jIGIvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMKPiBpbmRleCA0Y2Ez MWMwZTQxNzQuLjdhZDEwMzI4ZjRlMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9zZXJpYWwv aW9fZWRnZXBvcnQuYwo+ICsrKyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9pb19lZGdlcG9ydC5jCj4g QEAgLTE3NTEsNyArMTc1MSw3IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfcmN2ZF9kYXRhKHN0cnVj dCBlZGdlcG9ydF9zZXJpYWwgKmVkZ2Vfc2VyaWFsLAo+ICAJCQkJZWRnZV9zZXJpYWwtPnJ4U3Rh dGUgPSBFWFBFQ1RfSERSMjsKPiAgCQkJCWJyZWFrOwo+ICAJCQl9Cj4gLQkJCS8qIG90aGVyd2lz ZSwgZHJvcCBvbiB0aHJvdWdoICovCj4gKwkJCS8qIEZhbGwgdGhyb3VnaCAtIG90aGVyd2lzZSwg ZHJvcCBvbiB0aHJvdWdoICovCj4gIAkJY2FzZSBFWFBFQ1RfSERSMjoKPiAgCQkJZWRnZV9zZXJp YWwtPnJ4SGVhZGVyMiA9ICpidWZmZXI7Cj4gIAkJCSsrYnVmZmVyOwo+IEBAIC0xODEzLDYgKzE4 MTMsNyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX3JjdmRfZGF0YShzdHJ1Y3QgZWRnZXBvcnRfc2Vy aWFsICplZGdlX3NlcmlhbCwKPiAgCQkJCX0KPiAgCQkJCS8qIEVsc2UsIGRyb3AgdGhyb3VnaCAq Lwo+ICAJCQl9Cj4gKwkJCS8qIEZhbGwgdGhyb3VnaCAqLwo+ICAJCWNhc2UgRVhQRUNUX0RBVEE6 IC8qIEV4cGVjdCBkYXRhICovCgpMb29rcyBsaWtlIHlvdSBmb3Jnb3QgdG8gdGFrZSB0aGUgb3Jp Z2luYWwgcmV2aWV3IGZlZWRiYWNrIHlvdSBnb3QgaW50bwphY2NvdW50OgoKCWh0dHBzOi8vbGtt bC5rZXJuZWwub3JnL3IvODdrMXpmNGsyNC5mc2ZAbWlyYWN1bGl4Lm1vcmsubm8KCkpvaGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6D7C43219 for ; Thu, 2 May 2019 10:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 799762133F for ; Thu, 2 May 2019 10:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556792763; bh=2zVXCERhoEhP203OeUU0UZWwpgbXOXZhQLrmdn8U0G0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cPDiS9ZgFiIzuSCLJ/SYlF8Bp1tksK61uYeTutr1pHuHtSE1cbq5Ie+q9hYcVY1Pz EbJa0xdFfv81LvnCd8QBqfOk9mKLvYu2DM+gSonYZnb0LONfY2aQ2LCJZZ5tm8oq7C c9bsx76rmNLhGEwIO1W6rdHeXWcK67AhU0d5Z354= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbfEBK0C (ORCPT ); Thu, 2 May 2019 06:26:02 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40625 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbfEBK0C (ORCPT ); Thu, 2 May 2019 06:26:02 -0400 Received: by mail-lf1-f68.google.com with SMTP id o16so1464876lfl.7; Thu, 02 May 2019 03:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=h2cWxngpT20ZMfG3eOK3pNNe/GlsC/KIDAQpK5RfIwg=; b=BIr6nPRwjadS7Rbnhlm4RxIdDabgyPyj7reDPc9MzQKBLxZLR9TAdhSKV6hLKxbiI5 Ind9JEz8+VJ83RW28e8TFjT9A1PiT0J2oq5uNap1S7pPuZ07iCB2plYtvYnoOULgfWzV ePX98uXaRKb4uGMk6PE3s324XkjuZRv0AYNVDbIVCfCrIeiBQFU4Pd4902LzrmF6mLU8 m63XgSvQd6IhqoZfMCockysxRgZGnO/zI9PCZA/d5x8ydApkv6R0DVmORW6E2cj3xyxK d3NbAiT2EMbHddOeEAexwxKjVdm75mJmo/1vXJ62Xe5rsNUGcegyp8wSuwZSrsFmcR1B qhng== X-Gm-Message-State: APjAAAXDuCQpnnUA/Za56EbgPI5ykxW4zjyFaSjvIWr91tLOUc6UV/q+ gCBMPv88TO37DsXoowNQs+4= X-Google-Smtp-Source: APXvYqyLVM37TMfk9L9nCPHALYb1CpY8WCN2mVZesSegxWseGQ5TVBvqvuoedXc67VIzvMAl7Pg7Wg== X-Received: by 2002:ac2:4465:: with SMTP id y5mr1550419lfl.82.1556792760262; Thu, 02 May 2019 03:26:00 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id k4sm5931777lja.18.2019.05.02.03.25.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 03:25:59 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hM8um-0004gG-I2; Thu, 02 May 2019 12:26:09 +0200 Date: Thu, 2 May 2019 12:26:08 +0200 From: Johan Hovold To: "Gustavo A. R. Silva" Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v2] USB: serial: io_edgeport: mark expected switch fall-throughs Message-ID: <20190502102608.GS26546@localhost> References: <20190501213329.GA26972@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190501213329.GA26972@embeddedor> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190502102608.WeMjK3NsA4hKOvlD3a_u5Ky0VllP70U0tzOEx7gB6kk@z> On Wed, May 01, 2019 at 04:33:29PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/usb/serial/io_edgeport.c: In function ‘process_rcvd_data’: > drivers/usb/serial/io_edgeport.c:1750:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (bufferLength == 0) { > ^ > drivers/usb/serial/io_edgeport.c:1755:3: note: here > case EXPECT_HDR2: > ^~~~ > drivers/usb/serial/io_edgeport.c:1810:8: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (bufferLength == 0) { > ^ > drivers/usb/serial/io_edgeport.c:1816:3: note: here > case EXPECT_DATA: /* Expect data */ > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comments are modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Warning level 3 is now used: -Wimplicit-fallthrough=3 > instead of warning level 2. > - All warnings in the switch statement are addressed now. > > Notice that these are the last remaining fall-through warnings > in the USB subsystem. :) > drivers/usb/serial/io_edgeport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c > index 4ca31c0e4174..7ad10328f4e2 100644 > --- a/drivers/usb/serial/io_edgeport.c > +++ b/drivers/usb/serial/io_edgeport.c > @@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > edge_serial->rxState = EXPECT_HDR2; > break; > } > - /* otherwise, drop on through */ > + /* Fall through - otherwise, drop on through */ > case EXPECT_HDR2: > edge_serial->rxHeader2 = *buffer; > ++buffer; > @@ -1813,6 +1813,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > } > /* Else, drop through */ > } > + /* Fall through */ > case EXPECT_DATA: /* Expect data */ Looks like you forgot to take the original review feedback you got into account: https://lkml.kernel.org/r/87k1zf4k24.fsf@miraculix.mork.no Johan