From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] USB: serial: io_edgeport: mark expected switch fall-throughs From: Greg Kroah-Hartman Message-Id: <20190502144041.GA17960@kroah.com> Date: Thu, 2 May 2019 16:40:41 +0200 To: "Gustavo A. R. Silva" Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook List-ID: T24gVGh1LCBNYXkgMDIsIDIwMTkgYXQgMDk6Mjg6MzdBTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiAKPiAKPiBPbiA1LzIvMTkgODo1NiBBTSwgSm9oYW4gSG92b2xkIHdyb3Rl Ogo+ID4gT24gVGh1LCBNYXkgMDIsIDIwMTkgYXQgMDg6MjI6MzBBTSAtMDUwMCwgR3VzdGF2byBB LiBSLiBTaWx2YSB3cm90ZToKPiA+Pgo+ID4+Cj4gPj4gT24gNS8yLzE5IDU6MjYgQU0sIEpvaGFu IEhvdm9sZCB3cm90ZToKPiA+Pj4gT24gV2VkLCBNYXkgMDEsIDIwMTkgYXQgMDQ6MzM6MjlQTSAt MDUwMCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKPiA+Pj4+IEluIHByZXBhcmF0aW9uIHRv IGVuYWJsaW5nIC1XaW1wbGljaXQtZmFsbHRocm91Z2gsIG1hcmsgc3dpdGNoCj4gPj4+PiBjYXNl cyB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5nIHRvIGZhbGwgdGhyb3VnaC4KPiA+Pj4+Cj4gPj4+PiBU aGlzIHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZ3M6Cj4gPj4+Pgo+ID4+Pj4gZHJp dmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6IEluIGZ1bmN0aW9uIOKAmHByb2Nlc3NfcmN2 ZF9kYXRh4oCZOgo+ID4+Pj4gZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6MTc1MDo3 OiB3YXJuaW5nOiB0aGlzIHN0YXRlbWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZh bGx0aHJvdWdoPV0KPiA+Pj4+ICAgICBpZiAoYnVmZmVyTGVuZ3RoID09IDApIHsKPiA+Pj4+ICAg ICAgICBeCj4gPj4+PiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYzoxNzU1OjM6IG5v dGU6IGhlcmUKPiA+Pj4+ICAgIGNhc2UgRVhQRUNUX0hEUjI6Cj4gPj4+PiAgICBefn5+Cj4gPj4+ PiBkcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYzoxODEwOjg6IHdhcm5pbmc6IHRoaXMg c3RhdGVtZW50IG1heSBmYWxsIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ID4+ Pj4gICAgICBpZiAoYnVmZmVyTGVuZ3RoID09IDApIHsKPiA+Pj4+ICAgICAgICAgXgo+ID4+Pj4g ZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmM6MTgxNjozOiBub3RlOiBoZXJlCj4gPj4+ PiAgICBjYXNlIEVYUEVDVF9EQVRBOiAvKiBFeHBlY3QgZGF0YSAqLwo+ID4+Pj4gICAgXn5+fgo+ ID4+Pj4KPiA+Pj4+IFdhcm5pbmcgbGV2ZWwgMyB3YXMgdXNlZDogLVdpbXBsaWNpdC1mYWxsdGhy b3VnaD0zCj4gPj4+Pgo+ID4+Pj4gTm90aWNlIHRoYXQsIGluIHRoaXMgcGFydGljdWxhciBjYXNl LCB0aGUgY29kZSBjb21tZW50cyBhcmUgbW9kaWZpZWQKPiA+Pj4+IGluIGFjY29yZGFuY2Ugd2l0 aCB3aGF0IEdDQyBpcyBleHBlY3RpbmcgdG8gZmluZC4KPiA+Pj4+Cj4gPj4+PiBUaGlzIHBhdGNo IGlzIHBhcnQgb2YgdGhlIG9uZ29pbmcgZWZmb3J0cyB0byBlbmFibGUKPiA+Pj4+IC1XaW1wbGlj aXQtZmFsbHRocm91Z2guCj4gPj4+Pgo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBBLiBS LiBTaWx2YSA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gQ2hhbmdl cyBpbiB2MjoKPiA+Pj4+ICAtIFdhcm5pbmcgbGV2ZWwgMyBpcyBub3cgdXNlZDogLVdpbXBsaWNp dC1mYWxsdGhyb3VnaD0zCj4gPj4+PiAgICBpbnN0ZWFkIG9mIHdhcm5pbmcgbGV2ZWwgMi4KPiA+ Pj4+ICAtIEFsbCB3YXJuaW5ncyBpbiB0aGUgc3dpdGNoIHN0YXRlbWVudCBhcmUgYWRkcmVzc2Vk IG5vdy4KPiA+Pj4+Cj4gPj4+PiBOb3RpY2UgdGhhdCB0aGVzZSBhcmUgdGhlIGxhc3QgcmVtYWlu aW5nIGZhbGwtdGhyb3VnaCB3YXJuaW5ncwo+ID4+Pj4gaW4gdGhlIFVTQiBzdWJzeXN0ZW0uIDop Cj4gPj4+Cj4gPj4+PiAgZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMgfCAzICsrLQo+ ID4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ Pj4+Cj4gPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMg Yi9kcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYwo+ID4+Pj4gaW5kZXggNGNhMzFjMGU0 MTc0Li43YWQxMDMyOGY0ZTIgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL3VzYi9zZXJpYWwv aW9fZWRnZXBvcnQuYwo+ID4+Pj4gKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0 LmMKPiA+Pj4+IEBAIC0xNzUxLDcgKzE3NTEsNyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX3JjdmRf ZGF0YShzdHJ1Y3QgZWRnZXBvcnRfc2VyaWFsICplZGdlX3NlcmlhbCwKPiA+Pj4+ICAJCQkJZWRn ZV9zZXJpYWwtPnJ4U3RhdGUgPSBFWFBFQ1RfSERSMjsKPiA+Pj4+ICAJCQkJYnJlYWs7Cj4gPj4+ PiAgCQkJfQo+ID4+Pj4gLQkJCS8qIG90aGVyd2lzZSwgZHJvcCBvbiB0aHJvdWdoICovCj4gPj4+ PiArCQkJLyogRmFsbCB0aHJvdWdoIC0gb3RoZXJ3aXNlLCBkcm9wIG9uIHRocm91Z2ggKi8KPiA+ Pj4+ICAJCWNhc2UgRVhQRUNUX0hEUjI6Cj4gPj4+PiAgCQkJZWRnZV9zZXJpYWwtPnJ4SGVhZGVy MiA9ICpidWZmZXI7Cj4gPj4+PiAgCQkJKytidWZmZXI7Cj4gPj4+PiBAQCAtMTgxMyw2ICsxODEz LDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19yY3ZkX2RhdGEoc3RydWN0IGVkZ2Vwb3J0X3Nlcmlh bCAqZWRnZV9zZXJpYWwsCj4gPj4+PiAgCQkJCX0KPiA+Pj4+ICAJCQkJLyogRWxzZSwgZHJvcCB0 aHJvdWdoICovCj4gPj4+PiAgCQkJfQo+ID4+Pj4gKwkJCS8qIEZhbGwgdGhyb3VnaCAqLwo+ID4+ Pj4gIAkJY2FzZSBFWFBFQ1RfREFUQTogLyogRXhwZWN0IGRhdGEgKi8KPiA+Pj4KPiA+Pj4gTG9v a3MgbGlrZSB5b3UgZm9yZ290IHRvIHRha2UgdGhlIG9yaWdpbmFsIHJldmlldyBmZWVkYmFjayB5 b3UgZ290IGludG8KPiA+Pj4gYWNjb3VudDoKPiA+Pj4KPiA+Pj4gCWh0dHBzOi8vbGttbC5rZXJu ZWwub3JnL3IvODdrMXpmNGsyNC5mc2ZAbWlyYWN1bGl4Lm1vcmsubm8KPiA+Pj4KPiA+Pgo+ID4+ IE9oLCB0aGUgdGhpbmcgaXMgdGhhdCB0aGUgZmFsbC10aHJvdWdoIGNvbW1lbnRzIGhhdmUgdG8g YmUgcGxhY2VkIGF0Cj4gPj4gdGhlIHZlcnkgYm90dG9tIG9mIHRoZSBjYXNlLiBBbHNvLCBiYXNl ZCBvbiB0aGF0IGZlZWRiYWNrLCB0aGlzIHRpbWUKPiA+PiBJIGxlZnQgdGhlICJFbHNlLCBkcm9w IHRocm91Z2giIGNvbW1lbnQgaW4gcGxhY2UsIHNvIHBlb3BsZSBjYW4gYmUKPiA+PiBpbmZvcm1l ZCB0aGF0IHN1Y2ggZmFsbC10aHJvdWdoIGlzIGNvbmRpdGlvbmFsLgo+ID4+Cj4gPj4gV2hhdCBk byB5b3UgdGhpbmsgYWJvdXQgdGhpczoKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Vz Yi9zZXJpYWwvaW9fZWRnZXBvcnQuYyBiL2RyaXZlcnMvdXNiL3NlcmlhbC9pb19lZGdlcG9ydC5j Cj4gPj4gaW5kZXggNGNhMzFjMGU0MTc0Li41MmYyN2ZjODI1NjMgMTAwNjQ0Cj4gPj4gLS0tIGEv ZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMKPiA+PiArKysgYi9kcml2ZXJzL3VzYi9z ZXJpYWwvaW9fZWRnZXBvcnQuYwo+ID4+IEBAIC0xNzUxLDcgKzE3NTEsNyBAQCBzdGF0aWMgdm9p ZCBwcm9jZXNzX3JjdmRfZGF0YShzdHJ1Y3QgZWRnZXBvcnRfc2VyaWFsICplZGdlX3NlcmlhbCwK PiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVkZ2Vfc2VyaWFsLT5yeFN0YXRl ID0gRVhQRUNUX0hEUjI7Cj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVh azsKPiA+PiAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4gPj4gLSAgICAgICAgICAgICAgICAg ICAgICAgLyogb3RoZXJ3aXNlLCBkcm9wIG9uIHRocm91Z2ggKi8KPiA+PiArICAgICAgICAgICAg ICAgICAgICAgICAvKiBGYWxsIHRocm91Z2ggLSBvdGhlcndpc2UsIGRyb3Agb24gdGhyb3VnaCAq Lwo+ID4+ICAgICAgICAgICAgICAgICBjYXNlIEVYUEVDVF9IRFIyOgo+ID4+ICAgICAgICAgICAg ICAgICAgICAgICAgIGVkZ2Vfc2VyaWFsLT5yeEhlYWRlcjIgPSAqYnVmZmVyOwo+ID4+ICAgICAg ICAgICAgICAgICAgICAgICAgICsrYnVmZmVyOwo+ID4+IEBAIC0xODEzLDYgKzE4MTMsMTEgQEAg c3RhdGljIHZvaWQgcHJvY2Vzc19yY3ZkX2RhdGEoc3RydWN0IGVkZ2Vwb3J0X3NlcmlhbCAqZWRn ZV9zZXJpYWwsCj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4gPj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBFbHNlLCBkcm9wIHRocm91Z2ggKi8KPiA+ PiAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAg LyogQmV3YXJlIHRoYXQsIGN1cnJlbnRseSwgdGhlcmUgYXJlIGF0IGxlYXN0IHRocmVlCj4gPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICogYnJlYWsgc3RhdGVtZW50cyBpbiB0aGlzIGNhc2Ug YmxvY2ssIHNvIHRoZQo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAqIGZhbGwtdGhyb3Vn aCBtYXJrZWQgYmVsb3cgaXMgTk9UIHVuY29uZGl0aW9uYWwuCj4gPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICovCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgLyogRmFsbCB0aHJvdWdo ICovCj4gPj4gICAgICAgICAgICAgICAgIGNhc2UgRVhQRUNUX0RBVEE6IC8qIEV4cGVjdCBkYXRh ICovCj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGJ1ZmZlckxlbmd0aCA8IGVkZ2Vf c2VyaWFsLT5yeEJ5dGVzUmVtYWluaW5nKSB7Cj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICByeExlbiA9IGJ1ZmZlckxlbmd0aDsKPiA+IAo+ID4gSXQncyBiZXR0ZXIgdGhhbiB2 MiwgYnV0IEkgdGhvdWdodCB5b3Ugc2FpZCB5b3Ugd2VyZSBnb25uYSBsb29rIGludG8KPiA+IHJl c3RydWN0dXJpbmcgdGhlIGNvZGUgdG8gbWFpbnRhaW4gKG9yIGV2ZW4gaW1wcm92ZSkgcmVhZGFi aWxpdHk/Cj4gPiAKPiAKPiBBdCBmaXJzdCwgSSB0aG91Z2h0IGFib3V0IHRoYXQsIGJ1dCBub3cg SSBkb24ndCB0aGluayB0aGF0J3MgcmVhbGlzdGljLgo+IEknZCB0dXJuIHRoZSBpZi1lbHNlIGlu dG8gYSBzd2l0Y2gsIGFuZCBiYXNlZCBvbiB0aGUgaGlzdG9yeSBvZiBmZWVkYmFjawo+IG9uIHRo aXMgcGF0Y2gsIHdlIHdpbGwgZW5kIHVwIGhhdmluZyB0aGUgc2FtZSBjb21wbGFpbnMgYWJvdXQg dGhlIGJyZWFrCj4gc3RhdGVtZW50cyBpbiB0aGF0IG5ldyBzd2l0Y2ggYW5kIHRoZSBwb3NzaWJp bGl0eSBvZiBhIGZhbGwtdGhyb3VnaCB0bwo+IGNhc2UgRVhQRUNUX0RBVEEuIEF0IHRoZSBlbmQg SSB3b3VsZCBzdGlsbCBoYXZlIHRvIGFkZCBhIGNvbW1lbnQgZXhwbGFpbmluZwo+IHRoYXQgdGhl IGxhc3QgZmFsbC10aHJvdWdoIG1hcmsgaW4gdW5jb25kaXRpb25hbC4KCkkgbG92ZSBpdCBob3cg bm8gb25lIGlzIGJsYW1pbmcgdGhlIG9yaWdpbmFsIGF1dGhvciBvZiB0aGlzIGNvZGUgKGkuZS4K bWUuLi4pCgpMZXQgbWUgc2VlIGlmIEkgY2FuIGZpeCBpdCB1cCB0byBiZSBtb3JlICJzYW5lIiwg dGhpcyBpcyBteSBmYXVsdC4KCnRoYW5rcywKCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D895FC43219 for ; Thu, 2 May 2019 14:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D7CA2081C for ; Thu, 2 May 2019 14:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556808051; bh=M3HcnmT/YlpRlgbAK0FwiSYGMLiNx7ofKrlA3Zg06bI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wZ1SXWfDru9lUUIBUv3AJCkeVmvlXX8rg3RaG+mcDvFr607liWEPRNX8uBGyKHryn HDw91HL4m0CdUi8/Yqj8dzwUNuKe5cMXejGSV/uFZVm1Bm2DTXEHa9QmkoWC5ShY7z 7wA+0bxOAVDxfmgAOEYPXoPGguopxnYpJnPpfCDU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbfEBOkq (ORCPT ); Thu, 2 May 2019 10:40:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:53384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbfEBOkp (ORCPT ); Thu, 2 May 2019 10:40:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCB9D20656; Thu, 2 May 2019 14:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556808044; bh=M3HcnmT/YlpRlgbAK0FwiSYGMLiNx7ofKrlA3Zg06bI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DxWv+KUrP9W42B7OTL0jB3/R25+9rf0RRcTbaE52sZytmA1J/6kn2JfM1N+neZDbk G63b80r739UnvwB5BvMLu0kYrglqnWmmspshpb8lonHTvESE9OWLwpH+E30PqI8kjD 8A8ztpU/fUixvKvFyYa4UwnK8mPw2YfWhIk4bB70= Date: Thu, 2 May 2019 16:40:41 +0200 From: Greg Kroah-Hartman To: "Gustavo A. R. Silva" Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v2] USB: serial: io_edgeport: mark expected switch fall-throughs Message-ID: <20190502144041.GA17960@kroah.com> References: <20190501213329.GA26972@embeddedor> <20190502102608.GS26546@localhost> <20190502135636.GT26546@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190502144041.I66GgI6-d3ee0iASyVDcJCL6Jbajh1VoVP_BsXGIw2s@z> On Thu, May 02, 2019 at 09:28:37AM -0500, Gustavo A. R. Silva wrote: > > > On 5/2/19 8:56 AM, Johan Hovold wrote: > > On Thu, May 02, 2019 at 08:22:30AM -0500, Gustavo A. R. Silva wrote: > >> > >> > >> On 5/2/19 5:26 AM, Johan Hovold wrote: > >>> On Wed, May 01, 2019 at 04:33:29PM -0500, Gustavo A. R. Silva wrote: > >>>> In preparation to enabling -Wimplicit-fallthrough, mark switch > >>>> cases where we are expecting to fall through. > >>>> > >>>> This patch fixes the following warnings: > >>>> > >>>> drivers/usb/serial/io_edgeport.c: In function ‘process_rcvd_data’: > >>>> drivers/usb/serial/io_edgeport.c:1750:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > >>>> if (bufferLength == 0) { > >>>> ^ > >>>> drivers/usb/serial/io_edgeport.c:1755:3: note: here > >>>> case EXPECT_HDR2: > >>>> ^~~~ > >>>> drivers/usb/serial/io_edgeport.c:1810:8: warning: this statement may fall through [-Wimplicit-fallthrough=] > >>>> if (bufferLength == 0) { > >>>> ^ > >>>> drivers/usb/serial/io_edgeport.c:1816:3: note: here > >>>> case EXPECT_DATA: /* Expect data */ > >>>> ^~~~ > >>>> > >>>> Warning level 3 was used: -Wimplicit-fallthrough=3 > >>>> > >>>> Notice that, in this particular case, the code comments are modified > >>>> in accordance with what GCC is expecting to find. > >>>> > >>>> This patch is part of the ongoing efforts to enable > >>>> -Wimplicit-fallthrough. > >>>> > >>>> Signed-off-by: Gustavo A. R. Silva > >>>> --- > >>>> Changes in v2: > >>>> - Warning level 3 is now used: -Wimplicit-fallthrough=3 > >>>> instead of warning level 2. > >>>> - All warnings in the switch statement are addressed now. > >>>> > >>>> Notice that these are the last remaining fall-through warnings > >>>> in the USB subsystem. :) > >>> > >>>> drivers/usb/serial/io_edgeport.c | 3 ++- > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c > >>>> index 4ca31c0e4174..7ad10328f4e2 100644 > >>>> --- a/drivers/usb/serial/io_edgeport.c > >>>> +++ b/drivers/usb/serial/io_edgeport.c > >>>> @@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > >>>> edge_serial->rxState = EXPECT_HDR2; > >>>> break; > >>>> } > >>>> - /* otherwise, drop on through */ > >>>> + /* Fall through - otherwise, drop on through */ > >>>> case EXPECT_HDR2: > >>>> edge_serial->rxHeader2 = *buffer; > >>>> ++buffer; > >>>> @@ -1813,6 +1813,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > >>>> } > >>>> /* Else, drop through */ > >>>> } > >>>> + /* Fall through */ > >>>> case EXPECT_DATA: /* Expect data */ > >>> > >>> Looks like you forgot to take the original review feedback you got into > >>> account: > >>> > >>> https://lkml.kernel.org/r/87k1zf4k24.fsf@miraculix.mork.no > >>> > >> > >> Oh, the thing is that the fall-through comments have to be placed at > >> the very bottom of the case. Also, based on that feedback, this time > >> I left the "Else, drop through" comment in place, so people can be > >> informed that such fall-through is conditional. > >> > >> What do you think about this: > >> > >> diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c > >> index 4ca31c0e4174..52f27fc82563 100644 > >> --- a/drivers/usb/serial/io_edgeport.c > >> +++ b/drivers/usb/serial/io_edgeport.c > >> @@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > >> edge_serial->rxState = EXPECT_HDR2; > >> break; > >> } > >> - /* otherwise, drop on through */ > >> + /* Fall through - otherwise, drop on through */ > >> case EXPECT_HDR2: > >> edge_serial->rxHeader2 = *buffer; > >> ++buffer; > >> @@ -1813,6 +1813,11 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > >> } > >> /* Else, drop through */ > >> } > >> + /* Beware that, currently, there are at least three > >> + * break statements in this case block, so the > >> + * fall-through marked below is NOT unconditional. > >> + */ > >> + /* Fall through */ > >> case EXPECT_DATA: /* Expect data */ > >> if (bufferLength < edge_serial->rxBytesRemaining) { > >> rxLen = bufferLength; > > > > It's better than v2, but I thought you said you were gonna look into > > restructuring the code to maintain (or even improve) readability? > > > > At first, I thought about that, but now I don't think that's realistic. > I'd turn the if-else into a switch, and based on the history of feedback > on this patch, we will end up having the same complains about the break > statements in that new switch and the possibility of a fall-through to > case EXPECT_DATA. At the end I would still have to add a comment explaining > that the last fall-through mark in unconditional. I love it how no one is blaming the original author of this code (i.e. me...) Let me see if I can fix it up to be more "sane", this is my fault. thanks, greg k-h