From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: peter_hong@fintek.com.tw, johan@kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ji-Ze Hong \(Peter Hong\)" <hpeter+linux_kernel@gmail.com>
Subject: [V9,1/4] USB: serial: f81232: fix interrupt worker not stop
Date: Fri, 3 May 2019 08:53:53 +0200 [thread overview]
Message-ID: <20190503065353.GZ26546@localhost> (raw)
On Tue, Apr 30, 2019 at 09:22:29AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will use interrupt worker to handle MSR change.
> This patch will fix the issue that interrupt work should stop
> in close() and suspend().
>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> +static int f81232_resume(struct usb_serial *serial)
> +{
> + struct usb_serial_port *port = serial->port[0];
> + int result;
> +
> + if (tty_port_initialized(&port->port)) {
> + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO);
> + if (result) {
> + dev_err(&port->dev, "submit interrupt urb failed: %d",
> + result);
I added the missing '\n' to the error message.
> + return result;
> + }
> + }
> +
> + return usb_serial_generic_resume(serial);
> +}
This also fixes the issue with interrupt events not being received
after a suspend cycle, so I added that to the commit message.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: peter_hong@fintek.com.tw, johan@kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V9 1/4] USB: serial: f81232: fix interrupt worker not stop
Date: Fri, 3 May 2019 08:53:53 +0200 [thread overview]
Message-ID: <20190503065353.GZ26546@localhost> (raw)
Message-ID: <20190503065353.UOCC6Yt7TSPOhjEtzWaQpKxiWJD-bRqiAu8ZvVFqsLY@z> (raw)
In-Reply-To: <1556587352-19500-1-git-send-email-hpeter+linux_kernel@gmail.com>
On Tue, Apr 30, 2019 at 09:22:29AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will use interrupt worker to handle MSR change.
> This patch will fix the issue that interrupt work should stop
> in close() and suspend().
>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> +static int f81232_resume(struct usb_serial *serial)
> +{
> + struct usb_serial_port *port = serial->port[0];
> + int result;
> +
> + if (tty_port_initialized(&port->port)) {
> + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO);
> + if (result) {
> + dev_err(&port->dev, "submit interrupt urb failed: %d",
> + result);
I added the missing '\n' to the error message.
> + return result;
> + }
> + }
> +
> + return usb_serial_generic_resume(serial);
> +}
This also fixes the issue with interrupt events not being received
after a suspend cycle, so I added that to the commit message.
Johan
next prev reply other threads:[~2019-05-03 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 1:22 [V9,1/4] USB: serial: f81232: fix interrupt worker not stop Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 1/4] " Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [V9,2/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 2/4] " Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [V9,3/4] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 3/4] " Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [V9,4/4] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 4/4] " Ji-Ze Hong (Peter Hong)
2019-05-03 6:59 ` [V9,4/4] " Johan Hovold
2019-05-03 6:59 ` [PATCH V9 4/4] " Johan Hovold
2019-05-06 2:52 ` [V9,4/4] " Ji-Ze Hong (Peter Hong)
2019-05-06 2:52 ` [PATCH V9 4/4] " Ji-Ze Hong (Peter Hong)
2019-05-07 9:16 ` Johan Hovold
2019-05-03 6:53 ` Johan Hovold [this message]
2019-05-03 6:53 ` [PATCH V9 1/4] USB: serial: f81232: fix interrupt worker not stop Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503065353.GZ26546@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).