From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V9,1/4] USB: serial: f81232: fix interrupt worker not stop From: Johan Hovold Message-Id: <20190503065353.GZ26546@localhost> Date: Fri, 3 May 2019 08:53:53 +0200 To: "Ji-Ze Hong \(Peter Hong\)" Cc: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong \(Peter Hong\)" List-ID: T24gVHVlLCBBcHIgMzAsIDIwMTkgYXQgMDk6MjI6MjlBTSArMDgwMCwgSmktWmUgSG9uZyAoUGV0 ZXIgSG9uZykgd3JvdGU6Cj4gVGhlIEY4MTIzMiB3aWxsIHVzZSBpbnRlcnJ1cHQgd29ya2VyIHRv IGhhbmRsZSBNU1IgY2hhbmdlLgo+IFRoaXMgcGF0Y2ggd2lsbCBmaXggdGhlIGlzc3VlIHRoYXQg aW50ZXJydXB0IHdvcmsgc2hvdWxkIHN0b3AKPiBpbiBjbG9zZSgpIGFuZCBzdXNwZW5kKCkuCj4K PiBDYzogSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEpp LVplIEhvbmcgKFBldGVyIEhvbmcpIDxocGV0ZXIrbGludXhfa2VybmVsQGdtYWlsLmNvbT4KCj4g K3N0YXRpYyBpbnQgZjgxMjMyX3Jlc3VtZShzdHJ1Y3QgdXNiX3NlcmlhbCAqc2VyaWFsKQo+ICt7 Cj4gKwlzdHJ1Y3QgdXNiX3NlcmlhbF9wb3J0ICpwb3J0ID0gc2VyaWFsLT5wb3J0WzBdOwo+ICsJ aW50IHJlc3VsdDsKPiArCj4gKwlpZiAodHR5X3BvcnRfaW5pdGlhbGl6ZWQoJnBvcnQtPnBvcnQp KSB7Cj4gKwkJcmVzdWx0ID0gdXNiX3N1Ym1pdF91cmIocG9ydC0+aW50ZXJydXB0X2luX3VyYiwg R0ZQX05PSU8pOwo+ICsJCWlmIChyZXN1bHQpIHsKPiArCQkJZGV2X2VycigmcG9ydC0+ZGV2LCAi c3VibWl0IGludGVycnVwdCB1cmIgZmFpbGVkOiAlZCIsCj4gKwkJCQkJcmVzdWx0KTsKCkkgYWRk ZWQgdGhlIG1pc3NpbmcgJ1xuJyB0byB0aGUgZXJyb3IgbWVzc2FnZS4KCj4gKwkJCXJldHVybiBy ZXN1bHQ7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiB1c2Jfc2VyaWFsX2dlbmVyaWNfcmVz dW1lKHNlcmlhbCk7Cj4gK30KClRoaXMgYWxzbyBmaXhlcyB0aGUgaXNzdWUgd2l0aCBpbnRlcnJ1 cHQgZXZlbnRzIG5vdCBiZWluZyByZWNlaXZlZAphZnRlciBhIHN1c3BlbmQgY3ljbGUsIHNvIEkg YWRkZWQgdGhhdCB0byB0aGUgY29tbWl0IG1lc3NhZ2UuCgpKb2hhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26EA2C43219 for ; Fri, 3 May 2019 06:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EED0E205F4 for ; Fri, 3 May 2019 06:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556866449; bh=qdLbsL75bxVyXvBZPk3L9Y4WOSVzeQTxcRI6qqAKPgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QHj+3Pw6LedyQE8sw6VtZial6gl4cIWApj4gjgWra7Q2sUwLg6L6MIcmYek+q7ZwU 82BG+7q0qV/0wRuxgbF64LLIJ9VdWIPSP0oOCGlf2PsjwYk4UiTl2BrCb0CAvzkUFd 8URRfG8IaywDTQc2x64vq03XdlxjgPx8sgl7PqrQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfECGyD (ORCPT ); Fri, 3 May 2019 02:54:03 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:35491 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbfECGyD (ORCPT ); Fri, 3 May 2019 02:54:03 -0400 Received: by mail-lf1-f65.google.com with SMTP id j20so3671995lfh.2; Thu, 02 May 2019 23:54:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PNXQmunQu5QZmN64MuQdng2Hjr43+4G/NRvlRZwoeQI=; b=l+eoVW0mngw8oQfdjAoNMHfKXdUatmir2/ZJ57nbuk94xthj9q8u3Y7uV8bZd93g37 kmK6Tnwjlo1YY3u6XPdYTE8PCf+4UkHxSrIZPcEoEXKAt+rMv+T10LxtS6GmvaoSyP0F D0GFvNd5cn5EoBd0NTWUq6tM1SErBfBlxJFO/FkHcOfCBnCSy+UDrai4O4u3BqvOXaK4 cBQkDtAznNiKGIqQOXcmj5h16btLdO1UfAFmIHwavai2MYdmxXmBD8x4Ei5KJwN6DJw0 c6t8e4u1NBiRtb1+JZ9+YTOr4zmE+pa6lgyKp6KUp+gCFlLTPtCeXRSYzL6BtF2qqFpT PPZA== X-Gm-Message-State: APjAAAXtQHhMYBvvJKgXv6F3uxcxHipYGkrKVWJegKsqe25ylTiuKC5Z rSW/a72+A7KOO5UnJxjRM0+VacpY X-Google-Smtp-Source: APXvYqyCXcEZM9T7gI0iTiAPjhAohJGknGlYMP644Si1wPo4GWCfTnpIO3p4sHZzU/syRPan7AzkqA== X-Received: by 2002:a19:c216:: with SMTP id l22mr4026992lfc.112.1556866423356; Thu, 02 May 2019 23:53:43 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id g13sm202306lfh.49.2019.05.02.23.53.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 23:53:42 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hMS4v-0004Xf-U7; Fri, 03 May 2019 08:53:53 +0200 Date: Fri, 3 May 2019 08:53:53 +0200 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: peter_hong@fintek.com.tw, johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V9 1/4] USB: serial: f81232: fix interrupt worker not stop Message-ID: <20190503065353.GZ26546@localhost> References: <1556587352-19500-1-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1556587352-19500-1-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190503065353.UOCC6Yt7TSPOhjEtzWaQpKxiWJD-bRqiAu8ZvVFqsLY@z> On Tue, Apr 30, 2019 at 09:22:29AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81232 will use interrupt worker to handle MSR change. > This patch will fix the issue that interrupt work should stop > in close() and suspend(). > > Cc: Johan Hovold > Signed-off-by: Ji-Ze Hong (Peter Hong) > +static int f81232_resume(struct usb_serial *serial) > +{ > + struct usb_serial_port *port = serial->port[0]; > + int result; > + > + if (tty_port_initialized(&port->port)) { > + result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO); > + if (result) { > + dev_err(&port->dev, "submit interrupt urb failed: %d", > + result); I added the missing '\n' to the error message. > + return result; > + } > + } > + > + return usb_serial_generic_resume(serial); > +} This also fixes the issue with interrupt events not being received after a suspend cycle, so I added that to the commit message. Johan