From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN) From: Johan Hovold Message-Id: <20190503074113.GA17809@localhost> Date: Fri, 3 May 2019 09:41:13 +0200 To: Charles Yeh Cc: Johan Hovold , Greg KH , linux-usb@vger.kernel.org, =?utf-8?B?WWVoLkNoYXJsZXMgW+iRieamrumRq10=?= List-ID: T24gRnJpLCBNYXkgMDMsIDIwMTkgYXQgMDM6Mjg6MDRQTSArMDgwMCwgQ2hhcmxlcyBZZWggd3Jv dGU6Cj4gSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwub3JnPiDmlrwgMjAxOeW5tDXmnIgz5pel IOmAseS6lCDkuIvljYgzOjEx5a+r6YGT77yaCj4gPiBXaGF0IGNoYW5nZWQgaW4gdjI/IFlvdSBm b3Jnb3QgdG8gYWRkIGEgY2hhbmdlbG9nIGhlcmUuCj4gPgo+ID4gTG9va3MgbGlrZSB0aGlzIG9u ZSBpcyBub3QgYmFzZWQgb24gdGhlIGN1cnJlbnQgZHJpdmVyIGNvZGUgKGUuZy4gbXkKPiA+IHVz Yi1uZXh0IGJyYW5jaCBhcyB3ZSBkaXNjdXNzZWQpLCBhbmQgYWxzbyBkb2VzIG5vdCBhZGRyZXNz IHNvbWUgb2YgdGhlCj4gPiBpc3N1ZXMgcmFpc2VkIHNvIGZhciAoZS5nLiB5b3UncmUgb3Zlcndy aXRpbmcgdGhlIGVudGlyZSBmbG93IGNvbnRyb2wKPiA+IHJlZ2lzdGVyIG9uIHVwZGF0ZXMpLgo+ ID4KPiAKPiBJIHVzZWQgdGhlIEtlcm5lbCB0cmVlOgo+IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1 Yi9zY20vbGludXgva2VybmVsL2dpdC9qb2hhbi91c2Itc2VyaWFsLmdpdAo+IAo+IGJ1dCB0aGUg cGwyMzAzLmMgaW5zaWRlIGRvZXMgbm90IGhhdmUgdGhlICJwbDIzMDNfdXBkYXRlX3JlZyIgeW91 IG1lbnRpb25lZC4KClBlcmhhcHMgeW91IGRpZCBub3QgdXNlIHRoZSB1c2ItbmV4dCBicmFuY2g/ IFRoYXQgYnJhbmNoIGhhcyB0aGUgZm9sbG93aW5nCmNvbW1pdDoKCglodHRwczovL2dpdC5rZXJu ZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qb2hhbi91c2Itc2VyaWFsLmdpdC9jb21t aXQvP2g9dXNiLW5leHQmaWQ9ZjY0YzNhYjIzMDY4MmU4Mzk1YTdmYmQwMWYzZWI1MTQwYzgzN2Q0 ZQoKd2hpY2ggYWRkcyB0aGUgaGVscGVyLgoKSm9oYW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07AADC43219 for ; Fri, 3 May 2019 07:41:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE068205F4 for ; Fri, 3 May 2019 07:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556869264; bh=oyzae9MH5352fWHjm2SDbNx8O+ysdbxtlwNcpAx72hw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fGKGd0um2YyMO29iNiBttB2xcWopuuxgnxDIYPgzvZ+efppo9SRh1gC4XvaSlNc4k rO+0+TuoASqI+n2VyUUUHv290Fd8xyehxGx34MiuZS2O3scbHo52PoRZk45Z5J8cL3 a1iBjZZkYeJKS1/fNT+4StM6nb8rl5iMRaqJEfew= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbfECHlE (ORCPT ); Fri, 3 May 2019 03:41:04 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:39817 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfECHlD (ORCPT ); Fri, 3 May 2019 03:41:03 -0400 Received: by mail-lf1-f67.google.com with SMTP id d12so3742393lfk.6 for ; Fri, 03 May 2019 00:41:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HHQVaoB+B0C7wA8aFsCAz60Qpl4DJWp3V1XxQNCMyxk=; b=q+sPEgzhHe04Vc/wQl+BTpPK7iWb5iJiioJJMdvFAo9gstVht0mK7vQoT3r3Xft1CZ 4oieC2xL66drqmQ4AzlCQ6xh12SXUbIxdOAsZYJRVVlTsVYDmD5CV3avGH8wHcRB17bf XJdBSEZnBk48er9GePafXlAjmgLcpPnsrTJgYYjAPJk5QiFkqFAI+neI/WMMluLjaG10 5NvefTOkMDV9Ngq0bugwjYS0u7IppNQr04DxXq3vO2BJB1nRHc9cRQt9tBDEdwqL2AuN YlfhvuW9N2tST2lRpyJXSGiifclR5s7g7zGqvDSN1hq/jZZgHfP82m4XvLJAyluthpKJ rjKw== X-Gm-Message-State: APjAAAWVBJsghyQffUFHKqIUr7LrmoVILTkkhwQB8UMOXQiu1l71V/PU GdOo6qNYzdF7BYiPGUvJAkA= X-Google-Smtp-Source: APXvYqxixtPe+Ep48A3qg6HHaw1nKxCooV13GUMCgjP0sV/YWRXYQ86Csh1zkm/iuWcUZx1LfRDfRw== X-Received: by 2002:a19:e619:: with SMTP id d25mr3077847lfh.66.1556869262099; Fri, 03 May 2019 00:41:02 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id s26sm245283ljj.52.2019.05.03.00.41.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 May 2019 00:41:01 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hMSoj-0006Cx-JN; Fri, 03 May 2019 09:41:13 +0200 Date: Fri, 3 May 2019 09:41:13 +0200 From: Johan Hovold To: Charles Yeh Cc: Johan Hovold , Greg KH , linux-usb@vger.kernel.org, =?utf-8?B?WWVoLkNoYXJsZXMgW+iRieamrumRq10=?= Subject: Re: [PATCH] [PATCH v2] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN) Message-ID: <20190503074113.GA17809@localhost> References: <20190429121237.13136-1-charlesyeh522@gmail.com> <20190503071128.GB26546@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190503074113.5vXufdJsiyQLtfzXx1xGvlqkjsm9-9BFJ3scP6RxGf4@z> On Fri, May 03, 2019 at 03:28:04PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年5月3日 週五 下午3:11寫道： > > What changed in v2? You forgot to add a changelog here. > > > > Looks like this one is not based on the current driver code (e.g. my > > usb-next branch as we discussed), and also does not address some of the > > issues raised so far (e.g. you're overwriting the entire flow control > > register on updates). > > > > I used the Kernel tree: > git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git > > but the pl2303.c inside does not have the "pl2303_update_reg" you mentioned. Perhaps you did not use the usb-next branch? That branch has the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=f64c3ab230682e8395a7fbd01f3eb5140c837d4e which adds the helper. Johan