From: Greg KH <gregkh@linuxfoundation.org>
To: Nikolai Kondrashov <spbnick@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: merge usbhid-dump into usbutils repo?
Date: Tue, 7 May 2019 16:00:42 +0200 [thread overview]
Message-ID: <20190507140042.GA26528@kroah.com> (raw)
Hi Nikolai,
As you know, usbhid-dump has been part of the usbutils repo for a long
time, as a git submodule. And that's been fine, a bit messy at times
for when I forgot to update the submodule, but overall ok.
However, I've changed the way usbutils is being released (with the 011
release that I tagged yesterday, but did not announce anywhere).
Instead of a tarball generated on my "random desktop of the day" by
running 'make distcheck' on the tree, I wanted to rely on the kernel.org
infrastructure to do a "clean checkout" of the tree and make a tarball
just based on the git repo itself.
That way people can actually rely on what is in the tarball really is
what is in the git tree, and you don't end up running some random script
that my personal machine happened to create (not a good idea).
This is fine, except when it comes to the git submodule. kernel.org
can't be expected to pull some random submodule from a random location
into it's tree when signing things, as that would be a total mess.
So, I came up with two possible solutions:
1) remove usbhid-dump from usbutils.
2) move usbhid-dump into usbutils.
The first option is a bit sad, as some users of usbhid-dump might find
it go away and now all of the distros have to go and dig and find a new
package to add to their repos. You would also then be responsible for
doing releases and notifying everyone on your own, instead of having
that done for you like it is today.
The second option is in my opinion the best one. You can contribute
directly to the usbutils repo by providing patches/pull requests when
changes are needed. Given the slow-down in development of this package
over the years, I doubt much is left to do on it, so that shouldn't be a
big deal.
As a test-run, I've done a merge of the usbhid-dump repo into the
usbutils repo directly, by rewriting the directory location of the
usbhid-dump repo into usbhid-dump/ and then merging the two trees
together, such that no authorship or history is lost. You can see the
result of that here in the branch here:
https://github.com/gregkh/usbutils/tree/usbhid-dump-merge
That branch seems to work fine for me here, with everything building
properly.
Note, if we do go with the second option, I would like to look into
"simplifying" the usbhid-dump codebase a bit, moving away from a library
and loads of include files into something a bit simpler, as the
complexity of the build system here seems a bit of an overkill for a
"simple" binary.
So, what do you think about the two options here?
thanks,
greg k-h
next reply other threads:[~2019-05-07 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 14:00 Greg KH [this message]
2019-05-07 14:23 ` merge usbhid-dump into usbutils repo? Nikolai Kondrashov
2019-05-07 14:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507140042.GA26528@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).