From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1827C04A6B for ; Wed, 8 May 2019 06:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9167520989 for ; Wed, 8 May 2019 06:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557297446; bh=T0FrpxoRHBchoQt2g4MiY1olLJ9HjffT47QH8iMBIkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C2dHwhD4pOgFk3IsMN5d9NPklwELbhpyUnRZE50OVg2kFmaWYjH6PDj9RDonJhXT0 /jWLdCdmg+8RLXw1lX0ObJVh2IFsyv3P6rBHphB6Pp9l0jZ7sc2RO60F+DSSn+crqK ufSW56XCtDN7RuadmH0gGkSzPnk0hddaznV88G7s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726686AbfEHGh0 (ORCPT ); Wed, 8 May 2019 02:37:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:57444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfEHGhZ (ORCPT ); Wed, 8 May 2019 02:37:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC3E32054F; Wed, 8 May 2019 06:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557297445; bh=T0FrpxoRHBchoQt2g4MiY1olLJ9HjffT47QH8iMBIkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ek2LsxxVpZtrm8idGE2/+QUmm8gmMmawn3+cQfl8wpTQrSsfu8qxG31xPYY5D5Gc7 DBFU17xMcgPEq5sdQOyOV1vDjG+rUvBO5WUozXb6tEhx84Ql4BCgLvmfCdQJ4vqkb5 0dBIY6mB4mG4thokr9BGHrvXvq7uhzL4IVBgY24U= Date: Wed, 8 May 2019 08:37:23 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: "Angus Ainslie (Purism)" , angus.ainslie@puri.sm, Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] usb: typec: tcpci: Clear the fault status register Message-ID: <20190508063723.GA14085@kroah.com> References: <20190508002749.14816-1-angus@akkea.ca> <20190508002749.14816-2-angus@akkea.ca> <5f0bec69-9579-f153-c3fd-d7b8deea75c4@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f0bec69-9579-f153-c3fd-d7b8deea75c4@roeck-us.net> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, May 07, 2019 at 05:49:14PM -0700, Guenter Roeck wrote: > On 5/7/19 5:27 PM, Angus Ainslie (Purism) wrote: > > If the fault status register doesn't get cleared then > > the ptn5110 interrupt gets stuck on. As the fault register gets > > set everytime the ptn5110 powers on the interrupt is always stuck. > > > > Fixes: fault status register stuck > > That is not how Fixes: tags are supposed to work. This should probably be > > Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)") Nit: Fixes: 74e656d6b055 ("staging: typec: Type-C Port Controller Interface driver (tcpci)") You only need 12 characters of the sha1 :)