From: Wolfram Sang <wsa@the-dreams.de>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-i2c@vger.kernel.org, Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH 3/4] i2c: nvidia-gpu: resume ccgx i2c client
Date: Sun, 19 May 2019 16:48:44 +0200 [thread overview]
Message-ID: <20190519144844.GC7291@kunai> (raw)
In-Reply-To: <20190517163818.5007-4-ajayg@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
> + /* runtime resume ccgx client so that it can see for any
> + * connector change event. Old ccg firmware has known
> + * issue of not triggering interrupt when a device is
> + * connected to runtime resume the controller.
> + */
Check coding style for comments.
BTW how do you suggest this gets upstream? Through the usb-tree? Would
be fine with me. Are there any dependencies? The cover-letter doesn't
mention it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-19 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:38 [PATCH 0/4] usb: typec: ucsi: ccg: add runtime pm support Ajay Gupta
2019-05-17 16:38 ` [PATCH 1/4] i2c: nvidia-gpu: " Ajay Gupta
2019-05-19 14:47 ` Wolfram Sang
2019-05-20 17:02 ` Ajay Gupta
2019-05-20 17:17 ` Wolfram Sang
2019-05-17 16:38 ` [PATCH 2/4] usb: typec: ucsi: ccg: enable " Ajay Gupta
2019-05-17 16:38 ` [PATCH 3/4] i2c: nvidia-gpu: resume ccgx i2c client Ajay Gupta
2019-05-19 14:48 ` Wolfram Sang [this message]
2019-05-20 17:08 ` Ajay Gupta
2019-05-17 16:38 ` [PATCH 4/4] usb: typec: ucsi: ccg: add runtime pm workaround Ajay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519144844.GC7291@kunai \
--to=wsa@the-dreams.de \
--cc=ajayg@nvidia.com \
--cc=ajaykuee@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).