* TODO advice for octeon-usb?
@ 2019-05-20 23:05 Aaro Koskinen
2019-05-21 6:12 ` Felipe Balbi
2019-05-21 7:59 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Aaro Koskinen @ 2019-05-20 23:05 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-usb, devel
Hi,
I'm looking for input what should be done next to get
drivers/staging/octeon-usb out of staging.
Thousands of checkpatch errors/warnings have been fixed (starting point
was <https://marc.info/?l=linux-driver-devel&m=137028876225266&w=2>),
also the size of the driver has shrunken considerably.
If there are still some other bigger issues with this driver, please
let me know.
Thanks,
A.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TODO advice for octeon-usb?
2019-05-20 23:05 TODO advice for octeon-usb? Aaro Koskinen
@ 2019-05-21 6:12 ` Felipe Balbi
2019-05-21 7:59 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2019-05-21 6:12 UTC (permalink / raw)
To: Aaro Koskinen, Greg Kroah-Hartman; +Cc: linux-usb, devel
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
Hi,
Aaro Koskinen <aaro.koskinen@iki.fi> writes:
> I'm looking for input what should be done next to get
> drivers/staging/octeon-usb out of staging.
>
> Thousands of checkpatch errors/warnings have been fixed (starting point
> was <https://marc.info/?l=linux-driver-devel&m=137028876225266&w=2>),
> also the size of the driver has shrunken considerably.
>
> If there are still some other bigger issues with this driver, please
> let me know.
Looks pretty clean to me. I would simply break that single file into
smaller files if possible (see xhci/ehci for example).
my 2 cents
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TODO advice for octeon-usb?
2019-05-20 23:05 TODO advice for octeon-usb? Aaro Koskinen
2019-05-21 6:12 ` Felipe Balbi
@ 2019-05-21 7:59 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-21 7:59 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: linux-usb, devel
On Tue, May 21, 2019 at 02:05:32AM +0300, Aaro Koskinen wrote:
> Hi,
>
> I'm looking for input what should be done next to get
> drivers/staging/octeon-usb out of staging.
>
> Thousands of checkpatch errors/warnings have been fixed (starting point
> was <https://marc.info/?l=linux-driver-devel&m=137028876225266&w=2>),
> also the size of the driver has shrunken considerably.
>
> If there are still some other bigger issues with this driver, please
> let me know.
Submit it as a patch that just adds the files to the drivers/usb/host/
directory so we can review it on linux-usb@vger and if it gets accepted,
I can then drop it from the staging directory, or just move it over if
no changes are needed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-21 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 23:05 TODO advice for octeon-usb? Aaro Koskinen
2019-05-21 6:12 ` Felipe Balbi
2019-05-21 7:59 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).