From: "hch@lst.de" <hch@lst.de>
To: Fredrik Noring <noring@nocrew.org>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Robin Murphy <robin.murphy@arm.com>, "hch@lst.de" <hch@lst.de>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"marex@denx.de" <marex@denx.de>,
"JuergenUrban@gmx.de" <JuergenUrban@gmx.de>,
Leo Li <leoyang.li@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 0/3] prerequisites for device reserved local mem rework
Date: Tue, 21 May 2019 12:32:14 +0200 [thread overview]
Message-ID: <20190521103214.GB1973@lst.de> (raw)
In-Reply-To: <20190520154156.GA3664@sx9>
On Mon, May 20, 2019 at 05:41:56PM +0200, Fredrik Noring wrote:
> 2. A device address is supplied as phys_addr_t phys to gen_pool_add_virt().
> This seems to work in this particular DMA application, but there will be
> problems if someone does phys_to_virt() or suchlike. Can this be improved
> or clearly explained? gen_pool_virt_to_phys() searches in address ranges,
> for example, so it appears the implementation uses phys quite carefully.
Well, it is a physical address, but not one that has a kernel mapping.
So phys_addr_t seems right here, but an additional comment explaining it
is not in the kernel mapping never hurts.
prev parent reply other threads:[~2019-05-21 10:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:38 [RFC PATCH v2 0/3] prerequisites for device reserved local mem rework laurentiu.tudor
2019-05-14 14:38 ` [RFC PATCH v2 1/3] USB: use genalloc for USB HCs with local memory laurentiu.tudor
2019-05-14 14:42 ` Christoph Hellwig
2019-05-15 9:57 ` Laurentiu Tudor
2019-05-15 12:42 ` Christoph Hellwig
2019-05-14 14:38 ` [RFC PATCH v2 2/3] usb: host: ohci-sm501: init genalloc for " laurentiu.tudor
2019-05-14 14:38 ` [RFC PATCH v2 3/3] usb: host: ohci-tmio: " laurentiu.tudor
2019-05-14 15:17 ` [RFC PATCH v2 0/3] prerequisites for device reserved local mem rework Robin Murphy
2019-05-14 18:29 ` Fredrik Noring
2019-05-15 10:37 ` Laurentiu Tudor
2019-05-15 16:28 ` Fredrik Noring
2019-05-16 9:35 ` Laurentiu Tudor
2019-05-16 13:47 ` Fredrik Noring
2019-05-16 11:49 ` Laurentiu Tudor
2019-05-16 15:15 ` Fredrik Noring
2019-05-17 10:52 ` Laurentiu Tudor
2019-05-17 17:41 ` Fredrik Noring
2019-05-20 11:34 ` Laurentiu Tudor
2019-05-20 15:41 ` Fredrik Noring
2019-05-21 10:32 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521103214.GB1973@lst.de \
--to=hch@lst.de \
--cc=JuergenUrban@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=noring@nocrew.org \
--cc=robin.murphy@arm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).