From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5365C282DD for ; Thu, 23 May 2019 10:15:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 836EE21773 for ; Thu, 23 May 2019 10:15:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cEWib4SK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729698AbfEWKPQ (ORCPT ); Thu, 23 May 2019 06:15:16 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37176 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbfEWKPQ (ORCPT ); Thu, 23 May 2019 06:15:16 -0400 Received: by mail-wr1-f65.google.com with SMTP id e15so5630737wrs.4; Thu, 23 May 2019 03:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=U9kWFboW6XcJ3prQWjhWjMmlPfsMdYcgbJwfJuWODks=; b=cEWib4SKNxQ8+TV3EjdE1KNAYnTQMQB/SUAJDQn6O9/eH63hnxlPUQ11Qqk2g9JhmM gRCVR6cMMwx4uL9nqhr8fWnyq2Ukbvnz9Bix0fZzZ36Yi5e2oIawONoHKqMetB1HgJc6 E5KtQXhsDdz3zdggjGUqc+e1qYwWF4RLKQ6jjNMePdEDeo3ScWXSnYR040YiXe5SDqRK BJwKECuHHgMLT+skV9RsaGQihM2qhqzmj10Sa3+59UcVQ8iSH4v/zkM1ebrufDn5RZ87 LJVawxrKzErhR1hSANxysXRI8pd9H8B155GvSUWNsS3PAQ4B2pCiC2e96c7GpCDgwAdZ YQbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=U9kWFboW6XcJ3prQWjhWjMmlPfsMdYcgbJwfJuWODks=; b=Fgq+5MnwBoB6eTe3B4wMMK8XgJXxvAVoGSbn4YonRTeq0WWU07muTKQGw2pDgPTntS tX8AvajJMQOxb4S66LjntBw9A7v1M8Pu63dMj9LXY1TbmNs1tjcZHiFbnLEYTHzgVgiU eTWQm6VmF9DV5KsrbfiQAibP63VYeXpS+Hp/jILZhc2NUZQthyroKnL6kFz8eWRMtG1w joBUXHCEAahd5T0lx2X9ewfZeMY1sZUqeYd7i0WqY3c45ctaPFKthpHtwMln/gJIsEVZ PDGfhM7ZqjQykccBJMc2oABUxwbGl6VbVEerGcXe9/6S1Gr+Y1tg6bOAmov3vB/8E8/S Atnw== X-Gm-Message-State: APjAAAXEhl0ix8cJLii2zH3gJYlxvNBtj/1MZ6LM/0VgO1TaI3gm3ZU6 iVqw23Nxb66+OMUoT/biahc= X-Google-Smtp-Source: APXvYqxlOYwVgF/nRi/hsyeGUyvidTRUB37kvdgQKNiREpBavjo4O8mNMaL5B76y90O3q26YZbiyYA== X-Received: by 2002:adf:e301:: with SMTP id b1mr27591181wrj.304.1558606514329; Thu, 23 May 2019 03:15:14 -0700 (PDT) Received: from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54]) by smtp.gmail.com with ESMTPSA id y1sm9071531wma.14.2019.05.23.03.15.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 03:15:13 -0700 (PDT) Date: Thu, 23 May 2019 12:15:12 +0200 From: Thierry Reding To: Nagarjuna Kristam Cc: balbi@kernel.org, gregkh@linuxfoundation.org, jonathanh@nvidia.com, mark.rutland@arm.com, robh+dt@kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [Patch V3 5/8] arm64: tegra: Add xudc node for Tegra210 Message-ID: <20190523101512.GE30331@ulmo> References: <1557988772-15406-1-git-send-email-nkristam@nvidia.com> <1557988772-15406-6-git-send-email-nkristam@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X3gaHHMYHkYqP6yf" Content-Disposition: inline In-Reply-To: <1557988772-15406-6-git-send-email-nkristam@nvidia.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --X3gaHHMYHkYqP6yf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 16, 2019 at 12:09:29PM +0530, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. >=20 > Signed-off-by: Nagarjuna Kristam > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/d= ts/nvidia/tegra210.dtsi > index a550c0a..edef00b 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -1184,6 +1184,25 @@ > status =3D "disabled"; > }; > =20 > + xudc@700d0000 { > + compatible =3D "nvidia,tegra210-xudc"; > + reg =3D <0x0 0x700d0000 0x0 0x8000>, > + <0x0 0x700d8000 0x0 0x1000>, > + <0x0 0x700d9000 0x0 0x1000>; Same comments regarding alignment as for the bindings patch. > + interrupts =3D ; > + clocks =3D <&tegra_car TEGRA210_CLK_XUSB_DEV>, > + <&tegra_car TEGRA210_CLK_XUSB_SS>, > + <&tegra_car TEGRA210_CLK_XUSB_SSP_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>; Same here. > + clock-names =3D "dev", "ss", "ss_src", > + "hs_src", "fs_src"; No need to split this across multiple lines, it all fits within 72/80 characters. Thierry > + power-domains =3D <&pd_xusbdev>, <&pd_xusbss>; > + power-domain-names =3D "dev", "ss"; > + nvidia,xusb-padctl =3D <&padctl>; > + status =3D "disabled"; > + }; > + > mipi: mipi@700e3000 { > compatible =3D "nvidia,tegra210-mipi"; > reg =3D <0x0 0x700e3000 0x0 0x100>; > --=20 > 2.7.4 >=20 --X3gaHHMYHkYqP6yf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlzmcrAACgkQ3SOs138+ s6EI6Q/8C/tEyZ3kqPVWgXpCadqrSgkSRS7wF2qitJizWLq5HNXrft5rq2AgbHEe suqQeuxZtfEdVHqZRKA1u5kvgUNGtheWyfFlGhvlFywgjl1DKF6BghRbu+Fpmnb6 pOf6btzypjCMxPXEitBxtG23be/ozX2Eh6ItOKI8nEMmlSKZzQTlAMO1L4u2fpud 1rVidRQSuVLaulyu/XPjodMU/Q5a6GSEdN82Rw/ywkmbLgN0MAIK/lXEZtiscbFK 1LkNFrw/EIrCqkk9vDuAv9ta7xsoNx0HxTsDR/9E8+9GVSnfG7XN1bweNkDIdTlx uSKXMkPtJv1/Gho9g21jlj4hl9JIKzaj4bLhhXaR9mgSz68HEP7X+YiUrF0Ju8gw NghhEzNIQfawj7UWQhuKPRNQjUOUDgisSltsn0Rpsku6uVr8kScdxxk36k/rzcPD nuNN4rUaXmDScfCnCsggd69x+hC7eopllPtMrOgJlLxylZAkwSBJHSyl03m6dMUP MSFIAqWOXnJDZWc/nB3NvW5G1IAQdSMgiEeVrcEUcVp677L6qmzYK3LpJRCqUMV0 x0f3wSmbB+17rf18epZ6lY/BSWm8tnWHB6UDbAFEZeqIr6DcSWmpLOINu2XKIrC9 J/CBnj+cewWYzOEtIETSmQEefVHGs+GE8etz80NEyNdUk9zaYXg= =oAnT -----END PGP SIGNATURE----- --X3gaHHMYHkYqP6yf--