From: Sasha Levin <sashal@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.1 077/375] USB: serial: fix initial-termios handling
Date: Wed, 29 May 2019 14:56:34 -0400 [thread overview]
Message-ID: <20190529185634.GI12898@sasha-vm> (raw)
In-Reply-To: <20190523052600.GA15348@localhost>
On Thu, May 23, 2019 at 07:26:00AM +0200, Johan Hovold wrote:
>Hi Sasha,
>
>On Wed, May 22, 2019 at 03:16:17PM -0400, Sasha Levin wrote:
>> From: Johan Hovold <johan@kernel.org>
>>
>> [ Upstream commit 579bebe5dd522580019e7b10b07daaf500f9fb1e ]
>>
>> The USB-serial driver init_termios callback is used to override the
>> default initial terminal settings provided by USB-serial core.
>>
>> After a bug was fixed in the original implementation introduced by
>> commit fe1ae7fdd2ee ("tty: USB serial termios bits"), the init_termios
>> callback was no longer called just once on first use as intended but
>> rather on every (first) open.
>>
>> This specifically meant that the terminal settings saved on (final)
>> close were ignored when reopening a port for drivers overriding the
>> initial settings.
>>
>> Also update the outdated function header referring to the creation of
>> termios objects.
>>
>> Fixes: 7e29bb4b779f ("usb-serial: fix termios initialization logic")
>> Signed-off-by: Johan Hovold <johan@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>The stable tag was left out on purpose as this is essentially a new
>feature, and definitely a behavioural change which should not be
>backported.
>
>Please drop from your autosel queues.
Dropped!
>Also, may I ask you again not to include usb-serial (and drivers/gnss)
>in your autosel processing.
Of course, I've added it to my list.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-05-29 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190522192115.22666-1-sashal@kernel.org>
2019-05-22 19:15 ` [PATCH AUTOSEL 5.1 029/375] usb: dwc2: gadget: Increase descriptors count for ISOC's Sasha Levin
2019-05-22 19:15 ` [PATCH AUTOSEL 5.1 030/375] usb: dwc3: move synchronize_irq() out of the spinlock protected block Sasha Levin
2019-05-22 19:15 ` [PATCH AUTOSEL 5.1 031/375] usb: gadget: f_fs: don't free buffer prematurely Sasha Levin
2019-05-22 19:16 ` [PATCH AUTOSEL 5.1 077/375] USB: serial: fix initial-termios handling Sasha Levin
2019-05-23 5:26 ` Johan Hovold
2019-05-29 18:56 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529185634.GI12898@sasha-vm \
--to=sashal@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).