From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: linux-usb <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>
Subject: Re: [PATCH v2] USB: move usb debugfs directory creation to the usb common core
Date: Wed, 5 Jun 2019 14:39:52 +0200 [thread overview]
Message-ID: <20190605123952.GA17558@kroah.com> (raw)
In-Reply-To: <6ba00d6b-f236-f640-44b2-e801d9f2aa11@free.fr>
On Wed, Jun 05, 2019 at 01:44:26PM +0200, Marc Gonzalez wrote:
> On 05/06/2019 11:28, Greg Kroah-Hartman wrote:
>
> > The USB gadget subsystem wants to use the USB debugfs root directory, so
> > move it to the common "core" USB code so that it is properly initialized
> > and removed as needed.
> >
> > In order to properly do this, we need to load the common code before the
> > usb core code, when everything is linked into the kernel, so reorder the
> > link order of the code.
> >
> > Also as the usb common code has the possibility of the led trigger logic
> > to be merged into it, handle the build option properly by only having
> > one module init/exit function and have the common code initialize the
> > led trigger if needed.
> >
> > Reported-by: From: Chunfeng Yun <chunfeng.yun@mediatek.com>
>
> You have a spurious "From: " in there ;-)
Ugh, cut/paste error, thanks, will fix!
next prev parent reply other threads:[~2019-06-05 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 9:28 [PATCH v2] USB: move usb debugfs directory creation to the usb common core Greg Kroah-Hartman
2019-06-05 11:01 ` Chunfeng Yun
2019-06-05 12:40 ` Greg Kroah-Hartman
2019-06-05 11:44 ` Marc Gonzalez
2019-06-05 12:39 ` Greg Kroah-Hartman [this message]
2019-06-05 12:44 ` [PATCH v3] " Greg Kroah-Hartman
2019-06-06 2:32 ` Chunfeng Yun
2019-06-06 6:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605123952.GA17558@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=linux-usb@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).