From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: sisusbvga: Remove unneeded variable
Date: Wed, 5 Jun 2019 19:32:19 +0200 [thread overview]
Message-ID: <20190605173219.GC27700@kroah.com> (raw)
In-Reply-To: <20190605171908.GA10444@hari-Inspiron-1545>
On Wed, Jun 05, 2019 at 10:49:08PM +0530, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> drivers/usb/misc/sisusbvga/sisusb.c:1753:5-8: Unneeded variable: "ret".
> Return "0" on line 1877
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> index ea06f1f..dfe2ed1 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb.c
> +++ b/drivers/usb/misc/sisusbvga/sisusb.c
> @@ -1750,7 +1750,7 @@ static int sisusb_setup_screen(struct sisusb_usb_data *sisusb,
> static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
> int touchengines)
> {
> - int ret = 0, i, j, modex, bpp, du;
> + int i, j, modex, bpp, du;
> u8 sr31, cr63, tmp8;
> static const char attrdata[] = {
> 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
> @@ -1874,7 +1874,7 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
>
> SETIREG(SISCR, 0x34, 0x44); /* we just set std mode #44 */
>
> - return ret;
> + return 0;
If this function can not fail, why is it returning anything at all?
Please fix that up at the same time.
thanks,
greg k-h
prev parent reply other threads:[~2019-06-05 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 17:19 [PATCH] USB: sisusbvga: Remove unneeded variable Hariprasad Kelam
2019-06-05 17:32 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605173219.GC27700@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).