* [PATCH] USB: sisusbvga: Remove unneeded variable
@ 2019-06-05 17:19 Hariprasad Kelam
2019-06-05 17:32 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-06-05 17:19 UTC (permalink / raw)
To: Thomas Winischhofer, Greg Kroah-Hartman, linux-usb, linux-kernel
fix below warning reported by coccicheck
drivers/usb/misc/sisusbvga/sisusb.c:1753:5-8: Unneeded variable: "ret".
Return "0" on line 1877
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index ea06f1f..dfe2ed1 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -1750,7 +1750,7 @@ static int sisusb_setup_screen(struct sisusb_usb_data *sisusb,
static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
int touchengines)
{
- int ret = 0, i, j, modex, bpp, du;
+ int i, j, modex, bpp, du;
u8 sr31, cr63, tmp8;
static const char attrdata[] = {
0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
@@ -1874,7 +1874,7 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
SETIREG(SISCR, 0x34, 0x44); /* we just set std mode #44 */
- return ret;
+ return 0;
}
static int sisusb_init_gfxcore(struct sisusb_usb_data *sisusb)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] USB: sisusbvga: Remove unneeded variable
2019-06-05 17:19 [PATCH] USB: sisusbvga: Remove unneeded variable Hariprasad Kelam
@ 2019-06-05 17:32 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-05 17:32 UTC (permalink / raw)
To: Hariprasad Kelam; +Cc: Thomas Winischhofer, linux-usb, linux-kernel
On Wed, Jun 05, 2019 at 10:49:08PM +0530, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> drivers/usb/misc/sisusbvga/sisusb.c:1753:5-8: Unneeded variable: "ret".
> Return "0" on line 1877
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> index ea06f1f..dfe2ed1 100644
> --- a/drivers/usb/misc/sisusbvga/sisusb.c
> +++ b/drivers/usb/misc/sisusbvga/sisusb.c
> @@ -1750,7 +1750,7 @@ static int sisusb_setup_screen(struct sisusb_usb_data *sisusb,
> static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
> int touchengines)
> {
> - int ret = 0, i, j, modex, bpp, du;
> + int i, j, modex, bpp, du;
> u8 sr31, cr63, tmp8;
> static const char attrdata[] = {
> 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
> @@ -1874,7 +1874,7 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
>
> SETIREG(SISCR, 0x34, 0x44); /* we just set std mode #44 */
>
> - return ret;
> + return 0;
If this function can not fail, why is it returning anything at all?
Please fix that up at the same time.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-05 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-05 17:19 [PATCH] USB: sisusbvga: Remove unneeded variable Hariprasad Kelam
2019-06-05 17:32 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).