From: Greg KH <gregkh@linuxfoundation.org>
To: "Bollinger, Seth" <Seth.Bollinger@digi.com>
Cc: USB list <linux-usb@vger.kernel.org>,
Seth Bollinger <seth.boll@gmail.com>
Subject: Re: USB reset problem
Date: Thu, 6 Jun 2019 16:36:16 +0200 [thread overview]
Message-ID: <20190606143616.GB11294@kroah.com> (raw)
In-Reply-To: <A2655C7A-C29C-4462-A668-8F7B9C81A648@digi.com>
On Thu, Jun 06, 2019 at 01:55:37PM +0000, Bollinger, Seth wrote:
> Hello All,
>
> Recently we saw a problem where the device reset will fail due to a configuration descriptor check in hub.c:5600.
>
> if (memcmp(buf, udev->rawdescriptors[index], old_length)
> != 0) {
> dev_dbg(&udev->dev, "config index %d changed (#%d)\n",
> index,
> ((struct usb_config_descriptor *) buf)->
> bConfigurationValue);
> changed = 1;
> break;
> }
>
> The descriptors returned from the device have a different iInterface. I checked the usb spec and couldn’t find anything that says iInterface can’t change. I don’t have the source for the device, but I think it’s probably generating the interface string each reset and returning a different index for it (“ADB interface”).
>
> Has anyone else seen this? Does the spec guarantee that iInterface should never change between device resets?
If the descriptor changes between resets, that means that something
changed and we need to start over with it. What is the problem that
this is causing?
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-06 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 13:55 USB reset problem Bollinger, Seth
2019-06-06 14:36 ` Greg KH [this message]
2019-06-06 14:51 ` Bollinger, Seth
2019-06-06 15:03 ` Alan Stern
2019-06-06 15:19 ` Bollinger, Seth
2019-06-06 15:29 ` Greg KH
2019-06-06 14:37 ` Alan Stern
2019-06-06 15:01 ` Bollinger, Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606143616.GB11294@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Seth.Bollinger@digi.com \
--cc=linux-usb@vger.kernel.org \
--cc=seth.boll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).