From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE09FC28CC3 for ; Fri, 7 Jun 2019 08:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F03F20B7C for ; Fri, 7 Jun 2019 08:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbfFGIdT (ORCPT ); Fri, 7 Jun 2019 04:33:19 -0400 Received: from sauhun.de ([88.99.104.3]:41478 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfFGIdT (ORCPT ); Fri, 7 Jun 2019 04:33:19 -0400 Received: from localhost (p5486CE26.dip0.t-ipconnect.de [84.134.206.38]) by pokefinder.org (Postfix) with ESMTPSA id 2F7AE3E43BA; Fri, 7 Jun 2019 10:33:17 +0200 (CEST) Date: Fri, 7 Jun 2019 10:33:16 +0200 From: Wolfram Sang To: Ajay Gupta Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, Ajay Gupta Subject: Re: [PATCH v4 2/5] i2c: nvidia-gpu: add runtime pm support Message-ID: <20190607083316.GB3360@kunai> References: <20190603170545.24004-1-ajayg@nvidia.com> <20190603170545.24004-3-ajayg@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: <20190603170545.24004-3-ajayg@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + pm_runtime_mark_last_busy(i2cd->dev); > + pm_runtime_put_autosuspend(i2cd->dev); Much better to have this only once! > +/* > + * We need gpu_i2c_suspend() even if it is stub, for runtime pm to work > + * correctly. Without it, lspci shows runtime pm status as "D0" for the card. > + * Documentation/power/pci.txt also insists for driver to provide this: I'd think the comment up to here is enough and the rest can go. However, I leave this decision to you. --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlz6IUwACgkQFA3kzBSg Kbayuw//YoqrVxsInOgzDBmpVor1ssx26jYmc5NLKHY0ZzZYUsCp7EF19Ryq4rIU 6chHjJXuh+FcjBbZSracgax4p3HoEqFCzySG1dHk5dgjR5/MLfMEQuzmB7QTxqNw 4hLdw8KG9B2Nh6OCCqT9pEaaMyx5wGjY9fkUPBT5I1IPSY1lbvP0f+UlTAFU/7G1 H1/EgWhmcQPRgX9nh4MNW/WR04rrh89IPzzt2vi6eR4b2o1hSG3m5rEpHySbby+V 2bLJ31GGet75pEtO8mqu6RwhnP2h1+WXP71FaOShkBNu23EgHowRFcPdk5miiTiq x7mAIrK0MVoDGXU52xV05/0JeNXI4aRf/T8KKH9d/acmgPqzCgoPvj+5g5KrfvGB JJg9E3c/+i3CzrI6VOXsfd7WsbDFAtoTML2ZB3RyXqChg9px8c8joj1v6XQOXpJy /bLzvbw9H5U6KDyQf1w1dQGI6elI84vS+FvyYhjyOmDWgmgbtxn0ggUrk7XSutjW Zc559mQczVenavVLWbSkkqgbKgrEDJn9VmxBKtBHebti2R7NeLuEkgeJaYFqRWhC ZVB61b7+GEkCopZC739O+BYir6jZe0XKyAqgPcIipVhY/jcAP+Z0yXGrh3IkdZpt WdDxwhv78D7Ew2ZeWlahlzFXLNmcg9CT++hIVWD8KRGZ4+lRYyY= =Kubz -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--