* [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com>
@ 2019-06-09 8:08 Saurav-Girepunje
2019-06-09 8:14 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Saurav-Girepunje @ 2019-06-09 8:08 UTC (permalink / raw)
To: b-liu, gregkh, linux-usb, linux-kernel; +Cc: saurav.girepunje
---
drivers/usb/musb/musb_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 9f5a4819a744..2451e0ee2d01 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -909,7 +909,6 @@ static void musb_handle_intr_reset(struct musb *musb)
* @param musb instance pointer
* @param int_usb register contents
* @param devctl
- * @param power
*/
static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
--
2.20.1
Updated the function description of musb_stage0_irq.
a.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com>
2019-06-09 8:08 [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com> Saurav-Girepunje
@ 2019-06-09 8:14 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-06-09 8:14 UTC (permalink / raw)
To: Saurav-Girepunje; +Cc: b-liu, linux-usb, linux-kernel, saurav.girepunje
On Sun, Jun 09, 2019 at 01:38:02PM +0530, Saurav-Girepunje wrote:
> ---
> drivers/usb/musb/musb_core.c | 1 -
> 1 file changed, 1 deletion(-)
I think something went wrong with your commit :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com>
@ 2019-06-09 11:24 Saurav-Girepunje
2019-06-09 12:03 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Saurav-Girepunje @ 2019-06-09 11:24 UTC (permalink / raw)
To: b-liu, gregkh, linux-usb, linux-kernel; +Cc: saurav.girepunje
[-- Attachment #1: Updated the function description for musb_stage0_irq --]
[-- Type: text/plain, Size: 546 bytes --]
---
drivers/usb/musb/musb_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 9f5a4819a744..2451e0ee2d01 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -909,7 +909,6 @@ static void musb_handle_intr_reset(struct musb *musb)
* @param musb instance pointer
* @param int_usb register contents
* @param devctl
- * @param power
*/
static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
--
2.20.1
Regards,
Saurav Girepunje
[-- Attachment #2: 0001-Updated-the-function-description-for-musb_stage0_irq.patch --]
[-- Type: text/x-diff, Size: 813 bytes --]
From d861c19b28f6263f7c14c16e05398ddca06c56fb Mon Sep 17 00:00:00 2001
From: Saurav-Girepunje <saurav.girepunje@gmail.com>
Date: Sun, 9 Jun 2019 13:05:56 +0530
Subject: [PATCH] Updated the function description for musb_stage0_irq
Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com>
---
drivers/usb/musb/musb_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 9f5a4819a744..2451e0ee2d01 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -909,7 +909,6 @@ static void musb_handle_intr_reset(struct musb *musb)
* @param musb instance pointer
* @param int_usb register contents
* @param devctl
- * @param power
*/
static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com>
2019-06-09 11:24 Saurav-Girepunje
@ 2019-06-09 12:03 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-06-09 12:03 UTC (permalink / raw)
To: Saurav-Girepunje; +Cc: b-liu, linux-usb, linux-kernel, saurav.girepunje
On Sun, Jun 09, 2019 at 04:54:00PM +0530, Saurav-Girepunje wrote:
> ---
> drivers/usb/musb/musb_core.c | 1 -
> 1 file changed, 1 deletion(-)
Please stop, wait a few days, then fix your commit to not have
everything mushed into the subject: line, resend the patch to YOURSELF
to verify that it all works properly (and not as an attachment like you
did here), and then, if you are sure it is all good and working
properly, then send it out to the mailing list.
Note, please do cleanup stuff like this in the drivers/staging/
directory first, that area is much more forgiving of basic mistakes like
this than the rest of the kernel tree.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-09 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-09 8:08 [PATCH] Updated the function description for musb_stage0_irq Signed-off-by: Saurav-Girepunje <saurav.girepunje@gmail.com> Saurav-Girepunje
2019-06-09 8:14 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-06-09 11:24 Saurav-Girepunje
2019-06-09 12:03 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).