From: Christoph Hellwig <hch@lst.de>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
hch@lst.de, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] usb-storage: Add a limitation for blk_queue_max_hw_sectors()
Date: Thu, 13 Jun 2019 09:33:46 +0200 [thread overview]
Message-ID: <20190613073346.GB12093@lst.de> (raw)
In-Reply-To: <1560400504-26884-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
> + if (max_sectors > 0) {
> + struct device *dev = us->pusb_dev->bus->sysdev;
> + size_t max_dma_sectors = dma_max_mapping_size(dev) >>
> + SECTOR_SHIFT;
> +
> + max_sectors = min_t(size_t, max_sectors, max_dma_sectors);
> + blk_queue_max_hw_sectors(sdev->request_queue, max_sectors);
I think we need to do this unconditionally for the rare (or maybe even
theoretical case) of a dma max mapping size smaller than the default
max_sectos.
So something like this:
blk_queue_max_hw_sectors(sdev->request_queue,
min_t(unsigned long,
queue_max_hw_sectors(sdev->request_queue),
dma_max_mapping_size(dev) >> SECTOR_SHIFT));
next prev parent reply other threads:[~2019-06-13 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 4:35 [PATCH] usb-storage: Add a limitation for blk_queue_max_hw_sectors() Yoshihiro Shimoda
2019-06-13 7:33 ` Christoph Hellwig [this message]
2019-06-13 8:46 ` Yoshihiro Shimoda
2019-06-13 8:51 ` Christoph Hellwig
2019-06-13 9:03 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613073346.GB12093@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox