From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87EFC31E51 for ; Tue, 18 Jun 2019 07:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6F3F2080C for ; Tue, 18 Jun 2019 07:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560841399; bh=llqDQOaabgA4LoUF+l+Zv2639AhP35mJ+WTahE9pEqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FKuG2fxr8pZt5IwzSUMLree65CG7uZTpkNM16JciEDndtkIsROnj3Md0QwquHDmnk Z/EYFQftj5TcaDaukkfHmcd2n/eo5muyvIQhGCYDyJwLs5roD4B8Adzpm9sfJyXRDO gdd/jopAdI8lgj71NvmQGxBMN9wXm0HJrtJyDcJA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbfFRHDT (ORCPT ); Tue, 18 Jun 2019 03:03:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:33652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfFRHDS (ORCPT ); Tue, 18 Jun 2019 03:03:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C285B20665; Tue, 18 Jun 2019 07:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560841397; bh=llqDQOaabgA4LoUF+l+Zv2639AhP35mJ+WTahE9pEqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D6P4TRyLL5ubkD14ULgJICR/xWIZZywSwWwxotIi3lz7kJ6EX4HpKE0R4DmxDfyLK YYOEKIe5AwLsVKRnDq41NevjhBZNcHo9TQp+Aan0M8UrkKcOZw6wTwR9LJOZyUqjZy pwJ2kYMzRhqrCridYbdEX3gHUkNtd9F1qiVIuKBc= Date: Tue, 18 Jun 2019 09:03:15 +0200 From: Greg Kroah-Hartman To: Biju Das Cc: Heikki Krogerus , Matthias Brugger , Rob Herring , Felipe Balbi , Chunfeng Yun , "linux-usb@vger.kernel.org" , Simon Horman , Yoshihiro Shimoda , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Message-ID: <20190618070315.GA9160@kroah.com> References: <1559296800-5610-1-git-send-email-biju.das@bp.renesas.com> <1559296800-5610-4-git-send-email-biju.das@bp.renesas.com> <20190618064743.GA22269@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Jun 18, 2019 at 06:57:31AM +0000, Biju Das wrote: > Hi Greg, > > Thanks for the feedback. > > > -----Original Message----- > > From: Greg Kroah-Hartman > > Sent: Tuesday, June 18, 2019 7:48 AM > > To: Biju Das > > Cc: Heikki Krogerus ; Matthias Brugger > > ; Rob Herring ; Felipe Balbi > > ; Chunfeng Yun ; linux- > > usb@vger.kernel.org; Simon Horman ; Yoshihiro > > Shimoda ; Geert Uytterhoeven > > ; Chris Paterson > > ; Fabrizio Castro > > ; linux-renesas-soc@vger.kernel.org > > Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C > > DRP port controller > > > > On Fri, May 31, 2019 at 10:59:56AM +0100, Biju Das wrote: > > > Driver for TI HD3SS3220 USB Type-C DRP port controller. > > > > > > The driver currently registers the port and supports data role swapping. > > > > > > Signed-off-by: Biju Das > > > Acked-by: Heikki Krogerus > > > --- > > > > I tried to apply this, but get the following build error: > > > > drivers/usb/typec/hd3ss3220.c: In function hd3ss3220_probe: > > drivers/usb/typec/hd3ss3220.c:179:23: error: implicit declaration of function > > fwnode_usb_role_switch_get; did you mean usb_role_switch_get? [- > > Werror=implicit-function-declaration] > > hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > usb_role_switch_get > > drivers/usb/typec/hd3ss3220.c:179:21: warning: assignment to struct > > usb_role_switch * from int makes pointer from integer without a cast [-Wint- > > conversion] > > hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector); > > ^ > > > > You might want to fix that so the series can be applied :( > > This patch depend upon the below commit[1] which introduced the new API "fwnode_usb_role_switch_get()" > > [1] https://patchwork.kernel.org/patch/10986227/ ("usb: roles: Add fwnode_usb_role_switch_get() function") Ok, then I guess I will have to wait to merge this until that is accepted. Please resend when that happens. thanks, greg k-h