From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
nv@vosn.de
Subject: Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width
Date: Fri, 28 Jun 2019 12:58:43 +0300 [thread overview]
Message-ID: <20190628095843.GB21701@kuha.fi.intel.com> (raw)
In-Reply-To: <f8daf204d49fff00db33e2b417a20afcc58ad56e.1561712364.git.nikolaus.voss@loewensteinmedical.de>
On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote:
> Portinfo bit field is 3 bits wide, not 2 bits. This led to
> a wrong driver configuration for some tps6598x configurations.
>
> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Shouldn't this be applied to the stable trees as well?
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tps6598x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
> index c674abe3cf99..a170c49c2542 100644
> --- a/drivers/usb/typec/tps6598x.c
> +++ b/drivers/usb/typec/tps6598x.c
> @@ -41,7 +41,7 @@
> #define TPS_STATUS_VCONN(s) (!!((s) & BIT(7)))
>
> /* TPS_REG_SYSTEM_CONF bits */
> -#define TPS_SYSCONF_PORTINFO(c) ((c) & 3)
> +#define TPS_SYSCONF_PORTINFO(c) ((c) & 7)
>
> enum {
> TPS_PORTINFO_SINK,
> --
> 2.17.1
thanks,
--
heikki
next prev parent reply other threads:[~2019-06-28 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 8:12 [PATCH] drivers/usb/typec/tps6598x.c: fix two bugs Nikolaus Voss
2019-06-28 8:18 ` Greg Kroah-Hartman
2019-06-28 8:34 ` Heikki Krogerus
2019-06-28 9:01 ` [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width Nikolaus Voss
2019-06-28 9:58 ` Heikki Krogerus [this message]
2019-06-28 10:10 ` Nikolaus Voss
2019-07-03 16:39 ` Greg Kroah-Hartman
2019-07-03 17:25 ` Nikolaus Voss
2019-07-03 17:37 ` Greg Kroah-Hartman
2019-06-28 9:01 ` [PATCH 2/2] drivers/usb/typec/tps6598x.c: fix 4CC cmd write Nikolaus Voss
2019-06-28 9:59 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628095843.GB21701@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=nv@vosn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).