From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AF1C46478 for ; Fri, 28 Jun 2019 15:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E14D208E3 for ; Fri, 28 Jun 2019 15:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561734950; bh=Gx6kCyMvU3foUUu4wXaddUuw8z1UuNpW8LTKHcfjXTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=10lpO3HpR0ciSWSg+7K38YCMaQPsteB1/E/1h/lT/aDHGYTvURbuQANspgu46oiAY Gvs8R2yqUQ6sEM/npSyB+2SpmkyFCWT2F2VTOe3ES2nk3CgU52tI4wmnEE/y2g4Pyv Z6V4rEYiM2loADc0ryBFFfIvuzqsDQkQYlE+8Y+s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbfF1PPt (ORCPT ); Fri, 28 Jun 2019 11:15:49 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42540 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbfF1PPt (ORCPT ); Fri, 28 Jun 2019 11:15:49 -0400 Received: by mail-lj1-f196.google.com with SMTP id t28so6342326lje.9; Fri, 28 Jun 2019 08:15:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0Mod7XgX0UF5WjrbK2QZuFathVF7Rrka7CyhDtFJsdU=; b=CPBjdqzQ6Wv3i6gvtxUIP98ycpiKDyGw1O8yk8YNWV9NYqJCr/anL2Ppa5eVirwBBJ 56vA+ozMXu1f8OrQHLEqZnACMGNq03yyxHu6IvRk29meH5qpP6KCtXKV8x4VIPsnaM/w by+ELJEptFJaFPhbu1xNhYt0ma30Yfm1+K2ClERfRKI48JuBb2S5TK3jqTd2qkA31cbj O+NI/EMgNbjDd9otcwmw8mYgLxv+UrIXHEKAJYpqA4o3c+vvlz9h1Wvagx7XIXBGvrW9 BGpoxVJ+Ajmd535viZQtmPVjDYVSlY5k7bHUHMSks/a0sTI4RP+yQmAUE2Hpd7yr2Kdi eAAw== X-Gm-Message-State: APjAAAV8NPJQcrlaupriYmjE/rP1Q3lJ8+4f0sn+3x5laAl+Owj7HCgV yZEL3DkQk2x0jAYNYd7riwM= X-Google-Smtp-Source: APXvYqwF8mb/EdTGF1HkHWzrVUZKv9spXE+b3bGVHgIccK7oXtCH22+OMHYMff8Lew0uHEdjPBw0sQ== X-Received: by 2002:a2e:2b57:: with SMTP id q84mr6575971lje.105.1561734946649; Fri, 28 Jun 2019 08:15:46 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id z26sm782395ljz.64.2019.06.28.08.15.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jun 2019 08:15:45 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.92) (envelope-from ) id 1hgsbH-0002nh-Eq; Fri, 28 Jun 2019 17:15:43 +0200 Date: Fri, 28 Jun 2019 17:15:43 +0200 From: Johan Hovold To: Andreas Fritiofson Cc: Johan Hovold , linux-usb@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: ftdi_sio: add ID for isodebug v1 Message-ID: <20190628151543.GO508@localhost> References: <20190628130834.32432-1-andreas.fritiofson@unjo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628130834.32432-1-andreas.fritiofson@unjo.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jun 28, 2019 at 03:08:34PM +0200, Andreas Fritiofson wrote: > This adds the vid:pid of the isodebug v1 isolated JTAG/SWD+UART. Only the > second channel is available for use as a serial port. > > Signed-off-by: Andreas Fritiofson > --- > drivers/usb/serial/ftdi_sio.c | 1 + > drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c > index 8f5b17471..ba74c2ad6 100644 > --- a/drivers/usb/serial/ftdi_sio.c > +++ b/drivers/usb/serial/ftdi_sio.c > @@ -1027,6 +1027,7 @@ static const struct usb_device_id id_table_combined[] = { > { USB_DEVICE(AIRBUS_DS_VID, AIRBUS_DS_P8GR) }, > /* EZPrototypes devices */ > { USB_DEVICE(EZPROTOTYPES_VID, HJELMSLUND_USB485_ISO_PID) }, > + { USB_DEVICE_INTERFACE_NUMBER(UNJO_VID, ISODEBUG_V1_PID, 1) }, > { } /* Terminating entry */ > }; > > diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h > index b863bedb5..5c681f494 100644 > --- a/drivers/usb/serial/ftdi_sio_ids.h > +++ b/drivers/usb/serial/ftdi_sio_ids.h > @@ -1541,3 +1541,9 @@ > #define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */ > #define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */ > #define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */ > + > +/* > + * Unjo AB > + */ > +#define UNJO_VID 0x22B7 > +#define ISODEBUG_V1_PID 0x150D I added an UNJO_ prefix to the PID define since I assume this is your product (named ISODEBUG). Now applied, thanks. Johan