From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Aidan Thornton <makosoft@gmail.com>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Marco Zatta <marco@zatta.me>
Subject: Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.
Date: Tue, 2 Jul 2019 15:25:20 +0200 [thread overview]
Message-ID: <20190702132520.GA22668@kroah.com> (raw)
In-Reply-To: <1562071602.5819.14.camel@suse.com>
On Tue, Jul 02, 2019 at 02:46:42PM +0200, Oliver Neukum wrote:
> Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton:
>
> > This doesn't make much sense though. e387ef5c47dd should apply this
> > quirk to all Logitech UVC webcams, and this is definitely a UVC-based
> > Logitech webcam with the appropriate VID and interface descriptor.
> > Surely it shouldn't make any difference whether I add an entry for the
> > specific VID+PID pair of my particular camera or not? The C270 is as
> > well, I think.
>
> Well, it is applied a little later.
>
> > What's particularly annoying is that since this is an intermittent
> > problem, it's hard to tell if I'm chasing a phantom solution for it
> > again. Haven't managed to replicate it since applying this fix and did
> > so pretty quickly before but you never know.
>
> Should I just readd everything removed in e387ef5c47dd?
>
> Greg, what do you think? This is hard to test, the hardware is old
> and I want to avoid chasing them all separately.
It's up to you, if you think the issue is resolved if we readd
everything, that's fine with me.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-02 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 7:52 [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio Marco Zatta
2019-06-01 9:33 ` Sergei Shtylyov
2019-06-01 10:11 ` Marco Zatta
2019-06-01 11:45 ` Greg KH
2019-06-03 9:58 ` Oliver Neukum
2019-06-03 17:55 ` Marco Zatta
2019-06-04 9:14 ` Oliver Neukum
2019-06-05 9:30 ` Greg Kroah-Hartman
2019-06-20 20:19 ` Aidan Thornton
2019-07-02 12:46 ` Oliver Neukum
2019-07-02 13:25 ` Greg Kroah-Hartman [this message]
2019-07-03 13:54 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702132520.GA22668@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=makosoft@gmail.com \
--cc=marco@zatta.me \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).