From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AECAC0650E for ; Wed, 3 Jul 2019 19:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 463BD21882 for ; Wed, 3 Jul 2019 19:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562183955; bh=qyhSe/m3iFJvhjLT7XfiQp9W/+VrvcZY//8DOqO8pmo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uolWucLyn7WbRm+ODZj0ZRLNaFSC+Tz0AcNnK44MhoBk7EEicW9B/YQde6KSHLtMi 4Ky+c9elKfPY98D5rT/PYvPXZ9cUCHlmE2F1W0hyYutpTdDEscPmXJ0NIiZNJPqOHs 3JDZp7X58J/lFCc5DHFWoLqQ2N3qHqKFr5rsbIfQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfGCT7K (ORCPT ); Wed, 3 Jul 2019 15:59:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfGCT7K (ORCPT ); Wed, 3 Jul 2019 15:59:10 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4626421882; Wed, 3 Jul 2019 19:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562183949; bh=qyhSe/m3iFJvhjLT7XfiQp9W/+VrvcZY//8DOqO8pmo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0glXAHEjYCtRfQ5vgverCgt8lN8cjzwgJLzBScTnm4hRnf3ldUCMP9XpFA1splffi FUkETyP3XuHqUK65m2k+5kiWTWSssP+CnWNZof/ivMKz5ZY8Po2X7RIVmE7ls0wVs6 09PoNq5qg00FHriHOQZGjufA54HkOAKIB7mNepRk= Date: Wed, 3 Jul 2019 15:59:08 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fei Yang , Sam Protsenko , Felipe Balbi , linux-usb@vger.kernel.org, Felipe Balbi , John Stultz Subject: Re: [PATCH 4.19 26/72] usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue() Message-ID: <20190703195908.GC2733@sasha-vm> References: <20190702080124.564652899@linuxfoundation.org> <20190702080126.031346654@linuxfoundation.org> <20190703020312.GS11506@sasha-vm> <20190703072012.GA3033@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190703072012.GA3033@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jul 03, 2019 at 09:20:12AM +0200, Greg Kroah-Hartman wrote: >On Tue, Jul 02, 2019 at 10:03:12PM -0400, Sasha Levin wrote: >> On Tue, Jul 02, 2019 at 10:01:27AM +0200, Greg Kroah-Hartman wrote: >> > commit c3acd59014148470dc58519870fbc779785b4bf7 upstream >> > >> > Now that we track how many TRBs a request uses, it's easier to skip >> > over them in case of a call to usb_ep_dequeue(). Let's do so and >> > simplify the code a bit. >> > >> > Cc: Fei Yang >> > Cc: Sam Protsenko >> > Cc: Felipe Balbi >> > Cc: linux-usb@vger.kernel.org >> > Cc: stable@vger.kernel.org # 4.19.y >> > Signed-off-by: Felipe Balbi >> > (cherry picked from commit c3acd59014148470dc58519870fbc779785b4bf7) >> > Signed-off-by: John Stultz >> > Signed-off-by: Sasha Levin >> >> This one has an upstream fix: c7152763f02e05567da27462b2277a554e507c89 >> ("usb: dwc3: Reset num_trbs after skipping"). > >You were the one who queued this series up :) Indeed, and I'm actually quite happy about this. Even though I goofed up and didn't notice the fix when it got queued up, the automation we have in place to catch these cases worked and we were able to get the fix in as well before release. -- Thanks, Sasha