From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DEFC46499 for ; Fri, 5 Jul 2019 11:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A9CB218CD for ; Fri, 5 Jul 2019 11:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562327359; bh=wKj2+prk7mS4NOrXmVTjVpgQi+0EdZmxKsCZK4x2xj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bPEG32ze5O+SalMsCsg7clg6r+AVAi92iikBmKbtAKguEOPIqpFVVV/Vi36SuWjqD keEWUlyyO9Wrv1a156opUD+F68g9yV/DZpO83kQ6j0FRouSbUQ0xekeQrKiEDa32nb yQPG/FtxfR2ETg4qrIeVpbsqObnmGhO0Q9slqX30= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbfGELtP (ORCPT ); Fri, 5 Jul 2019 07:49:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfGELtP (ORCPT ); Fri, 5 Jul 2019 07:49:15 -0400 Received: from localhost (83-84-126-242.cable.dynamic.v4.ziggo.nl [83.84.126.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9325E20828; Fri, 5 Jul 2019 11:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562327354; bh=wKj2+prk7mS4NOrXmVTjVpgQi+0EdZmxKsCZK4x2xj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BnNkGwLeQ4mmrtfMkcYD171d2LV8PC52F6EQsHUdTHEZ3CV31bN9gRDCLzyGDwxcN KV8pA5E38hYpMzNYl3OW8MYs9pMI7frL9ikDh+u1BCRi1tzrj8g24p/+EBXyS3NMLI +e2Y4VYwrxdA8sN2fekdHbye3ukBMA9pN5uESa5w= Date: Fri, 5 Jul 2019 13:49:11 +0200 From: Greg KH To: Pawel Laszczak Cc: "devicetree@vger.kernel.org" , "felipe.balbi@linux.intel.com" , "linux-usb@vger.kernel.org" , "hdegoede@redhat.com" , "heikki.krogerus@linux.intel.com" , "robh+dt@kernel.org" , "rogerq@ti.com" , "linux-kernel@vger.kernel.org" , "jbergsagel@ti.com" , "nsekhar@ti.com" , "nm@ti.com" , Suresh Punnoose , "peter.chen@nxp.com" , Jayshri Dajiram Pawar , Rahul Kumar Subject: Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver. Message-ID: <20190705114911.GA31190@kroah.com> References: <1562324238-16655-1-git-send-email-pawell@cadence.com> <1562324238-16655-3-git-send-email-pawell@cadence.com> <20190705112724.GA4294@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Jul 05, 2019 at 11:39:57AM +0000, Pawel Laszczak wrote: > > >On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: > >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > >> to driver/usb/gadget/debug.c file. These moved functions include: > >> dwc3_decode_get_status > >> dwc3_decode_set_clear_feature > >> dwc3_decode_set_address > >> dwc3_decode_get_set_descriptor > >> dwc3_decode_get_configuration > >> dwc3_decode_set_configuration > >> dwc3_decode_get_intf > >> dwc3_decode_set_intf > >> dwc3_decode_synch_frame > >> dwc3_decode_set_sel > >> dwc3_decode_set_isoch_delay > >> dwc3_decode_ctrl > >> > >> These functions are used also in inroduced cdns3 driver. > >> > >> All functions prefixes were changed from dwc3 to usb. > >> Also, function's parameters has been extended according to the name > >> of fields in standard SETUP packet. > >> Additionally, patch adds usb_decode_ctrl function to > >> include/linux/usb/gadget.h file. > > > >No it does not :( > > I've forgot about this :( > > It should be include/linux/usb/ch.9.h > > > > >> Signed-off-by: Pawel Laszczak > >> --- > >> drivers/usb/common/Makefile | 5 + > >> drivers/usb/common/debug.c | 268 ++++++++++++++++++++++++++++++++++++ > >> drivers/usb/dwc3/debug.h | 252 --------------------------------- > >> drivers/usb/dwc3/trace.h | 2 +- > >> include/linux/usb/ch9.h | 25 ++++ > >> 5 files changed, 299 insertions(+), 253 deletions(-) > >> create mode 100644 drivers/usb/common/debug.c > >> > >> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile > >> index 0a7c45e85481..cdc66b59a6f0 100644 > >> --- a/drivers/usb/common/Makefile > >> +++ b/drivers/usb/common/Makefile > >> @@ -5,6 +5,11 @@ > >> > >> obj-$(CONFIG_USB_COMMON) += usb-common.o > >> usb-common-y += common.o > >> + > >> +ifneq ($(CONFIG_TRACING),) > >> + usb-common-y += debug.o > >> +endif > > > >So only enable this if tracing is not emabled? Or if enabled? I'm > >confused, isn't there an easier way to write this? > > It's checks if CONFIG_TRACING is enable. > It's a common way checking if option is enabled in usb subsystem. Why not just write this as: usb-common-$(CONFIG_TRACING) += debug.o ? thanks, greg k-h