From: Johan Hovold <johan@kernel.org>
To: Dan Williams <dcbw@redhat.com>
Cc: Rogan Dawes <rogan@dawes.za.net>,
linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Lars Melin <larsm17@gmail.com>
Subject: Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID
Date: Wed, 17 Jul 2019 08:19:02 +0200 [thread overview]
Message-ID: <20190717061902.GA16694@localhost> (raw)
In-Reply-To: <c80b2d08453ba94d3762021d6a184acfd6b1762e.camel@redhat.com>
On Tue, Jul 16, 2019 at 08:43:52PM -0500, Dan Williams wrote:
> On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote:
> > Add device id for D-Link DWM-222.
> > @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = {
> > .driver_info = RSVD(4) },
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */
> > .driver_info = RSVD(4) },
> > + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */
> > + .driver_info = RSVD(0) | RSVD(4) },
>
> I don't think we actually do need to blacklist interface 0, since
> that's likely a QCDM/DIAG interface and that does need a serial driver
> like option or qcserial.
>
> Johan, any reason why you thought we should blacklist 0?
It was just me being confused about the Qualcomm protocols and how the
diag port was accessed from user space. Thanks, Dan.
Rogan, let's keep interface 0 and only blacklist interface 4 as you did
originally. Sorry about the confusion.
Johan
next prev parent reply other threads:[~2019-07-17 6:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 9:40 [PATCH] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes
2019-07-11 10:34 ` [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] Rogan Dawes
2019-07-16 9:11 ` Johan Hovold
2019-07-16 10:55 ` Rogan Dawes
2019-07-16 11:17 ` Johan Hovold
2019-07-16 14:34 ` Lars Melin
2019-07-16 18:05 ` Johan Hovold
2019-07-16 18:40 ` Rogan Dawes
2019-07-16 18:49 ` Rogan Dawes
2019-07-16 19:02 ` [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes
2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes
2019-07-16 19:37 ` Greg KH
2019-07-16 19:44 ` Johan Hovold
2019-07-17 1:43 ` Dan Williams
2019-07-17 6:19 ` Johan Hovold [this message]
2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes
2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes
2019-07-18 23:34 ` David Miller
2019-07-17 9:20 ` [PATCH v6] USB: serial: option: add D-Link DWM-222 " Johan Hovold
2019-07-17 9:37 ` Rogan Dawes
2019-08-05 11:36 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717061902.GA16694@localhost \
--to=johan@kernel.org \
--cc=dcbw@redhat.com \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=rogan@dawes.za.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).