From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABECC3A59E for ; Mon, 26 Aug 2019 04:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B044221848 for ; Mon, 26 Aug 2019 04:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566795204; bh=Y3mEduzKt2IMLRPCc/9d2tQAduv/qs1pdxGcl2GFft0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Mt50JXQ5fGFTEMWWJkS14fTaz/eSaw78EH4aI40Af/fq/XmlqliY/Y3M8eRCiSZEa Q0M/s3jPPffqDtFRCT8pIZ+EvZ5nNBj8HYrsPQkPgdBf0CzCmUOoiD2wm8fA5P8Kgh /PK21VJ0OJw9dHVsbA6hajtCHN4/NIQXC6oMbpPg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726740AbfHZExT (ORCPT ); Mon, 26 Aug 2019 00:53:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:34812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbfHZExT (ORCPT ); Mon, 26 Aug 2019 00:53:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB4C92070B; Mon, 26 Aug 2019 04:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566795198; bh=Y3mEduzKt2IMLRPCc/9d2tQAduv/qs1pdxGcl2GFft0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyAooLrKGZoXcgtWaM75AD61npujRwChi/03co9+kSqt1+0c8py9dZJehKnajJKkx rJaHOMobdxkVin8ch8Uy+uOInt7rqFwiFEve5XVFLuxtEmqsNewr12DiBcQSUKwfY3 znLCKoyLVivek0GCr1uDhRSvtPLzE9b30oxff7QU= Date: Mon, 26 Aug 2019 06:53:15 +0200 From: Greg KH To: Kai-Heng Feng Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] USB: storage: ums-realtek: Rename module parameter auto_delink_en to auto_delink_mode Message-ID: <20190826045315.GC1678@kroah.com> References: <20190826044630.21949-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190826044630.21949-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Aug 26, 2019 at 12:46:29PM +0800, Kai-Heng Feng wrote: > The option named "auto_delink_en" is a bit misleading, as setting it to > false doesn't really disable auto-delink but let auto-delink be firmware > controlled. > > Rename it to reflect the real usage of this parameter. > > Signed-off-by: Kai-Heng Feng > --- > drivers/usb/storage/realtek_cr.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c > index cc794e25a0b6..4d86cfcc0b40 100644 > --- a/drivers/usb/storage/realtek_cr.c > +++ b/drivers/usb/storage/realtek_cr.c > @@ -36,9 +36,9 @@ MODULE_DESCRIPTION("Driver for Realtek USB Card Reader"); > MODULE_AUTHOR("wwang "); > MODULE_LICENSE("GPL"); > > -static int auto_delink_en = 1; > -module_param(auto_delink_en, int, S_IRUGO | S_IWUSR); > -MODULE_PARM_DESC(auto_delink_en, "enable auto delink"); > +static int auto_delink_mode = 1; > +module_param(auto_delink_mode, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(auto_delink_mode, "auto delink mode (0=firmware, 1=software [default])"); We can not just rename module parameters, as that will break working systems that have their startup scripts using those names :( sorry, greg k-h