From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Saranya Gopal <saranya.gopal@intel.com>
Cc: hdegoede@redhat.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
Balaji Manoharan <m.balaji@intel.com>
Subject: Re: [PATCH v3 2/2] usb: roles: intel: Enable static DRD mode for role switch
Date: Thu, 29 Aug 2019 10:53:07 +0300 [thread overview]
Message-ID: <20190829075307.GD5486@kuha.fi.intel.com> (raw)
In-Reply-To: <1567011332-22839-2-git-send-email-saranya.gopal@intel.com>
Hi,
> static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
> @@ -44,7 +52,7 @@ static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
> struct intel_xhci_usb_data *data = dev_get_drvdata(dev);
> unsigned long timeout;
> acpi_status status;
> - u32 glk, val;
> + u32 glk, val, drd_config;
I guess you need to fix that. While at it, please introduce it on its
own line:
u32 drd_config = DRD_CONFIG_DYNAMIC;
thanks,
--
heikki
prev parent reply other threads:[~2019-08-29 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 16:55 [PATCH v3 1/2] xhci-ext-caps.c: Add property to disable Intel SW switch Saranya Gopal
2019-08-28 16:55 ` [PATCH v3 2/2] usb: roles: intel: Enable static DRD mode for role switch Saranya Gopal
2019-08-28 20:29 ` kbuild test robot
2019-08-29 7:53 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829075307.GD5486@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=m.balaji@intel.com \
--cc=mathias.nyman@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).